diff mbox series

[ovs-dev,resend] CI: Use ovn-k8s master commit for k8s kind tests.

Message ID 20210816213045.2245170-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev,resend] CI: Use ovn-k8s master commit for k8s kind tests. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Numan Siddique Aug. 16, 2021, 9:30 p.m. UTC
From: Numan Siddique <numans@ovn.org>

All the ovn-k8s tests in OVN are now failing since a few weeks.
Bumping the ovn-k8s commit to the latest one in my private
CI run passed all the tests except the control plane test [1].
control plane test is failing since a while and this needs to be
debugged.

ovn-k8s repo runs the same k8s kind tests with OVN version present in
fedora 33 before merging a patch.  So I think it should be fine to switch
to the master commit of ovn-k8s.

[1] - https://github.com/numansiddique/ovn/runs/3315367278

Signed-off-by: Numan Siddique <numans@ovn.org>
---
 .github/workflows/ovn-kubernetes.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Gray Aug. 17, 2021, 7:21 a.m. UTC | #1
On 16/08/2021 22:30, numans@ovn.org wrote:
> From: Numan Siddique <numans@ovn.org>
> 
> All the ovn-k8s tests in OVN are now failing since a few weeks.
> Bumping the ovn-k8s commit to the latest one in my private
> CI run passed all the tests except the control plane test [1].
> control plane test is failing since a while and this needs to be
> debugged.
> 
> ovn-k8s repo runs the same k8s kind tests with OVN version present in
> fedora 33 before merging a patch.  So I think it should be fine to switch
> to the master commit of ovn-k8s.
> 
> [1] - https://github.com/numansiddique/ovn/runs/3315367278

Thanks for following up on this as I was going to look at it today. Do
you have any idea what caused the failure?

> 
> Signed-off-by: Numan Siddique <numans@ovn.org>
> ---
>  .github/workflows/ovn-kubernetes.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
> index 03721c109..f9ea33247 100644
> --- a/.github/workflows/ovn-kubernetes.yml
> +++ b/.github/workflows/ovn-kubernetes.yml
> @@ -11,7 +11,7 @@ on:
>  env:
>    GO_VERSION: "1.16.3"
>    K8S_VERSION: v1.20.2
> -  OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b"
> +  OVNKUBE_COMMIT: "master"
>    KIND_CLUSTER_NAME: ovn
>    KIND_INSTALL_INGRESS: true
>    KIND_ALLOW_SYSTEM_WRITES: true
> 

Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
Numan Siddique Aug. 17, 2021, 4:33 p.m. UTC | #2
On Tue, Aug 17, 2021 at 3:22 AM Mark Gray <mark.d.gray@redhat.com> wrote:
>
> On 16/08/2021 22:30, numans@ovn.org wrote:
> > From: Numan Siddique <numans@ovn.org>
> >
> > All the ovn-k8s tests in OVN are now failing since a few weeks.
> > Bumping the ovn-k8s commit to the latest one in my private
> > CI run passed all the tests except the control plane test [1].
> > control plane test is failing since a while and this needs to be
> > debugged.
> >
> > ovn-k8s repo runs the same k8s kind tests with OVN version present in
> > fedora 33 before merging a patch.  So I think it should be fine to switch
> > to the master commit of ovn-k8s.
> >
> > [1] - https://github.com/numansiddique/ovn/runs/3315367278
>
> Thanks for following up on this as I was going to look at it today. Do
> you have any idea what caused the failure?

Thanks for the review.  I didn't get the chance to debug it.
My guess is something in k8s changed which is causing this failure.
Otherwise with the same ovn-k8s commit the tests were passing (except
the control plane)
a couple of weeks ago.


>
> >
> > Signed-off-by: Numan Siddique <numans@ovn.org>
> > ---
> >  .github/workflows/ovn-kubernetes.yml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
> > index 03721c109..f9ea33247 100644
> > --- a/.github/workflows/ovn-kubernetes.yml
> > +++ b/.github/workflows/ovn-kubernetes.yml
> > @@ -11,7 +11,7 @@ on:
> >  env:
> >    GO_VERSION: "1.16.3"
> >    K8S_VERSION: v1.20.2
> > -  OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b"
> > +  OVNKUBE_COMMIT: "master"
> >    KIND_CLUSTER_NAME: ovn
> >    KIND_INSTALL_INGRESS: true
> >    KIND_ALLOW_SYSTEM_WRITES: true
> >
>
> Acked-by: Mark D. Gray <mark.d.gray@redhat.com>

I applied this patch to the main branch.

Numan

>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
index 03721c109..f9ea33247 100644
--- a/.github/workflows/ovn-kubernetes.yml
+++ b/.github/workflows/ovn-kubernetes.yml
@@ -11,7 +11,7 @@  on:
 env:
   GO_VERSION: "1.16.3"
   K8S_VERSION: v1.20.2
-  OVNKUBE_COMMIT: "c9cd438575f11584871309740c78dde29752940b"
+  OVNKUBE_COMMIT: "master"
   KIND_CLUSTER_NAME: ovn
   KIND_INSTALL_INGRESS: true
   KIND_ALLOW_SYSTEM_WRITES: true