| Message ID | 20210723203242.88845-1-festevam@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: imx8ulp: Initialize pin_reg | expand |
On Fri, Jul 23, 2021 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote: > The initialization of pin_reg is missing, causing the following build > warning: > > drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function [-Wuninitialized] > > Initialize pin_reg the same way as it is done on vf610 and imx7ulp > to fix the problem. > > Fixes: 16b343e8e0ef ("pinctrl: imx8ulp: Add pinctrl driver support") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> Wow how fast! Patch applied. Thanks for fixing Fabio, excellent work as always. Yours, Linus Walleij
> Subject: Re: [PATCH] pinctrl: imx8ulp: Initialize pin_reg > > On Fri, Jul 23, 2021 at 10:33 PM Fabio Estevam <festevam@gmail.com> > wrote: > > > The initialization of pin_reg is missing, causing the following build > > warning: > > > > drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' > > is used uninitialized in this function [-Wuninitialized] > > > > Initialize pin_reg the same way as it is done on vf610 and imx7ulp to > > fix the problem. > > > > Fixes: 16b343e8e0ef ("pinctrl: imx8ulp: Add pinctrl driver support") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Wow how fast! > Patch applied. > Thanks for fixing Fabio, excellent work as always. > It's my fault. when I did a change in V2, one additional line was removed wrongly, sorry for inconvenience. BR Jacky Bai > Yours, > Linus Walleij
diff --git a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c index c5db5dfcfcce..f8572597a54e 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c +++ b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c @@ -225,6 +225,10 @@ static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, const struct imx_pin_reg *pin_reg; u32 reg; + pin_reg = &ipctl->pin_regs[offset]; + if (pin_reg->mux_reg == -1) + return -EINVAL; + reg = readl(ipctl->base + pin_reg->mux_reg); if (input) reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED;
The initialization of pin_reg is missing, causing the following build warning: drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function [-Wuninitialized] Initialize pin_reg the same way as it is done on vf610 and imx7ulp to fix the problem. Fixes: 16b343e8e0ef ("pinctrl: imx8ulp: Add pinctrl driver support") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/pinctrl/freescale/pinctrl-imx8ulp.c | 4 ++++ 1 file changed, 4 insertions(+)