| Message ID | 20210707141010.536437-1-andy.chi@canonical.com |
|---|---|
| Headers | show |
| Series | Mute/mic LEDs no function on some HP platfroms | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 7/7/21 8:09 AM, Andy Chi wrote: > BugLink: https://bugs.launchpad.net/bugs/1934878 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ProBook 630 G8 Notebook PC > 2) HP ProBook 445 G8 Notebook PC > 3) HP ProBook 450 G8 Notebook PC > > [Fix] > It needs the specific quirk for the hardware layout. > Thus, add the quirks to make it works. > > [Test] > After applying the quirk, the audio/mic mute LEDs are working good. > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone). > > Andy Chi (3): > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) >
On 07.07.21 16:09, Andy Chi wrote: > BugLink: https://bugs.launchpad.net/bugs/1934878 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ProBook 630 G8 Notebook PC > 2) HP ProBook 445 G8 Notebook PC > 3) HP ProBook 450 G8 Notebook PC > > [Fix] > It needs the specific quirk for the hardware layout. > Thus, add the quirks to make it works. > > [Test] > After applying the quirk, the audio/mic mute LEDs are working good. > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone). > > Andy Chi (3): > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > I have fixed up the nominations on the bug report. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks
applied to oem-5.10, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>
applied to oem-5.13, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>
On 07.07.21 16:09, Andy Chi wrote: > BugLink: https://bugs.launchpad.net/bugs/1934878 > > [Impact] > The mic mute/audio mute LEDS are not work on > 1) HP ProBook 630 G8 Notebook PC > 2) HP ProBook 445 G8 Notebook PC > 3) HP ProBook 450 G8 Notebook PC > > [Fix] > It needs the specific quirk for the hardware layout. > Thus, add the quirks to make it works. > > [Test] > After applying the quirk, the audio/mic mute LEDs are working good. > > [Where problems could occur] > If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone). > > Andy Chi (3): > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 > ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 > > sound/pci/hda/patch_realtek.c | 4 ++++ > 1 file changed, 4 insertions(+) > Applied to hirsute:linux. Thanks, Kleber
On Wed, Jul 07, 2021 at 10:09:58PM +0800, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934878
They all came down as part of upstram/5.13.y stable fixes.