Message ID | 5eec1cef-521b-f612-fb24-85314486c35c@denx.de |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | Pull request: u-boot-imx u-boot-imx-20210720 | expand |
On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote: > Hi Tom, > > please pull from u-boot-imx, thanks ! > > The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: > > Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 > -0400) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20210720 > > for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b: > > imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards > (N801x) (2021-07-19 23:30:47 +0200) > NAK: ERROR: fdt or initrd relocation disabled at boot time #2019: FILE: include/configs/kontron_common.h:67: + "fdt_high=0xffffffff\0" \ And this is likely a bad idea too: ERROR: fdt or initrd relocation disabled at boot time #2020: FILE: include/configs/kontron_common.h:68: + "initrd_high=0xffffffff\0" \ but I haven't looked at all of include/configs/kontron_common.h to make sure it follows all of the layout stuff documented for example in: https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32 (which is also true for aarch64 best I can tell from https://www.kernel.org/doc/Documentation/arm64/booting.rst). And since I'm noting things, checkpatch has a whole bunch of formatting issues throughout as well (kontron and generic imx8 code both).
Hi Tom, Stefano, On 20.07.21 19:45, Tom Rini wrote: > On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote: > >> Hi Tom, >> >> please pull from u-boot-imx, thanks ! >> >> The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: >> >> Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 >> -0400) >> >> are available in the Git repository at: >> >> https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git >> tags/u-boot-imx-20210720 >> >> for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b: >> >> imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards >> (N801x) (2021-07-19 23:30:47 +0200) >> > > NAK: > > ERROR: fdt or initrd relocation disabled at boot time > #2019: FILE: include/configs/kontron_common.h:67: > + "fdt_high=0xffffffff\0" \ > > And this is likely a bad idea too: > ERROR: fdt or initrd relocation disabled at boot time > #2020: FILE: include/configs/kontron_common.h:68: > + "initrd_high=0xffffffff\0" \ > > but I haven't looked at all of include/configs/kontron_common.h to make > sure it follows all of the layout stuff documented for example in: > https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32 > (which is also true for aarch64 best I can tell from > https://www.kernel.org/doc/Documentation/arm64/booting.rst). > > And since I'm noting things, checkpatch has a whole bunch of formatting > issues throughout as well (kontron and generic imx8 code both). Sorry for the mess! I have fixed these issues and just sent a v4 for the Kontron board support patches. Best regards Frieder
On 21.07.21 10:07, Frieder Schrempf wrote: > Hi Tom, Stefano, > > On 20.07.21 19:45, Tom Rini wrote: >> On Tue, Jul 20, 2021 at 05:17:59PM +0200, Stefano Babic wrote: >> >>> Hi Tom, >>> >>> please pull from u-boot-imx, thanks ! >>> >>> The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: >>> >>> Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 >>> -0400) >>> >>> are available in the Git repository at: >>> >>> https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git >>> tags/u-boot-imx-20210720 >>> >>> for you to fetch changes up to bd8e26606db62a0434c7f09adfa6ec666b36985b: >>> >>> imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards >>> (N801x) (2021-07-19 23:30:47 +0200) >>> >> >> NAK: >> >> ERROR: fdt or initrd relocation disabled at boot time >> #2019: FILE: include/configs/kontron_common.h:67: >> + "fdt_high=0xffffffff\0" \ >> >> And this is likely a bad idea too: >> ERROR: fdt or initrd relocation disabled at boot time >> #2020: FILE: include/configs/kontron_common.h:68: >> + "initrd_high=0xffffffff\0" \ >> >> but I haven't looked at all of include/configs/kontron_common.h to make >> sure it follows all of the layout stuff documented for example in: >> https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/ti_armv7_common.h#L32 >> (which is also true for aarch64 best I can tell from >> https://www.kernel.org/doc/Documentation/arm64/booting.rst). >> >> And since I'm noting things, checkpatch has a whole bunch of formatting >> issues throughout as well (kontron and generic imx8 code both). > > Sorry for the mess! I have fixed these issues and just sent a v4 for the Kontron board support patches. Thanks ! I have reverted (dropped) patches from u-boot-imx, we start again. Best regards, Stefano
Sorry for non-text top posting. The imx8ulp patch set has pin headers that would have lots warning, but we have agreement in Linux kernel that they are acceptable. Or you need we fix the line 100 warning? Are there others blocking the patch set? Thanks, Peng 获取 Outlook for iOS<https://aka.ms/o0ukef>
On Wed, Jul 21, 2021 at 10:23:12AM +0000, Peng Fan wrote: > Sorry for non-text top posting. > > The imx8ulp patch set has pin headers that would have lots warning, but we have agreement in Linux kernel that they are acceptable. Or you need we fix the line 100 warning? > > Are there others blocking the patch set? I saw at least a few "spaces before tabs" and similar errors. The best answer I can give here is to run checkpatch.pl in the tree and make sure there's nothing that's not just pin headers/long lines. But I do think I saw some about general coding style too.