Message ID | 20210709075355.27218-1-qiangqing.zhang@nxp.com |
---|---|
Headers | show |
Series | net: fec: add support for i.MX8MQ and i.MX8QM | expand |
Sorry for the noise, please ignore this version, I will resend it with "net-next" target. Best Regards, Joakim Zhang > -----Original Message----- > From: Joakim Zhang <qiangqing.zhang@nxp.com> > Sent: 2021年7月9日 15:54 > To: davem@davemloft.net; kuba@kernel.org; robh+dt@kernel.org; > andrew@lunn.ch > Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: [PATCH V1 0/5] net: fec: add support for i.MX8MQ and i.MX8QM > > This patch set adds supports for i.MX8MQ and i.MX8QM, both of them extend > new features. > > Fugang Duan (5): > dt-bindings: fec: add the missing clocks properties > dt-bindings: fec: add RGMII delayed clock property > net: fec: add imx8mq and imx8qm new versions support > net: fec: add eee mode tx lpi support > net: fec: add MAC internal delayed clock feature support > > .../devicetree/bindings/net/fsl-fec.txt | 15 ++ > drivers/net/ethernet/freescale/fec.h | 25 +++ > drivers/net/ethernet/freescale/fec_main.c | 145 ++++++++++++++++++ > 3 files changed, 185 insertions(+) > > -- > 2.17.1
On Fri, Jul 09, 2021 at 03:53:54PM +0800, Joakim Zhang wrote: > From: Fugang Duan <fugang.duan@nxp.com> > > The i.MX8MQ ENET version support IEEE802.3az eee mode, add > eee mode tx lpi enable to support ethtool interface. > > usage: > 1. set sleep and wake timer to 5ms: > ethtool --set-eee eth0 eee on tx-lpi on tx-timer 5000 > 2. check the eee mode: > ~# ethtool --show-eee eth0 > EEE Settings for eth0: > EEE status: enabled - active > Tx LPI: 5000 (us) > Supported EEE link modes: 100baseT/Full > 1000baseT/Full > Advertised EEE link modes: 100baseT/Full > 1000baseT/Full > Link partner advertised EEE link modes: 100baseT/Full > > Note: For realtime case and IEEE1588 ptp case, it should disable > EEE mode. > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> This patch results in: drivers/net/ethernet/freescale/fec_main.c: In function 'fec_enet_eee_mode_set': drivers/net/ethernet/freescale/fec_main.c:2801:40: error: 'FEC_LPI_SLEEP' undeclared drivers/net/ethernet/freescale/fec_main.c:2802:39: error: 'FEC_LPI_WAKE' undeclared when building m68k:m5272c3_defconfig. Guenter
Hi Guenter, > -----Original Message----- > From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck > Sent: 2021年8月9日 9:41 > To: Joakim Zhang <qiangqing.zhang@nxp.com> > Cc: davem@davemloft.net; kuba@kernel.org; robh+dt@kernel.org; > andrew@lunn.ch; netdev@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V1 4/5] net: fec: add eee mode tx lpi support > > On Fri, Jul 09, 2021 at 03:53:54PM +0800, Joakim Zhang wrote: > > From: Fugang Duan <fugang.duan@nxp.com> > > > > The i.MX8MQ ENET version support IEEE802.3az eee mode, add eee mode tx > > lpi enable to support ethtool interface. > > > > usage: > > 1. set sleep and wake timer to 5ms: > > ethtool --set-eee eth0 eee on tx-lpi on tx-timer 5000 2. check the eee > > mode: > > ~# ethtool --show-eee eth0 > > EEE Settings for eth0: > > EEE status: enabled - active > > Tx LPI: 5000 (us) > > Supported EEE link modes: 100baseT/Full > > 1000baseT/Full > > Advertised EEE link modes: 100baseT/Full > > 1000baseT/Full > > Link partner advertised EEE link modes: 100baseT/Full > > > > Note: For realtime case and IEEE1588 ptp case, it should disable EEE > > mode. > > > > Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > This patch results in: > > drivers/net/ethernet/freescale/fec_main.c: In function > 'fec_enet_eee_mode_set': > drivers/net/ethernet/freescale/fec_main.c:2801:40: error: 'FEC_LPI_SLEEP' > undeclared > drivers/net/ethernet/freescale/fec_main.c:2802:39: error: 'FEC_LPI_WAKE' > undeclared > > when building m68k:m5272c3_defconfig. I just sent to patch to fix this build issue, sorry for this inconvenience. Best Regards, Joakim Zhang > Guenter