diff mbox series

[1/4] cmd: usb_mass_storage: Use part_get_info_by_dev_and_name_or_num

Message ID 20210708171424.970928-1-sean.anderson@seco.com
State Superseded
Delegated to: Marek Vasut
Headers show
Series [1/4] cmd: usb_mass_storage: Use part_get_info_by_dev_and_name_or_num | expand

Commit Message

Sean Anderson July 8, 2021, 5:14 p.m. UTC 
This allows specifying partitions using more extended syntax. This is
particularly useful to access eMMC hardware partitions.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
This patch is independent of the others in this series and may be
applied separately.

 cmd/usb_mass_storage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Vasut July 8, 2021, 5:23 p.m. UTC | #1 
On 7/8/21 7:14 PM, Sean Anderson wrote:
> This allows specifying partitions using more extended syntax. This is
> particularly useful to access eMMC hardware partitions.

What kind of syntax ? That should be in the commit message.

If this is separate patch, it should not be part of a series, but separate.
Sean Anderson July 8, 2021, 5:26 p.m. UTC | #2 
Hi Marek,

On 7/8/21 1:23 PM, Marek Vasut wrote:
> On 7/8/21 7:14 PM, Sean Anderson wrote:
>> This allows specifying partitions using more extended syntax. This is
>> particularly useful to access eMMC hardware partitions.
> 
> What kind of syntax ? That should be in the commit message.

See https://u-boot.readthedocs.io/en/latest/usage/partitions.html

> If this is separate patch, it should not be part of a series, but separate.

Yes, it should.

--Sean
diff mbox series

Patch

diff --git a/cmd/usb_mass_storage.c b/cmd/usb_mass_storage.c
index 14fa7233c7..d4e619b842 100644
--- a/cmd/usb_mass_storage.c
+++ b/cmd/usb_mass_storage.c
@@ -74,8 +74,8 @@  static int ums_init(const char *devtype, const char *devnums_part_str)
 		if (!devnum_part_str)
 			break;
 
-		partnum = blk_get_device_part_str(devtype, devnum_part_str,
-					&block_dev, &info, 1);
+		partnum = part_get_info_by_dev_and_name_or_num(devtype, devnum_part_str,
+							       &block_dev, &info, 1);
 
 		if (partnum < 0)
 			goto cleanup;