mbox series

[SRU,Bionic,0/2] LP: #1933385 selftests: bpf: test_verifier fixes

Message ID 20210624001933.3106979-1-cascardo@canonical.com
Headers show
Series LP: #1933385 selftests: bpf: test_verifier fixes | expand

Message

Thadeu Lima de Souza Cascardo June 24, 2021, 12:19 a.m. UTC 
[Impact]
kselftest bpf ./test_verifier fails on bionic, preventing regression from being identified.

[Test case]
Run selftest bpf ./test_verifier and check that it passes.

[Potential regressions]
The test could still fail or crash the kernel.

Daniel Borkmann (2):
  bpf: Update selftests to reflect new error states
  bpf, selftests: Adjust few selftest result_unpriv outcomes

 tools/testing/selftests/bpf/test_verifier.c | 37 +++++++--------------
 1 file changed, 12 insertions(+), 25 deletions(-)

Comments

Stefan Bader June 24, 2021, 7:40 a.m. UTC | #1 
On 24.06.21 02:19, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> kselftest bpf ./test_verifier fails on bionic, preventing regression from being identified.
> 
> [Test case]
> Run selftest bpf ./test_verifier and check that it passes.
> 
> [Potential regressions]
> The test could still fail or crash the kernel.
> 
> Daniel Borkmann (2):
>    bpf: Update selftests to reflect new error states
>    bpf, selftests: Adjust few selftest result_unpriv outcomes
> 
>   tools/testing/selftests/bpf/test_verifier.c | 37 +++++++--------------
>   1 file changed, 12 insertions(+), 25 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza June 24, 2021, 8:47 a.m. UTC | #2 
On 24.06.21 02:19, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> kselftest bpf ./test_verifier fails on bionic, preventing regression from being identified.
> 
> [Test case]
> Run selftest bpf ./test_verifier and check that it passes.
> 
> [Potential regressions]
> The test could still fail or crash the kernel.
> 
> Daniel Borkmann (2):
>    bpf: Update selftests to reflect new error states
>    bpf, selftests: Adjust few selftest result_unpriv outcomes
> 
>   tools/testing/selftests/bpf/test_verifier.c | 37 +++++++--------------
>   1 file changed, 12 insertions(+), 25 deletions(-)
> 

These are very hard to review, trusting on yours and Kamal's
tests here :-).


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Stefan Bader June 24, 2021, 9:06 a.m. UTC | #3 
On 24.06.21 02:19, Thadeu Lima de Souza Cascardo wrote:
> [Impact]
> kselftest bpf ./test_verifier fails on bionic, preventing regression from being identified.
> 
> [Test case]
> Run selftest bpf ./test_verifier and check that it passes.
> 
> [Potential regressions]
> The test could still fail or crash the kernel.
> 
> Daniel Borkmann (2):
>    bpf: Update selftests to reflect new error states
>    bpf, selftests: Adjust few selftest result_unpriv outcomes
> 
>   tools/testing/selftests/bpf/test_verifier.c | 37 +++++++--------------
>   1 file changed, 12 insertions(+), 25 deletions(-)
> 
Applied to bionic:linux/master-prep. Thanks.

-Stefan