mbox series

[RESEND,0/6,SRU,G,H,Unstable] Add support for IO

Message ID 20210616055703.124039-1-acelan.kao@canonical.com
Headers show
Series Add support for IO | expand

Message

AceLan Kao June 16, 2021, 5:56 a.m. UTC 
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1929504

[Impact]
Require drivers to enable AAEON devices.

[Fix]
AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
https://www.spinics.net/lists/linux-gpio/msg61301.html

[Test]
Verified on AAEON platform.

[Where problems could occur]
No, they are new drivers, should not introduce any regressions.

Chia-Lin Kao (AceLan) (1):
  UBUNTU: ODM: [Config] update config for AAEON devices

Kunyang_Fan (5):
  UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
  UBUNTU: ODM: gpio: add driver for AAEON devices
  UBUNTU: ODM: watchdog: add driver for AAEON devices
  UBUNTU: ODM: hwmon: add driver for AAEON devices
  UBUNTU: ODM: leds: add driver for AAEON devices

 MAINTAINERS                               |  12 +
 debian.master/config/config.common.ubuntu |   5 +
 drivers/gpio/Kconfig                      |  12 +
 drivers/gpio/Makefile                     |   1 +
 drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
 drivers/hwmon/Kconfig                     |  12 +
 drivers/hwmon/Makefile                    |   1 +
 drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
 drivers/leds/Kconfig                      |  12 +
 drivers/leds/Makefile                     |   1 +
 drivers/leds/leds-aaeon.c                 | 142 ++++++
 drivers/mfd/Kconfig                       |  12 +
 drivers/mfd/Makefile                      |   1 +
 drivers/mfd/mfd-aaeon.c                   |  77 +++
 drivers/watchdog/Kconfig                  |  13 +
 drivers/watchdog/Makefile                 |   1 +
 drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
 17 files changed, 1317 insertions(+)
 create mode 100644 drivers/gpio/gpio-aaeon.c
 create mode 100644 drivers/hwmon/hwmon-aaeon.c
 create mode 100644 drivers/leds/leds-aaeon.c
 create mode 100644 drivers/mfd/mfd-aaeon.c
 create mode 100644 drivers/watchdog/wdt_aaeon.c

Comments

Tim Gardner June 16, 2021, 11:58 a.m. UTC | #1 
These patches look like they're on their way upstream, though I see 
several review comments. Have those been addressed ? Is there a git 
repository for these drivers ? Its going to be hard to maintain them 
without being able to follow source changes from the developers. Hirsute 
still has over a year left.

rtg

On 6/15/21 11:56 PM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  12 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  12 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  12 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  13 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1317 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
>
AceLan Kao June 17, 2021, 7:01 a.m. UTC | #2 
Tim Gardner <tim.gardner@canonical.com> 於 2021年6月16日 週三 下午7:59寫道：
>
> These patches look like they're on their way upstream, though I see
> several review comments. Have those been addressed ? Is there a git
> repository for these drivers ? Its going to be hard to maintain them
> without being able to follow source changes from the developers. Hirsute
> still has over a year left.
Those feedbacks are for coding style, not for the driver itself, and
they didn't submit v2 yet.
We're helping them to upstream their drivers, but it's not mandatory
for them to do that.
I don't think they will setup a git repo to host their drivers.

I'll keep working with them, if there is a new version of the driver
or patches, I'll submit them.
>
> rtg
>
> On 6/15/21 11:56 PM, AceLan Kao wrote:
> > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/1929504
> >
> > [Impact]
> > Require drivers to enable AAEON devices.
> >
> > [Fix]
> > AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> > https://www.spinics.net/lists/linux-gpio/msg61301.html
> >
> > [Test]
> > Verified on AAEON platform.
> >
> > [Where problems could occur]
> > No, they are new drivers, should not introduce any regressions.
> >
> > Chia-Lin Kao (AceLan) (1):
> >    UBUNTU: ODM: [Config] update config for AAEON devices
> >
> > Kunyang_Fan (5):
> >    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
> >    UBUNTU: ODM: gpio: add driver for AAEON devices
> >    UBUNTU: ODM: watchdog: add driver for AAEON devices
> >    UBUNTU: ODM: hwmon: add driver for AAEON devices
> >    UBUNTU: ODM: leds: add driver for AAEON devices
> >
> >   MAINTAINERS                               |  12 +
> >   debian.master/config/config.common.ubuntu |   5 +
> >   drivers/gpio/Kconfig                      |  12 +
> >   drivers/gpio/Makefile                     |   1 +
> >   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
> >   drivers/hwmon/Kconfig                     |  12 +
> >   drivers/hwmon/Makefile                    |   1 +
> >   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
> >   drivers/leds/Kconfig                      |  12 +
> >   drivers/leds/Makefile                     |   1 +
> >   drivers/leds/leds-aaeon.c                 | 142 ++++++
> >   drivers/mfd/Kconfig                       |  12 +
> >   drivers/mfd/Makefile                      |   1 +
> >   drivers/mfd/mfd-aaeon.c                   |  77 +++
> >   drivers/watchdog/Kconfig                  |  13 +
> >   drivers/watchdog/Makefile                 |   1 +
> >   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
> >   17 files changed, 1317 insertions(+)
> >   create mode 100644 drivers/gpio/gpio-aaeon.c
> >   create mode 100644 drivers/hwmon/hwmon-aaeon.c
> >   create mode 100644 drivers/leds/leds-aaeon.c
> >   create mode 100644 drivers/mfd/mfd-aaeon.c
> >   create mode 100644 drivers/watchdog/wdt_aaeon.c
> >
>
> --
> -----------
> Tim Gardner
> Canonical, Inc
Kleber Sacilotto de Souza June 18, 2021, 6:48 a.m. UTC | #3 
On 16.06.21 07:56, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks

> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  12 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  12 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  12 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  13 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1317 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
>
Stefan Bader June 18, 2021, 8:09 a.m. UTC | #4 
On 16.06.21 07:56, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  12 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  12 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  12 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  13 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1317 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Andrea Righi June 18, 2021, 9:19 a.m. UTC | #5 
On Wed, Jun 16, 2021 at 01:56:45PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>   UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>   UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>   UBUNTU: ODM: gpio: add driver for AAEON devices
>   UBUNTU: ODM: watchdog: add driver for AAEON devices
>   UBUNTU: ODM: hwmon: add driver for AAEON devices
>   UBUNTU: ODM: leds: add driver for AAEON devices
> 
>  MAINTAINERS                               |  12 +
>  debian.master/config/config.common.ubuntu |   5 +
>  drivers/gpio/Kconfig                      |  12 +
>  drivers/gpio/Makefile                     |   1 +
>  drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>  drivers/hwmon/Kconfig                     |  12 +
>  drivers/hwmon/Makefile                    |   1 +
>  drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>  drivers/leds/Kconfig                      |  12 +
>  drivers/leds/Makefile                     |   1 +
>  drivers/leds/leds-aaeon.c                 | 142 ++++++
>  drivers/mfd/Kconfig                       |  12 +
>  drivers/mfd/Makefile                      |   1 +
>  drivers/mfd/mfd-aaeon.c                   |  77 +++
>  drivers/watchdog/Kconfig                  |  13 +
>  drivers/watchdog/Makefile                 |   1 +
>  drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>  17 files changed, 1317 insertions(+)
>  create mode 100644 drivers/gpio/gpio-aaeon.c
>  create mode 100644 drivers/hwmon/hwmon-aaeon.c
>  create mode 100644 drivers/leds/leds-aaeon.c
>  create mode 100644 drivers/mfd/mfd-aaeon.c
>  create mode 100644 drivers/watchdog/wdt_aaeon.c

Applied to unstable/5.13.

Thanks,
-Andrea
Stefan Bader June 18, 2021, 9:44 a.m. UTC | #6 
On 16.06.21 07:56, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  12 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  12 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  12 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  13 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1317 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
> 
Applied to hirsute:linux. Thanks.

-Stefan
Stefan Bader June 18, 2021, 1:20 p.m. UTC | #7 
On 16.06.21 07:56, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its GPIO/LED/Watchdog/HWMON devices.
> https://www.spinics.net/lists/linux-gpio/msg61301.html
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: ODM: [Config] update config for AAEON devices
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  12 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  12 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  12 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  13 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1317 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
> 
Applied to groovy:linux. Thanks.

-Stefan