mbox series

[SRU,OEM-5.10,0/2] Replace AMD C-state quirk with upstream version

Message ID 20210524063318.1060189-1-kai.heng.feng@canonical.com
Headers show
Series Replace AMD C-state quirk with upstream version | expand

Message

Kai-Heng Feng May 24, 2021, 6:33 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1928694

[Impact]
Current AMD C-state quirk is hardcoded, replace it with a better
upstream version.

[Fix]
Sort the C-state latency value to ensure deeper C-state always has
larger value.

[Test]
Suspend the laptop. S2idle still works with the new patch.

[Where problems could occur]
This is specific to AMD s0ix platforms. The new fix is effectively the
same as the old one, so there's no actual behavioral change.

Kai-Heng Feng (1):
  Revert "UBUNTU: SAUCE: ACPI / idle: override and update c-state
    latency when not conformance with s0ix"

Mario Limonciello (1):
  ACPI: processor idle: Fix up C-state latency if not ordered

 drivers/acpi/processor_idle.c | 47 ++++++++++++++++++++++++++---------
 1 file changed, 35 insertions(+), 12 deletions(-)

Comments

Tim Gardner May 24, 2021, 5:18 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 5/24/21 12:33 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928694
> 
> [Impact]
> Current AMD C-state quirk is hardcoded, replace it with a better
> upstream version.
> 
> [Fix]
> Sort the C-state latency value to ensure deeper C-state always has
> larger value.
> 
> [Test]
> Suspend the laptop. S2idle still works with the new patch.
> 
> [Where problems could occur]
> This is specific to AMD s0ix platforms. The new fix is effectively the
> same as the old one, so there's no actual behavioral change.
> 
> Kai-Heng Feng (1):
>    Revert "UBUNTU: SAUCE: ACPI / idle: override and update c-state
>      latency when not conformance with s0ix"
> 
> Mario Limonciello (1):
>    ACPI: processor idle: Fix up C-state latency if not ordered
> 
>   drivers/acpi/processor_idle.c | 47 ++++++++++++++++++++++++++---------
>   1 file changed, 35 insertions(+), 12 deletions(-)
>
Timo Aaltonen June 3, 2021, 7:09 a.m. UTC | #2
On 24.5.2021 9.33, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928694
> 
> [Impact]
> Current AMD C-state quirk is hardcoded, replace it with a better
> upstream version.
> 
> [Fix]
> Sort the C-state latency value to ensure deeper C-state always has
> larger value.
> 
> [Test]
> Suspend the laptop. S2idle still works with the new patch.
> 
> [Where problems could occur]
> This is specific to AMD s0ix platforms. The new fix is effectively the
> same as the old one, so there's no actual behavioral change.
> 
> Kai-Heng Feng (1):
>    Revert "UBUNTU: SAUCE: ACPI / idle: override and update c-state
>      latency when not conformance with s0ix"
> 
> Mario Limonciello (1):
>    ACPI: processor idle: Fix up C-state latency if not ordered
> 
>   drivers/acpi/processor_idle.c | 47 ++++++++++++++++++++++++++---------
>   1 file changed, 35 insertions(+), 12 deletions(-)
>