diff mbox series

[SRU,F/raspi,G/raspi,H/raspi] UBUNTU: [Config] raspi: Set RTL8188EE=m

Message ID 20210518125643.79250-1-juergh@canonical.com
State New
Headers show
Series [SRU,F/raspi,G/raspi,H/raspi] UBUNTU: [Config] raspi: Set RTL8188EE=m | expand

Commit Message

Juerg Haefliger May 18, 2021, 12:56 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1928774

Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
 debian.raspi/config/config.common.ubuntu | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stefan Bader May 19, 2021, 7:18 a.m. UTC | #1
On 18.05.21 14:56, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928774
> 
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

You left the main task (Impish) as "new". Please either set it to "Invalid" or 
any state indicating whether it is needed or not there. I assume it is "Invalid" 
since impish:linux-raspi is a forward port of hirsute:linux-raspi right now.

-Stefan

>   debian.raspi/config/config.common.ubuntu | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
> index 9ccc0de03fa0..4cacea79ab80 100644
> --- a/debian.raspi/config/config.common.ubuntu
> +++ b/debian.raspi/config/config.common.ubuntu
> @@ -5811,7 +5811,7 @@ CONFIG_RTC_SYSTOHC_DEVICE="rtc0"
>   # CONFIG_RTL8180 is not set
>   CONFIG_RTL8187=m
>   CONFIG_RTL8187_LEDS=y
> -# CONFIG_RTL8188EE is not set
> +CONFIG_RTL8188EE=m
>   # CONFIG_RTL8192CE is not set
>   CONFIG_RTL8192CU=m
>   CONFIG_RTL8192C_COMMON=m
> @@ -5832,6 +5832,7 @@ CONFIG_RTLLIB_CRYPTO_TKIP=m
>   CONFIG_RTLLIB_CRYPTO_WEP=m
>   CONFIG_RTLWIFI=m
>   # CONFIG_RTLWIFI_DEBUG is not set
> +CONFIG_RTLWIFI_PCI=m
>   CONFIG_RTLWIFI_USB=m
>   CONFIG_RTL_CARDS=m
>   # CONFIG_RTS5208 is not set
>
Kleber Sacilotto de Souza May 19, 2021, 9:48 a.m. UTC | #2
On 18.05.21 14:56, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928774
> 
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks

> ---
>   debian.raspi/config/config.common.ubuntu | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
> index 9ccc0de03fa0..4cacea79ab80 100644
> --- a/debian.raspi/config/config.common.ubuntu
> +++ b/debian.raspi/config/config.common.ubuntu
> @@ -5811,7 +5811,7 @@ CONFIG_RTC_SYSTOHC_DEVICE="rtc0"
>   # CONFIG_RTL8180 is not set
>   CONFIG_RTL8187=m
>   CONFIG_RTL8187_LEDS=y
> -# CONFIG_RTL8188EE is not set
> +CONFIG_RTL8188EE=m
>   # CONFIG_RTL8192CE is not set
>   CONFIG_RTL8192CU=m
>   CONFIG_RTL8192C_COMMON=m
> @@ -5832,6 +5832,7 @@ CONFIG_RTLLIB_CRYPTO_TKIP=m
>   CONFIG_RTLLIB_CRYPTO_WEP=m
>   CONFIG_RTLWIFI=m
>   # CONFIG_RTLWIFI_DEBUG is not set
> +CONFIG_RTLWIFI_PCI=m
>   CONFIG_RTLWIFI_USB=m
>   CONFIG_RTL_CARDS=m
>   # CONFIG_RTS5208 is not set
>
Juerg Haefliger May 19, 2021, 10:35 a.m. UTC | #3
On Wed, 19 May 2021 09:18:50 +0200
Stefan Bader <stefan.bader@canonical.com> wrote:

> On 18.05.21 14:56, Juerg Haefliger wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1928774
> > 
> > Signed-off-by: Juerg Haefliger <juergh@canonical.com>  
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
> > ---  
> 
> You left the main task (Impish) as "new". Please either set it to "Invalid" or 
> any state indicating whether it is needed or not there. I assume it is "Invalid" 
> since impish:linux-raspi is a forward port of hirsute:linux-raspi right now.

Yes, done.

...Juerg

 
> -Stefan
> 
> >   debian.raspi/config/config.common.ubuntu | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
> > index 9ccc0de03fa0..4cacea79ab80 100644
> > --- a/debian.raspi/config/config.common.ubuntu
> > +++ b/debian.raspi/config/config.common.ubuntu
> > @@ -5811,7 +5811,7 @@ CONFIG_RTC_SYSTOHC_DEVICE="rtc0"
> >   # CONFIG_RTL8180 is not set
> >   CONFIG_RTL8187=m
> >   CONFIG_RTL8187_LEDS=y
> > -# CONFIG_RTL8188EE is not set
> > +CONFIG_RTL8188EE=m
> >   # CONFIG_RTL8192CE is not set
> >   CONFIG_RTL8192CU=m
> >   CONFIG_RTL8192C_COMMON=m
> > @@ -5832,6 +5832,7 @@ CONFIG_RTLLIB_CRYPTO_TKIP=m
> >   CONFIG_RTLLIB_CRYPTO_WEP=m
> >   CONFIG_RTLWIFI=m
> >   # CONFIG_RTLWIFI_DEBUG is not set
> > +CONFIG_RTLWIFI_PCI=m
> >   CONFIG_RTLWIFI_USB=m
> >   CONFIG_RTL_CARDS=m
> >   # CONFIG_RTS5208 is not set
> >   
> 
>
Kleber Sacilotto de Souza May 26, 2021, 1:45 p.m. UTC | #4
On 18.05.21 14:56, Juerg Haefliger wrote:
> BugLink: https://bugs.launchpad.net/bugs/1928774
> 
> Signed-off-by: Juerg Haefliger <juergh@canonical.com>
> ---
>   debian.raspi/config/config.common.ubuntu | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
> index 9ccc0de03fa0..4cacea79ab80 100644
> --- a/debian.raspi/config/config.common.ubuntu
> +++ b/debian.raspi/config/config.common.ubuntu
> @@ -5811,7 +5811,7 @@ CONFIG_RTC_SYSTOHC_DEVICE="rtc0"
>   # CONFIG_RTL8180 is not set
>   CONFIG_RTL8187=m
>   CONFIG_RTL8187_LEDS=y
> -# CONFIG_RTL8188EE is not set
> +CONFIG_RTL8188EE=m
>   # CONFIG_RTL8192CE is not set
>   CONFIG_RTL8192CU=m
>   CONFIG_RTL8192C_COMMON=m
> @@ -5832,6 +5832,7 @@ CONFIG_RTLLIB_CRYPTO_TKIP=m
>   CONFIG_RTLLIB_CRYPTO_WEP=m
>   CONFIG_RTLWIFI=m
>   # CONFIG_RTLWIFI_DEBUG is not set
> +CONFIG_RTLWIFI_PCI=m
>   CONFIG_RTLWIFI_USB=m
>   CONFIG_RTL_CARDS=m
>   # CONFIG_RTS5208 is not set
> 

Applied to [focal/groovy/hirsute]:linux-raspi.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu
index 9ccc0de03fa0..4cacea79ab80 100644
--- a/debian.raspi/config/config.common.ubuntu
+++ b/debian.raspi/config/config.common.ubuntu
@@ -5811,7 +5811,7 @@  CONFIG_RTC_SYSTOHC_DEVICE="rtc0"
 # CONFIG_RTL8180 is not set
 CONFIG_RTL8187=m
 CONFIG_RTL8187_LEDS=y
-# CONFIG_RTL8188EE is not set
+CONFIG_RTL8188EE=m
 # CONFIG_RTL8192CE is not set
 CONFIG_RTL8192CU=m
 CONFIG_RTL8192C_COMMON=m
@@ -5832,6 +5832,7 @@  CONFIG_RTLLIB_CRYPTO_TKIP=m
 CONFIG_RTLLIB_CRYPTO_WEP=m
 CONFIG_RTLWIFI=m
 # CONFIG_RTLWIFI_DEBUG is not set
+CONFIG_RTLWIFI_PCI=m
 CONFIG_RTLWIFI_USB=m
 CONFIG_RTL_CARDS=m
 # CONFIG_RTS5208 is not set