[v2,12/21] libcc1: use foreach

Message ID	20210428010119.806184-13-tom@tromey.com
State	New
Headers	show Return-Path: <gcc-patches-bounces@gcc.gnu.org> DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EB5139B8C39 From: Tom Tromey <tom@tromey.com> To: gcc-patches@gcc.gnu.org Subject: [PATCH v2 12/21] libcc1: use foreach Date: Tue, 27 Apr 2021 19:01:10 -0600 Message-Id: <20210428010119.806184-13-tom@tromey.com> In-Reply-To: <20210428010119.806184-1-tom@tromey.com> References: <20210428010119.806184-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: Tom Tromey <tom@tromey.com> Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces@gcc.gnu.org>
Series	C++11-based improvements for libcc1 \| expand [v2,00/21] C++11-based improvements for libcc1 [v2,01/21] libcc1: use templates to unmarshall enums [v2,02/21] libcc1: use "override" [v2,03/21] libcc1: inline some simple methods [v2,04/21] libcc1: delete copy constructor and assignment operators [v2,05/21] libcc1: use variadic templates for "call" [v2,06/21] libcc1: use variadic templates for "rpc" [v2,07/21] libcc1: use std::vector when building function types [v2,08/21] libcc1: add deleter objects [v2,09/21] libcc1: add more uses of 'deleter' [v2,10/21] libcc1: use unique_ptr more [v2,11/21] libcc1: unify compiler handling [v2,12/21] libcc1: use foreach [v2,13/21] libcc1: use static_assert [v2,14/21] libcc1: share basic context code [v2,15/21] libcc1: share GDB plugin code [v2,16/21] libcc1: use GCC_FE_VERSION_1 in C++ plugin [v2,17/21] libcc1: share the GCC interface code [v2,18/21] libcc1: fix a memory leak [v2,19/21] libcc1: use variadic templates for callbacks [v2,20/21] libcc1: avoid extra string copies [v2,21/21] libcc1: avoid a call to c_str

Message ID

20210428010119.806184-13-tom@tromey.com

State

New

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EB5139B8C39
From: Tom Tromey <tom@tromey.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH v2 12/21] libcc1: use foreach
Date: Tue, 27 Apr 2021 19:01:10 -0600
Message-Id: <20210428010119.806184-13-tom@tromey.com>
In-Reply-To: <20210428010119.806184-1-tom@tromey.com>
References: <20210428010119.806184-1-tom@tromey.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: Tom Tromey <tom@tromey.com>
Errors-To: gcc-patches-bounces@gcc.gnu.org
Sender: "Gcc-patches" <gcc-patches-bounces@gcc.gnu.org>

Series

C++11-based improvements for libcc1 | expand

Commit Message

Tom Tromey April 28, 2021, 1:01 a.m. UTC

This changes libcc1 to ues foreach in a couple of spots.

libcc1/ChangeLog
2021-04-27  Tom Tromey  <tom@tromey.com>

	* libcp1plugin.cc (plugin_context::mark): Use foreach.
	* libcc1plugin.cc (plugin_context::mark): Use foreach.
---
 libcc1/ChangeLog       |  5 +++++
 libcc1/libcc1plugin.cc | 13 +++++--------
 libcc1/libcp1plugin.cc | 13 +++++--------
 3 files changed, 15 insertions(+), 16 deletions(-)

Comments

Jeff Law April 28, 2021, 4:04 p.m. UTC | #1

On 4/27/2021 7:01 PM, Tom Tromey wrote:
> This changes libcc1 to ues foreach in a couple of spots.
>
> libcc1/ChangeLog
> 2021-04-27  Tom Tromey  <tom@tromey.com>
>
> 	* libcp1plugin.cc (plugin_context::mark): Use foreach.
> 	* libcc1plugin.cc (plugin_context::mark): Use foreach.

OK

jeff

diff --git a/libcc1/libcc1plugin.cc b/libcc1/libcc1plugin.cc
index 65e748258f40..2a75faba7652 100644
--- a/libcc1/libcc1plugin.cc
+++ b/libcc1/libcc1plugin.cc
@@ -235,17 +235,14 @@  plugin_context::plugin_context (int fd)
 void
 plugin_context::mark ()
 {
-  for (hash_table<decl_addr_hasher>::iterator it = address_map.begin ();
-       it != address_map.end ();
-       ++it)
+  for (const auto &item : address_map)
     {
-      ggc_mark ((*it)->decl);
-      ggc_mark ((*it)->address);
+      ggc_mark (item->decl);
+      ggc_mark (item->address);
     }
 
-  for (hash_table< nofree_ptr_hash<tree_node> >::iterator
-	 it = preserved.begin (); it != preserved.end (); ++it)
-    ggc_mark (&*it);
+  for (const auto &item : preserved)
+    ggc_mark (&item);
 }
 
 static void
diff --git a/libcc1/libcp1plugin.cc b/libcc1/libcp1plugin.cc
index 1fc8e269f075..3cbad5c6f021 100644
--- a/libcc1/libcp1plugin.cc
+++ b/libcc1/libcp1plugin.cc
@@ -225,17 +225,14 @@  plugin_context::plugin_context (int fd)
 void
 plugin_context::mark ()
 {
-  for (hash_table<decl_addr_hasher>::iterator it = address_map.begin ();
-       it != address_map.end ();
-       ++it)
+  for (const auto &item : address_map)
     {
-      ggc_mark ((*it)->decl);
-      ggc_mark ((*it)->address);
+      ggc_mark (item->decl);
+      ggc_mark (item->address);
     }
 
-  for (hash_table< nofree_ptr_hash<tree_node> >::iterator
-	 it = preserved.begin (); it != preserved.end (); ++it)
-    ggc_mark (&*it);
+  for (const auto &item : preserved)
+    ggc_mark (&item);
 }
 
 static void

[v2,12/21] libcc1: use foreach

Commit Message

Comments

Patch