| Message ID | 20210412164405.16890-1-matthew.weber@rockwellcollins.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/python-flup: update dependency to python3 | expand |
On Mon, 12 Apr 2021 11:44:05 -0500 Matt Weber <matthew.weber@rockwellcollins.com> wrote: > From: Jared Bents <jared.bents@rockwellcollins.com> > > Dependency incorrectly calls out python, should be python3 > > Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com> > Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > --- > package/python-flup/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/python-flup/Config.in b/package/python-flup/Config.in > index 2c21323515..f40f250163 100644 > --- a/package/python-flup/Config.in > +++ b/package/python-flup/Config.in > @@ -1,6 +1,6 @@ > config BR2_PACKAGE_PYTHON_FLUP > bool "python-flup" > - depends on BR2_PACKAGE_PYTHON > + depends on BR2_PACKAGE_PYTHON3 Do we know since when this is the case? This package was introduced in 2014 as version 1.0.3.dev-20110405, and back then the commit log said "Tested with ARM and Python 2.7.6". Then it was bumped to 1.0.3.dev20161029 by Adam in 2017, and again to 1.0.3 in 2019. Is it this latest update that brought the python3 requirement ? Thanks! Thomas
Thomas, On Mon, Apr 12, 2021 at 3:39 PM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Mon, 12 Apr 2021 11:44:05 -0500 > Matt Weber <matthew.weber@rockwellcollins.com> wrote: > > > From: Jared Bents <jared.bents@rockwellcollins.com> > > > > Dependency incorrectly calls out python, should be python3 > > > > Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com> > > Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com> > > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > > --- > > package/python-flup/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/python-flup/Config.in b/package/python-flup/Config.in > > index 2c21323515..f40f250163 100644 > > --- a/package/python-flup/Config.in > > +++ b/package/python-flup/Config.in > > @@ -1,6 +1,6 @@ > > config BR2_PACKAGE_PYTHON_FLUP > > bool "python-flup" > > - depends on BR2_PACKAGE_PYTHON > > + depends on BR2_PACKAGE_PYTHON3 > > Do we know since when this is the case? This package was introduced in > 2014 as version 1.0.3.dev-20110405, and back then the commit log said > "Tested with ARM and Python 2.7.6". Then it was bumped to > 1.0.3.dev20161029 by Adam in 2017, and again to 1.0.3 in 2019. Is it > this latest update that brought the python3 requirement ? Looking at the release notes (https://pypi.org/pypi/flup/json), I see the last py2 was "flup-1.0.3.dev_20110405-py2.7.egg" and then "flup-1.0.3.dev20151210-py3-none-any.whl" onward py3.5/3.6. So on the Buildroot side, it looks like this was a bug back in 2017 for the 1.0.3.dev20161029 bump (it required 3.5) and then the 1.0.3 bump required py3.6. Regards, Matt
On Mon, 12 Apr 2021 11:44:05 -0500 Matt Weber <matthew.weber@rockwellcollins.com> wrote: > From: Jared Bents <jared.bents@rockwellcollins.com> > > Dependency incorrectly calls out python, should be python3 > > Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com> > Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> > --- > package/python-flup/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied with an extended commit log, based on additional details provided by Matt. Thomas
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes: > From: Jared Bents <jared.bents@rockwellcollins.com> > Dependency incorrectly calls out python, should be python3 > Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com> > Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com> Committed to 2021.02.x, thanks.
diff --git a/package/python-flup/Config.in b/package/python-flup/Config.in index 2c21323515..f40f250163 100644 --- a/package/python-flup/Config.in +++ b/package/python-flup/Config.in @@ -1,6 +1,6 @@ config BR2_PACKAGE_PYTHON_FLUP bool "python-flup" - depends on BR2_PACKAGE_PYTHON + depends on BR2_PACKAGE_PYTHON3 help flup provides of a collection of WSGI modules for Python. It allows a webserver to use scgi-mod and fastcgi-mod