Message ID | CACPK8Xeet50bqWAY0jG_GRkgvKvFn94XtGDaq1gaVYVkyV_JUQ@mail.gmail.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] ARM: bmc: devicetree changes for 5.13, v2 | expand |
On Fri, Apr 16, 2021 at 5:27 AM Joel Stanley <joel@jms.id.au> wrote: > > Hello Soc maintainers, > > Here are some fixes for the changes that have already been merged for v5.13. > > I also merged some changes that came in later. If you would prefer to > not take them then I can send a pull with just the fixes. > > The following changes since commit f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: > > for you to fetch changes up to f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: Hi Joel, something about this pull request doesn't add up, and 'b4' refuses to pull it since the 'since commit f0145db2' and 'up to f0145db2' references refer to the same commit. I assume this is just a copy-paste error on your end, but it would be nice if you could double-check and resend the pull request based on the ee33e2fb3d70 commit that I merged. Arnd
On Mon, 19 Apr 2021 at 14:44, Arnd Bergmann <arnd@arndb.de> wrote: > > On Fri, Apr 16, 2021 at 5:27 AM Joel Stanley <joel@jms.id.au> wrote: > > > > Hello Soc maintainers, > > > > Here are some fixes for the changes that have already been merged for v5.13. > > > > I also merged some changes that came in later. If you would prefer to > > not take them then I can send a pull with just the fixes. > > > > The following changes since commit f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: > > > > for you to fetch changes up to f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: > > Hi Joel, > > something about this pull request doesn't add up, and 'b4' refuses > to pull it since the 'since commit f0145db2' and 'up to f0145db2' > references refer to the same commit. > > I assume this is just a copy-paste error on your end, but it would > be nice if you could double-check and resend the pull request > based on the ee33e2fb3d70 commit that I merged. Nice catch. It looks I've generated pull requests incorrectly from v5.5 onwards, and this is the first time we've noticed. My bash history shows I started generating them like this: git request-pull tag url tag v5.4 was the first time I'd sent a second PR for the same branch, so when it came to generating the next one ctrl+R'd myself into the wrong syntax and continued doing so ever since. I'll try sending this one again now. Cheers, Joel
On Tue, Apr 20, 2021 at 9:11 AM Joel Stanley <joel@jms.id.au> wrote: > > On Mon, 19 Apr 2021 at 14:44, Arnd Bergmann <arnd@arndb.de> wrote: > > > > On Fri, Apr 16, 2021 at 5:27 AM Joel Stanley <joel@jms.id.au> wrote: > > > > > > Hello Soc maintainers, > > > > > > Here are some fixes for the changes that have already been merged for v5.13. > > > > > > I also merged some changes that came in later. If you would prefer to > > > not take them then I can send a pull with just the fixes. > > > > > > The following changes since commit f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: > > > > > > for you to fetch changes up to f0145db24e65f6cf13347a90ffb86e5ef2ff2ca2: > > > > Hi Joel, > > > > something about this pull request doesn't add up, and 'b4' refuses > > to pull it since the 'since commit f0145db2' and 'up to f0145db2' > > references refer to the same commit. > > > > I assume this is just a copy-paste error on your end, but it would > > be nice if you could double-check and resend the pull request > > based on the ee33e2fb3d70 commit that I merged. > > Nice catch. It looks I've generated pull requests incorrectly from > v5.5 onwards, and this is the first time we've noticed. My bash > history shows I started generating them like this: > > git request-pull tag url tag Ah right. I'm surprised this resulted in the correct shortlog and diffstat, but that clearly explains it. > I'll try sending this one again now. I only started using b4 recently, so I wouldn't have caught it in the past, as I wasn't paying close attention to the commit hashes. I usually tried to ensure that the contents match up with the description, and that worked fine. I've had sporadic problems in the past with b4 and it's possible that I just papered over it with a manual merge thinking that I did something wrong instead of b4 pointing out an actual problem. Arnd