diff mbox

[U-Boot,11/26] microblaze: Support CTRL+C when tftp is running

Message ID 1315897821-23049-12-git-send-email-monstr@monstr.eu
State Rejected
Headers show

Commit Message

Michal Simek Sept. 13, 2011, 7:10 a.m. UTC 
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/lib/board.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Mike Frysinger Sept. 13, 2011, 5:33 p.m. UTC | #1 
On Tuesday, September 13, 2011 03:10:06 Michal Simek wrote:
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> ---
>  arch/microblaze/lib/board.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
> index d97543b..5510c12 100644
> --- a/arch/microblaze/lib/board.c
> +++ b/arch/microblaze/lib/board.c
> @@ -68,6 +68,7 @@ typedef int (init_fnc_t) (void);
>  init_fnc_t *init_sequence[] = {
>  	env_init,
>  	serial_init,
> +	console_init_f,
>  #ifdef CONFIG_SYS_GPIO_0
>  	gpio_init,
>  #endif

the summary/changelog is still confusing here.  what i'd use is:
microblaze: call common console_init_f initialization function

All arches are supposed to call the common console_init_f func when setting 
things up.  If we don't, code like tftp and netconsole don't operate 
correctly.
-mike
Mike Frysinger Sept. 13, 2011, 5:37 p.m. UTC | #2 
On Tuesday, September 13, 2011 13:33:57 Mike Frysinger wrote:
> the summary/changelog is still confusing here

sorry, i was thinking of "microblaze: Initialize jumptable and console".  but 
my suggestion mostly still stands.
-mike
Michal Simek Sept. 14, 2011, 6:51 a.m. UTC | #3 
Mike Frysinger wrote:
> On Tuesday, September 13, 2011 03:10:06 Michal Simek wrote:
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>>  arch/microblaze/lib/board.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
>> index d97543b..5510c12 100644
>> --- a/arch/microblaze/lib/board.c
>> +++ b/arch/microblaze/lib/board.c
>> @@ -68,6 +68,7 @@ typedef int (init_fnc_t) (void);
>>  init_fnc_t *init_sequence[] = {
>>  	env_init,
>>  	serial_init,
>> +	console_init_f,
>>  #ifdef CONFIG_SYS_GPIO_0
>>  	gpio_init,
>>  #endif
> 
> the summary/changelog is still confusing here.  what i'd use is:
> microblaze: call common console_init_f initialization function

Fixed

Thanks,
Michal
diff mbox

Patch

diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
index d97543b..5510c12 100644
--- a/arch/microblaze/lib/board.c
+++ b/arch/microblaze/lib/board.c
@@ -68,6 +68,7 @@  typedef int (init_fnc_t) (void);
 init_fnc_t *init_sequence[] = {
 	env_init,
 	serial_init,
+	console_init_f,
 #ifdef CONFIG_SYS_GPIO_0
 	gpio_init,
 #endif