mbox series

[SRU,xenial/hwe,v2,0/1] Fix boot failure on ppc64el (LP: #1922997)

Message ID 20210409094247.2129234-1-kleber.souza@canonical.com
Headers show
Series Fix boot failure on ppc64el (LP: #1922997) | expand

Message

Kleber Sacilotto de Souza April 9, 2021, 9:42 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1922997

[Impact]
Enabling CONFIG_MODVERSIONS on xenial/linux-hwe (via rebase on bionic/linux, see
bug 1898716) is causing the kernel to fail booting on ppc64el as the modules
can't be loaded because of the mismatch of the module_layout symbol.

[ 7.635173] raid0: disagrees about version of symbol module_layout

[Fix]
The proposed fix is to disable CONFIG_MODVERSIONS and unset
CONFIG_SYSTEM_TRUSTED_KEYS via the 'local-mangle' script which gets called by
the 'open' script after the rebase. Making the changes directly on the config or
annotations file is not persistent as these files are synced from master.

This is a temporary fix until the root cause can be found.

[Test case]
Boot the kernel on a xenial ppc64el system.

[Regression potential]
This config option has been enabled on Bionic to support rebuilding the lrm
modules without the need to rebuild the kernel. There are no lrm modules in
Xenial, so it should be safe to keep it disabled.

Kleber Sacilotto de Souza (1):
  UBUNTU: [Packaging] HWE: disable CONFIG_MODVERSIONS

 debian.hwe/scripts/helpers/local-mangle | 9 +++++++++
 1 file changed, 9 insertions(+)

---
v2:
  - Also unset CONFIG_SYSTEM_TRUSTED_KEYS
  - Rework the sed regex'es to be less prolix and more robust

Comments

Tim Gardner April 9, 2021, 12:01 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 4/9/21 3:42 AM, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922997
> 
> [Impact]
> Enabling CONFIG_MODVERSIONS on xenial/linux-hwe (via rebase on bionic/linux, see
> bug 1898716) is causing the kernel to fail booting on ppc64el as the modules
> can't be loaded because of the mismatch of the module_layout symbol.
> 
> [ 7.635173] raid0: disagrees about version of symbol module_layout
> 
> [Fix]
> The proposed fix is to disable CONFIG_MODVERSIONS and unset
> CONFIG_SYSTEM_TRUSTED_KEYS via the 'local-mangle' script which gets called by
> the 'open' script after the rebase. Making the changes directly on the config or
> annotations file is not persistent as these files are synced from master.
> 
> This is a temporary fix until the root cause can be found.
> 
> [Test case]
> Boot the kernel on a xenial ppc64el system.
> 
> [Regression potential]
> This config option has been enabled on Bionic to support rebuilding the lrm
> modules without the need to rebuild the kernel. There are no lrm modules in
> Xenial, so it should be safe to keep it disabled.
> 
> Kleber Sacilotto de Souza (1):
>    UBUNTU: [Packaging] HWE: disable CONFIG_MODVERSIONS
> 
>   debian.hwe/scripts/helpers/local-mangle | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> ---
> v2:
>    - Also unset CONFIG_SYSTEM_TRUSTED_KEYS
>    - Rework the sed regex'es to be less prolix and more robust
>
Kleber Sacilotto de Souza April 9, 2021, 12:37 p.m. UTC | #2
On 09.04.21 11:42, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922997
> 
> [Impact]
> Enabling CONFIG_MODVERSIONS on xenial/linux-hwe (via rebase on bionic/linux, see
> bug 1898716) is causing the kernel to fail booting on ppc64el as the modules
> can't be loaded because of the mismatch of the module_layout symbol.
> 
> [ 7.635173] raid0: disagrees about version of symbol module_layout
> 
> [Fix]
> The proposed fix is to disable CONFIG_MODVERSIONS and unset
> CONFIG_SYSTEM_TRUSTED_KEYS via the 'local-mangle' script which gets called by
> the 'open' script after the rebase. Making the changes directly on the config or
> annotations file is not persistent as these files are synced from master.
> 
> This is a temporary fix until the root cause can be found.
> 
> [Test case]
> Boot the kernel on a xenial ppc64el system.
> 
> [Regression potential]
> This config option has been enabled on Bionic to support rebuilding the lrm
> modules without the need to rebuild the kernel. There are no lrm modules in
> Xenial, so it should be safe to keep it disabled.
> 
> Kleber Sacilotto de Souza (1):
>    UBUNTU: [Packaging] HWE: disable CONFIG_MODVERSIONS
> 
>   debian.hwe/scripts/helpers/local-mangle | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> ---
> v2:
>    - Also unset CONFIG_SYSTEM_TRUSTED_KEYS
>    - Rework the sed regex'es to be less prolix and more robust
> 

Applied to xenial/linux-hwe.

Thanks,
Kleber