Message ID | 20210407045038.1436843-1-dqfext@gmail.com |
---|---|
Headers | show |
Series | MT7530 interrupt support | expand |
On Wed, Apr 07, 2021 at 12:50:35PM +0800, DENG Qingfang wrote: > Add support for MediaTek PHYs found in MT7530 and MT7531 switches. > The initialization procedure is from the vendor driver, but due to lack > of documentation, the function of some register values remains unknown. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Wed, Apr 07, 2021 at 12:50:36PM +0800, DENG Qingfang wrote: > Add support for MT7530 interrupt controller to handle internal PHYs. > In order to assign an IRQ number to each PHY, the registration of MDIO bus > is also done in this driver. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> > --- > RFC v1 -> RFC v2: > - Split MDIO and IRQ setup function Thanks for the split. It looks good. > +/* Forward declaration */ > +struct mt7530_priv; > +static int mt753x_phy_read(struct mii_bus *, int, int); > +static int mt753x_phy_write(struct mii_bus *, int, int, u16); It is better to move the functions to before mt7530_setup_mdio(). Andrew
On Wed, Apr 07, 2021 at 12:50:38PM +0800, DENG Qingfang wrote: > Enable MT7530 interrupt controller in the MT7621 SoC. > > Signed-off-by: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew