diff mbox series

spi: xilinx_spi: Trivial fixes in axi qspi driver

Message ID 27a58e9e05426a647289c45e75a220534b47f9e5.1615969054.git.michal.simek@xilinx.com
State Accepted
Commit d999a7b7b687a138453f11e30401c0e41085612e
Delegated to: Michal Simek
Headers show
Series spi: xilinx_spi: Trivial fixes in axi qspi driver | expand

Commit Message

Michal Simek March 17, 2021, 8:17 a.m. UTC 
From: T Karthik Reddy <t.karthik.reddy@xilinx.com>

Use __func__ instead for function name in debug.
Use Linux style u32 instead of uint32_t.

Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
Acked-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/spi/xilinx_spi.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Michal Simek March 30, 2021, 7:25 a.m. UTC | #1 
st 17. 3. 2021 v 9:17 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> From: T Karthik Reddy <t.karthik.reddy@xilinx.com>
>
> Use __func__ instead for function name in debug.
> Use Linux style u32 instead of uint32_t.
>
> Signed-off-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Acked-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/spi/xilinx_spi.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
> index 0274afdc6e0d..b892cdae9bab 100644
> --- a/drivers/spi/xilinx_spi.c
> +++ b/drivers/spi/xilinx_spi.c
> @@ -314,8 +314,7 @@ static int xilinx_spi_set_speed(struct udevice *bus, uint speed)
>
>         priv->freq = speed;
>
> -       debug("xilinx_spi_set_speed: regs=%p, speed=%d\n", priv->regs,
> -             priv->freq);
> +       debug("%s: regs=%p, speed=%d\n", __func__, priv->regs, priv->freq);
>
>         return 0;
>  }
> @@ -324,7 +323,7 @@ static int xilinx_spi_set_mode(struct udevice *bus, uint mode)
>  {
>         struct xilinx_spi_priv *priv = dev_get_priv(bus);
>         struct xilinx_spi_regs *regs = priv->regs;
> -       uint32_t spicr;
> +       u32 spicr;
>
>         spicr = readl(&regs->spicr);
>         if (mode & SPI_LSB_FIRST)
> @@ -339,8 +338,7 @@ static int xilinx_spi_set_mode(struct udevice *bus, uint mode)
>         writel(spicr, &regs->spicr);
>         priv->mode = mode;
>
> -       debug("xilinx_spi_set_mode: regs=%p, mode=%d\n", priv->regs,
> -             priv->mode);
> +       debug("%s: regs=%p, mode=%d\n", __func__, priv->regs, priv->mode);
>
>         return 0;
>  }
> --
> 2.30.1
>

Applied.
M
diff mbox series

Patch

diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
index 0274afdc6e0d..b892cdae9bab 100644
--- a/drivers/spi/xilinx_spi.c
+++ b/drivers/spi/xilinx_spi.c
@@ -314,8 +314,7 @@  static int xilinx_spi_set_speed(struct udevice *bus, uint speed)
 
 	priv->freq = speed;
 
-	debug("xilinx_spi_set_speed: regs=%p, speed=%d\n", priv->regs,
-	      priv->freq);
+	debug("%s: regs=%p, speed=%d\n", __func__, priv->regs, priv->freq);
 
 	return 0;
 }
@@ -324,7 +323,7 @@  static int xilinx_spi_set_mode(struct udevice *bus, uint mode)
 {
 	struct xilinx_spi_priv *priv = dev_get_priv(bus);
 	struct xilinx_spi_regs *regs = priv->regs;
-	uint32_t spicr;
+	u32 spicr;
 
 	spicr = readl(&regs->spicr);
 	if (mode & SPI_LSB_FIRST)
@@ -339,8 +338,7 @@  static int xilinx_spi_set_mode(struct udevice *bus, uint mode)
 	writel(spicr, &regs->spicr);
 	priv->mode = mode;
 
-	debug("xilinx_spi_set_mode: regs=%p, mode=%d\n", priv->regs,
-	      priv->mode);
+	debug("%s: regs=%p, mode=%d\n", __func__, priv->regs, priv->mode);
 
 	return 0;
 }