| Message ID | 20210325125442.17709-2-heiko.thiery@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] package/network-manager: add CPE variables | expand |
On Thu, 25 Mar 2021 13:54:44 +0100 Heiko Thiery <heiko.thiery@gmail.com> wrote: > cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this > package: > > https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/network-manager-openvpn/network-manager-openvpn.mk b/package/network-manager-openvpn/network-manager-openvpn.mk > index 1a872dc127..d861ac65ae 100644 > --- a/package/network-manager-openvpn/network-manager-openvpn.mk > +++ b/package/network-manager-openvpn/network-manager-openvpn.mk > @@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager > NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn > NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+ > NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING > +NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome > +NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc Are you sure this is correct ? NetworkManager-vpnc is for Cisco client, not for OpenVPN clients. See https://gitlab.gnome.org/GNOME/NetworkManager-vpnc vs https://gitlab.gnome.org/GNOME/NetworkManager-openvpn. Thomas
Hi Thomas, Am So., 28. März 2021 um 21:21 Uhr schrieb Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > > On Thu, 25 Mar 2021 13:54:44 +0100 > Heiko Thiery <heiko.thiery@gmail.com> wrote: > > > cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this > > package: > > > > https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > --- > > package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/package/network-manager-openvpn/network-manager-openvpn.mk b/package/network-manager-openvpn/network-manager-openvpn.mk > > index 1a872dc127..d861ac65ae 100644 > > --- a/package/network-manager-openvpn/network-manager-openvpn.mk > > +++ b/package/network-manager-openvpn/network-manager-openvpn.mk > > @@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager > > NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn > > NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+ > > NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING > > +NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome > > +NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc > > Are you sure this is correct ? NetworkManager-vpnc is for Cisco client, > not for OpenVPN clients. See > https://gitlab.gnome.org/GNOME/NetworkManager-vpnc vs > https://gitlab.gnome.org/GNOME/NetworkManager-openvpn. You are absolutely right. This was my fault. Please ignore this patch and sorry for the noise.
diff --git a/package/network-manager-openvpn/network-manager-openvpn.mk b/package/network-manager-openvpn/network-manager-openvpn.mk index 1a872dc127..d861ac65ae 100644 --- a/package/network-manager-openvpn/network-manager-openvpn.mk +++ b/package/network-manager-openvpn/network-manager-openvpn.mk @@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+ NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING +NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome +NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc NETWORK_MANAGER_OPENVPN_CONF_OPTS = \ --without-gnome
cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this package: https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++ 1 file changed, 2 insertions(+)