| Message ID | 20210326195003.3756394-1-robh@kernel.org |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes | expand |
On Fri, Mar 26, 2021 at 01:50:03PM -0600, Rob Herring wrote: > The nvidia,tegra210-ahub binding is missing schema for child nodes. This > results in warnings if 'additionalProperties: false' is set (or when the > tools implement 'unevaluatedProperties' support). Add the child nodes > and reference their schema if one exists. > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Sameer Pujar <spujar@nvidia.com> > Cc: alsa-devel@alsa-project.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - Also add 'dspk' child node > > This patch ideally should be applied before this series[1]. > > [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/ > --- > .../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Acked-by: Thierry Reding <treding@nvidia.com>
On 3/27/2021 1:20 AM, Rob Herring wrote: > The nvidia,tegra210-ahub binding is missing schema for child nodes. This > results in warnings if 'additionalProperties: false' is set (or when the > tools implement 'unevaluatedProperties' support). Add the child nodes > and reference their schema if one exists. > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Sameer Pujar <spujar@nvidia.com> > Cc: alsa-devel@alsa-project.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - Also add 'dspk' child node > > This patch ideally should be applied before this series[1]. > > [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/ > --- > .../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Acked-by: Sameer Pujar <spujar@nvidia.com>
On Fri, Mar 26, 2021 at 01:50:03PM -0600, Rob Herring wrote: > The nvidia,tegra210-ahub binding is missing schema for child nodes. This > results in warnings if 'additionalProperties: false' is set (or when the > tools implement 'unevaluatedProperties' support). Add the child nodes > and reference their schema if one exists. This doesn't apply against current code, please check and resend: Applying: ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes error: sha1 information is lacking or useless (Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml). error: could not build fake ancestor Patch failed at 0001 ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
On Fri, 26 Mar 2021 13:50:03 -0600, Rob Herring wrote: > The nvidia,tegra210-ahub binding is missing schema for child nodes. This > results in warnings if 'additionalProperties: false' is set (or when the > tools implement 'unevaluatedProperties' support). Add the child nodes > and reference their schema if one exists. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes commit: 8b01a0d0b5c1327296b37a13c37ca7ab31841577 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml index e568d6c7dddd..1118a9488345 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml @@ -69,6 +69,22 @@ properties: $ref: audio-graph-port.yaml# unevaluatedProperties: false +patternProperties: + '^i2s@[0-9a-f]+$': + type: object + + '^dmic@[0-9a-f]+$': + type: object + $ref: nvidia,tegra210-dmic.yaml# + + '^admaif@[0-9a-f]+$': + type: object + $ref: nvidia,tegra210-admaif.yaml# + + '^dspk@[0-9a-f]+$': + type: object + $ref: nvidia,tegra186-dspk.yaml# + required: - compatible - reg
The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists. Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Sameer Pujar <spujar@nvidia.com> Cc: alsa-devel@alsa-project.org Cc: linux-tegra@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - Also add 'dspk' child node This patch ideally should be applied before this series[1]. [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@kernel.org/ --- .../bindings/sound/nvidia,tegra210-ahub.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)