mbox series

[Hirsute,0/1] fix Tegra mmc0 timeout

Message ID 20210324160446.2950-1-kamal@canonical.com
Headers show
Series fix Tegra mmc0 timeout | expand

Message

Kamal Mostafa March 24, 2021, 4:04 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1921140

Fix intermittent "mmc0: Timeout" hang on NVIDIA Jetson AGX Xavier (and
maybe other Tegra platforms).

This patch from NVIDIA fixes the forced-replication method of inducing
the timeout and appears to likewise fix the intermittent occurrence of
it.  The patch will be heading upstream in short order, per the author.

Affects only the Tegra mmc driver.

 -Kamal

---

anrao (1):
  UBUNTU: SAUCE: mmc: host: Add required callbacks to set/clear CQE_EN
    bit

 drivers/mmc/host/sdhci-tegra.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Colin Ian King March 24, 2021, 4:10 p.m. UTC | #1
On 24/03/2021 16:04, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921140
> 
> Fix intermittent "mmc0: Timeout" hang on NVIDIA Jetson AGX Xavier (and
> maybe other Tegra platforms).
> 
> This patch from NVIDIA fixes the forced-replication method of inducing
> the timeout and appears to likewise fix the intermittent occurrence of
> it.  The patch will be heading upstream in short order, per the author.
> 
> Affects only the Tegra mmc driver.
> 
>  -Kamal
> 
> ---
> 
> anrao (1):
>   UBUNTU: SAUCE: mmc: host: Add required callbacks to set/clear CQE_EN
>     bit
> 
>  drivers/mmc/host/sdhci-tegra.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 

I'm assuming the fix works and has been tested by NVIDIA, so..

Acked-by: Colin Ian King <colin.king@canonical.com>
Kamal Mostafa March 24, 2021, 4:12 p.m. UTC | #2
On Wed, Mar 24, 2021 at 9:10 AM Colin Ian King <colin.king@canonical.com>
wrote:

>
> I'm assuming the fix works and has been tested by NVIDIA, so..
>


... Yes, and has been tested by myself too.

 -Kamal



> Acked-by: Colin Ian King <colin.king@canonical.com>
>
Colin Ian King March 24, 2021, 4:19 p.m. UTC | #3
On 24/03/2021 16:12, Kamal Mostafa wrote:
> 
> On Wed, Mar 24, 2021 at 9:10 AM Colin Ian King <colin.king@canonical.com
> <mailto:colin.king@canonical.com>> wrote:
> 
> 
>     I'm assuming the fix works and has been tested by NVIDIA, so..
> 
> 
> 
> ... Yes, and has been tested by myself too.
> 
>  -Kamal
> 

Doubly good! Thanks.

>  
> 
>     Acked-by: Colin Ian King <colin.king@canonical.com
>     <mailto:colin.king@canonical.com>>
> 
>
Andrea Righi March 29, 2021, 1:19 p.m. UTC | #4
On Wed, Mar 24, 2021 at 09:04:45AM -0700, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921140
> 
> Fix intermittent "mmc0: Timeout" hang on NVIDIA Jetson AGX Xavier (and
> maybe other Tegra platforms).
> 
> This patch from NVIDIA fixes the forced-replication method of inducing
> the timeout and appears to likewise fix the intermittent occurrence of
> it.  The patch will be heading upstream in short order, per the author.
> 
> Affects only the Tegra mmc driver.
> 
>  -Kamal
> 
> ---
> 
> anrao (1):
>   UBUNTU: SAUCE: mmc: host: Add required callbacks to set/clear CQE_EN
>     bit

Fixed author name (as mentioned by Krzysztof) and applied to
hirsute/5.11.

Thanks,
-Andrea
Seth Forshee April 5, 2021, 7:16 p.m. UTC | #5
On Wed, Mar 24, 2021 at 09:04:45AM -0700, Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921140
> 
> Fix intermittent "mmc0: Timeout" hang on NVIDIA Jetson AGX Xavier (and
> maybe other Tegra platforms).
> 
> This patch from NVIDIA fixes the forced-replication method of inducing
> the timeout and appears to likewise fix the intermittent occurrence of
> it.  The patch will be heading upstream in short order, per the author.
> 
> Affects only the Tegra mmc driver.
> 
>  -Kamal

Applied to unstable/master, thanks!