| Message ID | 1315520711-9667-1-git-send-email-sjg@chromium.org |
|---|---|
| State | New, archived |
| Headers | show |
Dear Simon Glass, In message <1315520711-9667-1-git-send-email-sjg@chromium.org> you wrote: > Large-value clock speeds are error-prone, so we add a new file which defines > these in a standard manner across ARM U-Boot code. > > Any interest in having something like this in include/clocks.h? Sorry, but I dislike defines like thess because they actually obfuscate the code. > + * Please order the items by increasing Hz > + */ > +enum { > + CLK_32768 = 32768, > + CLK_20M = 20000000, > + CLK_24M = 24000000, > + CLK_144M = 144000000, > + CLK_216M = 216000000, > + CLK_300M = 300000000, > +}; NAK. I don't want to see anything like that. [And I would welcome patches to get rid of this SZ_* mess.] Best regards, Wolfgang Denk
Hi Wolfgang, On Thu, Sep 8, 2011 at 3:34 PM, Wolfgang Denk <wd@denx.de> wrote: > Dear Simon Glass, > > In message <1315520711-9667-1-git-send-email-sjg@chromium.org> you wrote: >> Large-value clock speeds are error-prone, so we add a new file which defines >> these in a standard manner across ARM U-Boot code. >> >> Any interest in having something like this in include/clocks.h? > > Sorry, but I dislike defines like thess because they actually > obfuscate the code. Oh, ok. > >> + * Please order the items by increasing Hz >> + */ >> +enum { >> + CLK_32768 = 32768, >> + CLK_20M = 20000000, >> + CLK_24M = 24000000, >> + CLK_144M = 144000000, >> + CLK_216M = 216000000, >> + CLK_300M = 300000000, >> +}; > > NAK. I don't want to see anything like that. [And I would welcome > patches to get rid of this SZ_* mess.] [Do you mean arch/arm/include/asm/sizes.h?] Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de > Backed up the system lately? >
Dear Simon Glass, In message <CAPnjgZ27gio_tmZ1CoFW_QB1FStbO=JsYJGhXFezf3f5v=0KqQ@mail.gmail.com> you wrote: > > > NAK. I don't want to see anything like that. [And I would welcome > > patches to get rid of this SZ_* mess.] > > [Do you mean arch/arm/include/asm/sizes.h?] Yes, exactly. Best regards, Wolfgang Denk
diff --git a/arch/arm/include/asm/clocks.h b/arch/arm/include/asm/clocks.h new file mode 100644 index 0000000..58cf838 --- /dev/null +++ b/arch/arm/include/asm/clocks.h @@ -0,0 +1,43 @@ +/* + * Copyright (c) 2011 The Chromium OS Authors. + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +/* Standard clock speeds */ + +/* + * We define some commonly-used clock speeds to avoid error since long + * numbers are hard to read. + * + * The format of the label is + * CLK_x_yU where: + * x is the integer speed + * y is the fractional part which can be omitted if 0 + * U is the units (blank for Hz, K or M for KHz and MHz) + * + * Please order the items by increasing Hz + */ +enum { + CLK_32768 = 32768, + CLK_20M = 20000000, + CLK_24M = 24000000, + CLK_144M = 144000000, + CLK_216M = 216000000, + CLK_300M = 300000000, +};