| Message ID | 20210318045706.200458-2-hch@lst.de |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] alpha: use libata instead of the legacy ide driver | expand |
On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote:
> Switch the alpha defconfig from the legacy ide driver to libata.
Umm... I don't have an IDE alpha box in a usable shape (fans on
CPU module shat themselves), and it would take a while to resurrect
it, but I remember the joy it used to cause in some versions.
Do you have reports of libata variants of drivers actually tested on
those?
On Thu, Mar 18, 2021 at 05:54:55AM +0000, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > > Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU module shat themselves), and it would take a while to resurrect > it, but I remember the joy it used to cause in some versions. > > Do you have reports of libata variants of drivers actually tested on > those? No, I haven't. The whole point is that we're not going to keep 40000 lines of code around despite notice for users that don't exist or care. If there is a regression we'll fix it, but we're not going to make life miserable just because we can.
Hi Al! On 3/18/21 6:54 AM, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU module shat themselves), and it would take a while to resurrect > it, but I remember the joy it used to cause in some versions. > > Do you have reports of libata variants of drivers actually tested on > those? At least pata_cypress works fine on my AlphaStation XP1000: root@tsunami:~> lspci 0000:00:07.0 ISA bridge: Contaq Microsystems 82c693 0000:00:07.1 IDE interface: Contaq Microsystems 82c693 0000:00:07.2 IDE interface: Contaq Microsystems 82c693 0000:00:07.3 USB controller: Contaq Microsystems 82c693 0000:00:0d.0 VGA compatible controller: Texas Instruments TVP4020 [Permedia 2] (rev 01) 0001:01:03.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 41) 0001:01:06.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 06) 0001:01:08.0 PCI bridge: Digital Equipment Corporation DECchip 21152 (rev 03) 0001:02:09.0 Ethernet controller: Intel Corporation 82541PI Gigabit Ethernet Controller (rev 05) root@tsunami:~> lsmod|grep pata pata_cypress 3595 3 libata 235071 2 ata_generic,pata_cypress root@tsunami:~> I also have two AlphaStation 233 currently in storage which I assume use different IDE chipset which I could test as well. Adrian
Christoph Hellwig <hch@lst.de> writes: > On Thu, Mar 18, 2021 at 05:54:55AM +0000, Al Viro wrote: >> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> > Switch the alpha defconfig from the legacy ide driver to libata. >> >> Umm... I don't have an IDE alpha box in a usable shape (fans on >> CPU module shat themselves), and it would take a while to resurrect >> it, but I remember the joy it used to cause in some versions. >> >> Do you have reports of libata variants of drivers actually tested on >> those? > > No, I haven't. The whole point is that we're not going to keep 40000 > lines of code around despite notice for users that don't exist or > care. If there is a regression we'll fix it, but we're not going to > make life miserable just because we can. The pata_ali driver works fine on my UP1500 machine, unless something broke recently. I'll build the latest kernel and report back.
Måns Rullgård <mans@mansr.com> writes: > Christoph Hellwig <hch@lst.de> writes: > >> On Thu, Mar 18, 2021 at 05:54:55AM +0000, Al Viro wrote: >>> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >>> > Switch the alpha defconfig from the legacy ide driver to libata. >>> >>> Umm... I don't have an IDE alpha box in a usable shape (fans on >>> CPU module shat themselves), and it would take a while to resurrect >>> it, but I remember the joy it used to cause in some versions. >>> >>> Do you have reports of libata variants of drivers actually tested on >>> those? >> >> No, I haven't. The whole point is that we're not going to keep 40000 >> lines of code around despite notice for users that don't exist or >> care. If there is a regression we'll fix it, but we're not going to >> make life miserable just because we can. > > The pata_ali driver works fine on my UP1500 machine, unless something > broke recently. I'll build the latest kernel and report back. 5.11.7 seems fine too.
Al Viro <viro@zeniv.linux.org.uk> writes: > ... > > Do you have reports of libata variants of drivers actually tested on > those? PATA_CMD64X works fine on my 164LX for many years, last tested with 5.12-rc3. (with a caveat: in my setup with CF card DMA is broken, but it is broken with BLK_DEV_CMD64X as well).
diff --git a/arch/alpha/configs/defconfig b/arch/alpha/configs/defconfig index 724c4075df408e..dd2dd9f0861f18 100644 --- a/arch/alpha/configs/defconfig +++ b/arch/alpha/configs/defconfig @@ -25,19 +25,18 @@ CONFIG_PNP=y CONFIG_ISAPNP=y CONFIG_BLK_DEV_FD=y CONFIG_BLK_DEV_LOOP=m -CONFIG_IDE=y -CONFIG_BLK_DEV_IDECD=y -CONFIG_IDE_GENERIC=y -CONFIG_BLK_DEV_GENERIC=y -CONFIG_BLK_DEV_ALI15X3=y -CONFIG_BLK_DEV_CMD64X=y -CONFIG_BLK_DEV_CY82C693=y CONFIG_SCSI=y CONFIG_BLK_DEV_SD=y CONFIG_BLK_DEV_SR=y CONFIG_SCSI_AIC7XXX=m CONFIG_AIC7XXX_CMDS_PER_DEVICE=253 # CONFIG_AIC7XXX_DEBUG_ENABLE is not set +CONFIG_ATA=y +# CONFIG_SATA_PMP is not set +CONFIG_PATA_ALI=y +CONFIG_PATA_CMD64X=y +CONFIG_PATA_CYPRESS=y +CONFIG_ATA_GENERIC=y CONFIG_NETDEVICES=y CONFIG_DUMMY=m CONFIG_NET_ETHERNET=y
Switch the alpha defconfig from the legacy ide driver to libata. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/alpha/configs/defconfig | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)