mbox series

[SRU,Unstable/OEM-5.10,0/2] Fix USB audio devices without quirk

Message ID 20210312065605.1220504-1-kai.heng.feng@canonical.com
Headers show
Series Fix USB audio devices without quirk | expand

Message

Kai-Heng Feng March 12, 2021, 6:56 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1918670

[Impact]
After LP: #1917842, USB audio devices that don't have quirk stop
working.

[Fix]
1) Only apply quirk if it exists.
2) Check quirk before the driver is freed.

[Test]
Ckeck if USB audio works fine.
The reporter verifed the fix solves the issue.

[Where problems could occur]
This fix checks NULL more thoroughly, so it's unlikely to indroduce any
new issues.

Pavel Skripkin (2):
  ALSA: usb-audio: fix NULL ptr dereference in usb_audio_probe
  ALSA: usb-audio: fix use after free in usb_audio_disconnect

 sound/usb/card.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Tim Gardner March 16, 2021, 1:07 p.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Is unstable/oem-5.10 the same as focal:linux-oem-5.10 ?

Builds OK.

On 3/11/21 11:56 PM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1918670
> 
> [Impact]
> After LP: #1917842, USB audio devices that don't have quirk stop
> working.
> 
> [Fix]
> 1) Only apply quirk if it exists.
> 2) Check quirk before the driver is freed.
> 
> [Test]
> Ckeck if USB audio works fine.
> The reporter verifed the fix solves the issue.
> 
> [Where problems could occur]
> This fix checks NULL more thoroughly, so it's unlikely to indroduce any
> new issues.
> 
> Pavel Skripkin (2):
>    ALSA: usb-audio: fix NULL ptr dereference in usb_audio_probe
>    ALSA: usb-audio: fix use after free in usb_audio_disconnect
> 
>   sound/usb/card.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
Paolo Pisati March 17, 2021, 8:41 a.m. UTC | #2 
On Fri, Mar 12, 2021 at 02:56:03PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1918670

Both commits are already part of 5.12-rc3, so we get these from upstream.
Timo Aaltonen March 18, 2021, 7:40 p.m. UTC | #3 
On 12.3.2021 8.56, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1918670
> 
> [Impact]
> After LP: #1917842, USB audio devices that don't have quirk stop
> working.
> 
> [Fix]
> 1) Only apply quirk if it exists.
> 2) Check quirk before the driver is freed.
> 
> [Test]
> Ckeck if USB audio works fine.
> The reporter verifed the fix solves the issue.
> 
> [Where problems could occur]
> This fix checks NULL more thoroughly, so it's unlikely to indroduce any
> new issues.
> 
> Pavel Skripkin (2):
>    ALSA: usb-audio: fix NULL ptr dereference in usb_audio_probe
>    ALSA: usb-audio: fix use after free in usb_audio_disconnect
> 
>   sound/usb/card.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 

both already applied via stable updates