mbox series

[0/3] Fix bugs and add support for new Ingenic SoCs.

Message ID 1615308057-88387-1-git-send-email-zhouyanjie@wanyeetech.com
Headers show
Series Fix bugs and add support for new Ingenic SoCs. | expand

Message

Zhou Yanjie March 9, 2021, 4:40 p.m. UTC 
1.Add tabs before values to align the code in the macro definition section.
2.Fix bugs related to the MAC of JZ4770, add missing pins to the MII group.
3.Adjust the sequence of X1830's SSI related codes to make it consistent
  with other Ingenic SoCs.
4.Fix bug in "ingenic_pinconf_get()", so that it can read the configuration
  of X1830 SoC correctly.
5.Add the pinctrl bindings for the JZ4730 SoC, the JZ4750 SoC, the JZ4755 SoC,
  the JZ4775 SoC and the X2000 SoC from Ingenic.
6.Add support for probing the pinctrl-ingenic driver on the JZ4730 SoC,
  the JZ4750 SoC, the JZ4755 SoC, the JZ4775 SoC and the X2000 SoC from
  Ingenic.

周琰杰 (Zhou Yanjie) (3):
  pinctrl: Ingenic: Fix bug and reformat the code.
  dt-bindings: pinctrl: Add bindings for new Ingenic SoCs.
  pinctrl: Ingenic: Add support for new Ingenic SoCs.

 .../bindings/pinctrl/ingenic,pinctrl.yaml          |   23 +-
 drivers/pinctrl/pinctrl-ingenic.c                  | 1419 ++++++++++++++++++--
 2 files changed, 1351 insertions(+), 91 deletions(-)

Comments

Andy Shevchenko March 10, 2021, 2:03 p.m. UTC | #1 
On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> wrote:
>
> 1.Add tabs before values to align the code in the macro definition section.
> 2.Fix bugs related to the MAC of JZ4770, add missing pins to the MII group.
> 3.Adjust the sequence of X1830's SSI related codes to make it consistent
>   with other Ingenic SoCs.
> 4.Fix bug in "ingenic_pinconf_get()", so that it can read the configuration
>   of X1830 SoC correctly.
>

Split to 4 patches then.
It's quite hard for everybody to handle regression fixes like this.
Paul Cercueil March 10, 2021, 2:19 p.m. UTC | #2 
Le mer. 10 mars 2021 à 16:03, Andy Shevchenko 
<andy.shevchenko@gmail.com> a écrit :
> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> wrote:
>> 
>>  1.Add tabs before values to align the code in the macro definition 
>> section.
>>  2.Fix bugs related to the MAC of JZ4770, add missing pins to the 
>> MII group.
>>  3.Adjust the sequence of X1830's SSI related codes to make it 
>> consistent
>>    with other Ingenic SoCs.
>>  4.Fix bug in "ingenic_pinconf_get()", so that it can read the 
>> configuration
>>    of X1830 SoC correctly.
>> 
> 
> Split to 4 patches then.
> It's quite hard for everybody to handle regression fixes like this.

Agreed. And the fixes should have a Fixes: tag.

-Paul
Zhou Yanjie March 10, 2021, 2:27 p.m. UTC | #3 
Hi Andy,

On 2021/3/10 下午10:03, Andy Shevchenko wrote:
> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> wrote:
>> 1.Add tabs before values to align the code in the macro definition section.
>> 2.Fix bugs related to the MAC of JZ4770, add missing pins to the MII group.
>> 3.Adjust the sequence of X1830's SSI related codes to make it consistent
>>    with other Ingenic SoCs.
>> 4.Fix bug in "ingenic_pinconf_get()", so that it can read the configuration
>>    of X1830 SoC correctly.
>>
> Split to 4 patches then.
> It's quite hard for everybody to handle regression fixes like this.
>

Sure, I will split it to 4 patches in v2.


Thanks and best regards!
Zhou Yanjie March 10, 2021, 2:28 p.m. UTC | #4 
Hi Paul,

On 2021/3/10 下午10:19, Paul Cercueil wrote:
>
>
> Le mer. 10 mars 2021 à 16:03, Andy Shevchenko 
> <andy.shevchenko@gmail.com> a écrit :
>> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
>> <zhouyanjie@wanyeetech.com> wrote:
>>>
>>>  1.Add tabs before values to align the code in the macro definition 
>>> section.
>>>  2.Fix bugs related to the MAC of JZ4770, add missing pins to the 
>>> MII group.
>>>  3.Adjust the sequence of X1830's SSI related codes to make it 
>>> consistent
>>>    with other Ingenic SoCs.
>>>  4.Fix bug in "ingenic_pinconf_get()", so that it can read the 
>>> configuration
>>>    of X1830 SoC correctly.
>>>
>>
>> Split to 4 patches then.
>> It's quite hard for everybody to handle regression fixes like this.
>
> Agreed. And the fixes should have a Fixes: tag.
>

Sure.


> -Paul
>