mbox series

[v2,0/2] add Kontron pITX-imx8m board

Message ID 20210222140756.713-1-heiko.thiery@gmail.com
Headers show
Series add Kontron pITX-imx8m board | expand

Message

Heiko Thiery Feb. 22, 2021, 2:07 p.m. UTC
This patch series adds support for the Kontron pITX-imx8m board:

https://www.kontron.com/products/boards-and-standard-form-factors/single-board-computer/pitx-imx8m.html

Heiko Thiery (2):
  dt-bindings: arm: fsl: add Kontron pITX-imx8m board
  arm64: dts: fsl: add support for Kontron pitx-imx8m board

 .../devicetree/bindings/arm/fsl.yaml          |   1 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../freescale/imx8mq-kontron-pitx-imx8m.dts   | 641 ++++++++++++++++++
 3 files changed, 643 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts

Comments

Michael Walle Feb. 22, 2021, 3:15 p.m. UTC | #1
Am 2021-02-22 15:07, schrieb Heiko Thiery:
> The Kontron pitx-imx8m board is based on an i.MX8MQ soc.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
>  - bring root nodes in alphabetical order
>  - remove pinctrl_gpio_keys for pciewake
>  - remove pinctrl_sai2 and pinctrl_spdfif1 since it is not used yet
> 
>  Thanks to Michael Walle:
>  - add pinctrl for regulator-v-3v3-sd
>  - add name for regulator swbst
>  - add comment about currently unused audio codec
>  - put usb_phy entry in correct alphabetical order
> 
>  Thanks to Krzysztof Kozlowski:
>  - use generic names for pcie-refclk, tpm, fan-controller, sensor
>  - remove empty line
>  - fix group name to match schema (ecspi2cs -> ecspi2csgrp)
> 
> 
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../freescale/imx8mq-kontron-pitx-imx8m.dts   | 641 ++++++++++++++++++
>  2 files changed, 642 insertions(+)
>  create mode 100644 
> arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile
> b/arch/arm64/boot/dts/freescale/Makefile
> index 6438db3822f8..9fc2c6f64407 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -47,6 +47,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mq-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mq-hummingboard-pulse.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mq-kontron-pitx-imx8m.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
> diff --git
> a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> new file mode 100644
> index 000000000000..82364e394ed2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> @@ -0,0 +1,641 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device Tree File for the Kontron pitx-imx8m board.
> + *
> + * Copyright (C) 2021 Heiko Thiery <heiko.thiery@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "imx8mq.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>
> +
> +/ {
> +	model = "Kontron pITX-imx8m";
> +	compatible = "kontron,pitx-imx8m", "fsl,imx8mq";
> +
> +	aliases {
> +		i2c0 = &i2c1;
> +		i2c1 = &i2c2;
> +		i2c2 = &i2c3;
> +		mmc0 = &usdhc1;
> +		mmc1 = &usdhc2;
> +		serial0 = &uart1;
> +		serial1 = &uart2;
> +		serial2 = &uart3;
> +		spi0 = &qspi0;
> +		spi1 = &ecspi2;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial2:115200n8";
> +	};
> +
> +	pcie0_refclk: clock-pcie0-refclk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <100000000>;
> +	};
> +
> +	pcie1_refclk: clock-pcie1-refclk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <100000000>;
> +	};
> +
> +	reg_usdhc2_vmmc: regulator-v-3v3-sd {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_reg_usdhc2>;
> +		compatible = "regulator-fixed";

compatible comes first

> +		regulator-name = "V_3V3_SD";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> +		off-on-delay-us = <20000>;
> +		enable-active-high;
> +	};
> +
> +	tpm_reset: tpm-reset {
> +		compatible = "gpio-reset";
> +		reset-gpios = <&gpio3 2 GPIO_ACTIVE_LOW>;
> +		reset-delay-us = <2>;
> +		reset-post-delay-ms = <60>;
> +		#reset-cells = <0>;
> +	};
> +
> +	usb_hub_reset: usb-hub-reset {
> +		compatible = "gpio-reset";
> +		reset-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>;
> +		reset-delay-us = <3000>;
> +		reset-post-delay-ms = <50>;
> +		#reset-cells = <0>;
> +	};
> +};
> +
> +&ecspi2 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> +	cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +
> +	tpm@0 {
> +		compatible = "infineon,slb9670";
> +		reg = <0>;
> +		resets = <&tpm_reset>;
> +		spi-max-frequency = <43000000>;
> +	};
> +};
> +
> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fec1>;
> +	phy-mode = "rgmii-id";
> +	phy-handle = <&ethphy0>;
> +	phy-reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
> +	fsl,magic-packet;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";
> +			reg = <0>;
> +			ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
> +			ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_75_NS>;
> +			ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> +		};
> +	};
> +};
> +
> +&i2c1 {
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	status = "okay";
> +
> +	pmic@8 {
> +		compatible = "fsl,pfuze100";
> +		fsl,pfuze-support-disable-sw;
> +		reg = <0x8>;
> +
> +		regulators {
> +			sw1a_reg: sw1ab {
> +				regulator-name = "V_0V9_GPU";
> +				regulator-min-microvolt = <825000>;
> +				regulator-max-microvolt = <1100000>;
> +			};
> +
> +			sw1c_reg: sw1c {
> +				regulator-name = "V_0V9_VPU";
> +				regulator-min-microvolt = <825000>;
> +				regulator-max-microvolt = <1100000>;
> +			};
> +
> +			sw2_reg: sw2 {
> +				regulator-name = "V_1V1_NVCC_DRAM";
> +				regulator-min-microvolt = <1100000>;
> +				regulator-max-microvolt = <1100000>;
> +				regulator-always-on;
> +			};
> +
> +			sw3a_reg: sw3ab {
> +				regulator-name = "V_1V0_DRAM";
> +				regulator-min-microvolt = <825000>;
> +				regulator-max-microvolt = <1100000>;
> +				regulator-always-on;
> +			};
> +
> +			sw4_reg: sw4 {
> +				regulator-name = "V_1V8_S0";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +			};
> +
> +			swbst_reg: swbst {
> +				regulator-name = "NC";
> +				regulator-min-microvolt = <5000000>;
> +				regulator-max-microvolt = <5150000>;
> +			};
> +
> +			snvs_reg: vsnvs {
> +				regulator-name = "V_0V9_SNVS";
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-always-on;
> +			};
> +
> +			vref_reg: vrefddr {
> +				regulator-name = "V_0V55_VREF_DDR";
> +				regulator-always-on;
> +			};
> +
> +			vgen1_reg: vgen1 {
> +				regulator-name = "V_1V5_CSI";
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <1550000>;
> +			};
> +
> +			vgen2_reg: vgen2 {
> +				regulator-name = "V_0V9_PHY";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <975000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen3_reg: vgen3 {
> +				regulator-name = "V_1V8_PHY";
> +				regulator-min-microvolt = <1675000>;
> +				regulator-max-microvolt = <1975000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen4_reg: vgen4 {
> +				regulator-name = "V_1V8_VDDA";
> +				regulator-min-microvolt = <1625000>;
> +				regulator-max-microvolt = <1875000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen5_reg: vgen5 {
> +				regulator-name = "V_3V3_PHY";
> +				regulator-min-microvolt = <3075000>;
> +				regulator-max-microvolt = <3625000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen6_reg: vgen6 {
> +				regulator-name = "V_2V8_CAM";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +
> +	fan-controller@1b {
> +		compatible = "maxim,max6650";
> +		reg = <0x1b>;
> +		maxim,fan-microvolt = <5000000>;
> +	};
> +
> +	rtc@32 {
> +		compatible = "microcrystal,rv8803";
> +		reg = <0x32>;
> +	};
> +
> +	sensor@4b {
> +		compatible = "national,lm75b";
> +		reg = <0x4b>;
> +	};
> +
> +	eeprom@51 {
> +		compatible = "atmel,24c32";
> +		reg = <0x51>;
> +		pagesize = <32>;
> +	};
> +};
> +
> +&i2c2 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +};
> +
> +&i2c3 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3>;
> +	status = "okay";
> +
> +	/* TODO: configure audio, as of now just put a placeholder */

wouldn't it make more sense to remove this node and introduce it
together with sound support for this board, which I assume is the
reason to have the audio codec.

-michael

> +	wm8904: audio-codec@1a {
> +		compatible = "wlf,wm8904";
> +		reg = <0x1a>;
> +		clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> +		clock-names = "mclk";
> +		clock-frequency = <24000000>;
> +	};
> +};
> +
> +/* M.2 B-key slot */
> +&pcie0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pcie0>;
> +	disable-gpio = <&gpio5 29 GPIO_ACTIVE_LOW>;
> +	reset-gpio = <&gpio1 9 GPIO_ACTIVE_LOW>;
> +	clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>,
> +		 <&clk IMX8MQ_CLK_PCIE1_AUX>,
> +		 <&clk IMX8MQ_CLK_PCIE1_PHY>,
> +		 <&pcie0_refclk>;
> +	clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> +	ext_osc = <1>;
> +	status = "okay";
> +};
> +
> +/* Intel Ethernet Controller I210/I211 */
> +&pcie1 {
> +	clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>,
> +		 <&clk IMX8MQ_CLK_PCIE2_AUX>,
> +		 <&clk IMX8MQ_CLK_PCIE2_PHY>,
> +		 <&pcie1_refclk>;
> +	clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> +	ext_osc = <1>;
> +	fsl,max-link-speed = <1>;
> +	status = "okay";
> +};
> +
> +&pgc_gpu {
> +	power-supply = <&sw1a_reg>;
> +};
> +
> +&pgc_vpu {
> +	power-supply = <&sw1c_reg>;
> +};
> +
> +&qspi0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_qspi>;
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		reg = <0>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
> +		m25p,fast-read;
> +		spi-max-frequency = <50000000>;
> +	};
> +};
> +
> +&snvs_pwrkey {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1>;
> +	assigned-clocks = <&clk IMX8MQ_CLK_UART1>;
> +	assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart2>;
> +	assigned-clocks = <&clk IMX8MQ_CLK_UART2>;
> +	assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> +	status = "okay";
> +};
> +
> +&uart3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart3>;
> +	fsl,uart-has-rtscts;
> +	assigned-clocks = <&clk IMX8MQ_CLK_UART3>;
> +	assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> +	status = "okay";
> +};
> +
> +&usb3_phy0 {
> +	status = "okay";
> +};
> +
> +&usb3_phy1 {
> +	status = "okay";
> +};
> +
> +&usb_dwc3_0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usb0>;
> +	dr_mode = "otg";
> +	hnp-disable;
> +	srp-disable;
> +	adp-disable;
> +	maximum-speed = "high-speed";
> +	status = "okay";
> +};
> +
> +&usb_dwc3_1 {
> +	resets = <&usb_hub_reset>;
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
> +&usdhc1 {
> +	assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
> +	assigned-clock-rates = <400000000>;
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +	pinctrl-0 = <&pinctrl_usdhc1>;
> +	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> +	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> +	vqmmc-supply = <&sw4_reg>;
> +	bus-width = <8>;
> +	non-removable;
> +	no-sd;
> +	no-sdio;
> +	status = "okay";
> +};
> +
> +&usdhc2 {
> +	assigned-clocks = <&clk IMX8MQ_CLK_USDHC2>;
> +	assigned-clock-rates = <200000000>;
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> +	bus-width = <4>;
> +	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> +	wp-gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>;
> +	vmmc-supply = <&reg_usdhc2_vmmc>;
> +	status = "okay";
> +};
> +
> +&wdog1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_wdog>;
> +	fsl,ext-reset-output;
> +	status = "okay";
> +};
> +
> +&iomuxc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_hog>;
> +
> +	pinctrl_hog: hoggrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_NAND_CE1_B_GPIO3_IO2		0x19 /* TPM Reset */
> +			MX8MQ_IOMUXC_NAND_CE3_B_GPIO3_IO4		0x19 /* USB2 Hub Reset */
> +		>;
> +	};
> +
> +	pinctrl_gpio: gpiogrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5			0x19 /* GPIO0 */
> +			MX8MQ_IOMUXC_NAND_RE_B_GPIO3_IO15		0x19 /* GPIO1 */
> +			MX8MQ_IOMUXC_NAND_WE_B_GPIO3_IO17		0x19 /* GPIO2 */
> +			MX8MQ_IOMUXC_NAND_WP_B_GPIO3_IO18		0x19 /* GPIO3 */
> +			MX8MQ_IOMUXC_NAND_READY_B_GPIO3_IO16		0x19 /* GPIO4 */
> +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10		0x19 /* GPIO5 */
> +			MX8MQ_IOMUXC_NAND_DATA05_GPIO3_IO11		0x19 /* GPIO6 */
> +			MX8MQ_IOMUXC_NAND_DATA06_GPIO3_IO12		0x19 /* GPIO7 */
> +		>;
> +	};
> +
> +	pinctrl_pcie0: pcie0grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO09_GPIO1_IO9		0x16 /* PCIE_PERST */
> +			MX8MQ_IOMUXC_UART4_TXD_GPIO5_IO29		0x16 /* W_DISABLE */
> +		>;
> +	};
> +
> +	pinctrl_reg_usdhc2: regusdhc2gpiogrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19		0x41
> +		>;
> +	};
> +
> +	pinctrl_fec1: fec1grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC			0x3
> +			MX8MQ_IOMUXC_ENET_MDIO_ENET1_MDIO		0x23
> +			MX8MQ_IOMUXC_ENET_TD3_ENET1_RGMII_TD3		0x1f
> +			MX8MQ_IOMUXC_ENET_TD2_ENET1_RGMII_TD2		0x1f
> +			MX8MQ_IOMUXC_ENET_TD1_ENET1_RGMII_TD1		0x1f
> +			MX8MQ_IOMUXC_ENET_TD0_ENET1_RGMII_TD0		0x1f
> +			MX8MQ_IOMUXC_ENET_RD3_ENET1_RGMII_RD3		0x91
> +			MX8MQ_IOMUXC_ENET_RD2_ENET1_RGMII_RD2		0x91
> +			MX8MQ_IOMUXC_ENET_RD1_ENET1_RGMII_RD1		0x91
> +			MX8MQ_IOMUXC_ENET_RD0_ENET1_RGMII_RD0		0x91
> +			MX8MQ_IOMUXC_ENET_TXC_ENET1_RGMII_TXC		0x1f
> +			MX8MQ_IOMUXC_ENET_RXC_ENET1_RGMII_RXC		0x91
> +			MX8MQ_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL	0x91
> +			MX8MQ_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL	0x1f
> +			MX8MQ_IOMUXC_GPIO1_IO11_GPIO1_IO11		0x16
> +			MX8MQ_IOMUXC_GPIO1_IO15_GPIO1_IO15		0x16
> +		>;
> +	};
> +
> +	pinctrl_i2c1: i2c1grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL			0x4000007f
> +			MX8MQ_IOMUXC_I2C1_SDA_I2C1_SDA			0x4000007f
> +		>;
> +	};
> +
> +	pinctrl_i2c2: i2c2grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_I2C2_SCL_I2C2_SCL			0x4000007f
> +			MX8MQ_IOMUXC_I2C2_SDA_I2C2_SDA			0x4000007f
> +		>;
> +	};
> +
> +	pinctrl_i2c3: i2c3grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_I2C3_SCL_I2C3_SCL			0x4000007f
> +			MX8MQ_IOMUXC_I2C3_SDA_I2C3_SDA			0x4000007f
> +		>;
> +	};
> +
> +	pinctrl_qspi: qspigrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_NAND_ALE_QSPI_A_SCLK		0x82
> +			MX8MQ_IOMUXC_NAND_CE0_B_QSPI_A_SS0_B		0x82
> +			MX8MQ_IOMUXC_NAND_DATA00_QSPI_A_DATA0		0x82
> +			MX8MQ_IOMUXC_NAND_DATA01_QSPI_A_DATA1		0x82
> +			MX8MQ_IOMUXC_NAND_DATA02_QSPI_A_DATA2		0x82
> +			MX8MQ_IOMUXC_NAND_DATA03_QSPI_A_DATA3		0x82
> +		>;
> +	};
> +
> +	pinctrl_ecspi2: ecspi2grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI		0x19
> +			MX8MQ_IOMUXC_ECSPI2_MISO_ECSPI2_MISO		0x19
> +			MX8MQ_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK		0x19
> +		>;
> +	};
> +
> +	pinctrl_ecspi2_cs: ecspi2csgrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_ECSPI2_SS0_GPIO5_IO13		0x19
> +		>;
> +	};
> +
> +	pinctrl_uart1: uart1grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_UART1_TXD_UART1_DCE_TX		0x49
> +			MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX		0x49
> +		>;
> +	};
> +
> +	pinctrl_uart2: uart2grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_UART2_TXD_UART2_DCE_TX		0x49
> +			MX8MQ_IOMUXC_UART2_RXD_UART2_DCE_RX		0x49
> +		>;
> +	};
> +
> +	pinctrl_uart3: uart3grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_UART3_TXD_UART3_DCE_TX		0x49
> +			MX8MQ_IOMUXC_UART3_RXD_UART3_DCE_RX		0x49
> +			MX8MQ_IOMUXC_ECSPI1_SS0_UART3_DCE_RTS_B		0x49
> +			MX8MQ_IOMUXC_ECSPI1_MISO_UART3_DCE_CTS_B	0x49
> +		>;
> +	};
> +
> +	pinctrl_usdhc1: usdhc1grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK			0x83
> +			MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD			0xc3
> +			MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6		0xc3
> +			MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7		0xc3
> +			MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE		0x83
> +			MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usdhc1_100mhz: usdhc1-100grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK			0x8d
> +			MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD			0xcd
> +			MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6		0xcd
> +			MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7		0xcd
> +			MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE		0x8d
> +			MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usdhc1_200mhz: usdhc1-200grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK			0x9f
> +			MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD			0xdf
> +			MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6		0xdf
> +			MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7		0xdf
> +			MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE		0x9f
> +			MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD2_CD_B_GPIO2_IO12		0x41
> +			MX8MQ_IOMUXC_SD2_WP_GPIO2_IO20			0x19
> +		>;
> +	};
> +
> +	pinctrl_usdhc2: usdhc2grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x83
> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xc3
> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xc3
> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xc3
> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xc3
> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xc3
> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usdhc2_100mhz: usdhc2-100grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x8d
> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xcd
> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xcd
> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xcd
> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xcd
> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xcd
> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usdhc2_200mhz: usdhc2-200grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x9f
> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xdf
> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xdf
> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xdf
> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xdf
> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xdf
> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
> +		>;
> +	};
> +
> +	pinctrl_usb0: usb0grp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO12_USB1_OTG_PWR		0x19
> +			MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC		0x19
> +		>;
> +	};
> +
> +	pinctrl_wdog: wdoggrp {
> +		fsl,pins = <
> +			MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B		0xc6
> +		>;
> +	};
> +};
Heiko Thiery Feb. 22, 2021, 4:57 p.m. UTC | #2
Hi Michael,

Am Mo., 22. Feb. 2021 um 16:15 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Am 2021-02-22 15:07, schrieb Heiko Thiery:
> > The Kontron pitx-imx8m board is based on an i.MX8MQ soc.
> >
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > ---
> > v2:
> >  - bring root nodes in alphabetical order
> >  - remove pinctrl_gpio_keys for pciewake
> >  - remove pinctrl_sai2 and pinctrl_spdfif1 since it is not used yet
> >
> >  Thanks to Michael Walle:
> >  - add pinctrl for regulator-v-3v3-sd
> >  - add name for regulator swbst
> >  - add comment about currently unused audio codec
> >  - put usb_phy entry in correct alphabetical order
> >
> >  Thanks to Krzysztof Kozlowski:
> >  - use generic names for pcie-refclk, tpm, fan-controller, sensor
> >  - remove empty line
> >  - fix group name to match schema (ecspi2cs -> ecspi2csgrp)
> >
> >
> >  arch/arm64/boot/dts/freescale/Makefile        |   1 +
> >  .../freescale/imx8mq-kontron-pitx-imx8m.dts   | 641 ++++++++++++++++++
> >  2 files changed, 642 insertions(+)
> >  create mode 100644
> > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index 6438db3822f8..9fc2c6f64407 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -47,6 +47,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mq-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mq-hummingboard-pulse.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mq-kontron-pitx-imx8m.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-devkit.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r2.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mq-librem5-r3.dtb
> > diff --git
> > a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > new file mode 100644
> > index 000000000000..82364e394ed2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > @@ -0,0 +1,641 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Device Tree File for the Kontron pitx-imx8m board.
> > + *
> > + * Copyright (C) 2021 Heiko Thiery <heiko.thiery@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "imx8mq.dtsi"
> > +#include <dt-bindings/net/ti-dp83867.h>
> > +
> > +/ {
> > +     model = "Kontron pITX-imx8m";
> > +     compatible = "kontron,pitx-imx8m", "fsl,imx8mq";
> > +
> > +     aliases {
> > +             i2c0 = &i2c1;
> > +             i2c1 = &i2c2;
> > +             i2c2 = &i2c3;
> > +             mmc0 = &usdhc1;
> > +             mmc1 = &usdhc2;
> > +             serial0 = &uart1;
> > +             serial1 = &uart2;
> > +             serial2 = &uart3;
> > +             spi0 = &qspi0;
> > +             spi1 = &ecspi2;
> > +     };
> > +
> > +     chosen {
> > +             stdout-path = "serial2:115200n8";
> > +     };
> > +
> > +     pcie0_refclk: clock-pcie0-refclk {
> > +             compatible = "fixed-clock";
> > +             #clock-cells = <0>;
> > +             clock-frequency = <100000000>;
> > +     };
> > +
> > +     pcie1_refclk: clock-pcie1-refclk {
> > +             compatible = "fixed-clock";
> > +             #clock-cells = <0>;
> > +             clock-frequency = <100000000>;
> > +     };
> > +
> > +     reg_usdhc2_vmmc: regulator-v-3v3-sd {
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_reg_usdhc2>;
> > +             compatible = "regulator-fixed";
>
> compatible comes first

Ups. I will fix that.

> > +             regulator-name = "V_3V3_SD";
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > +             off-on-delay-us = <20000>;
> > +             enable-active-high;
> > +     };
> > +
> > +     tpm_reset: tpm-reset {
> > +             compatible = "gpio-reset";
> > +             reset-gpios = <&gpio3 2 GPIO_ACTIVE_LOW>;
> > +             reset-delay-us = <2>;
> > +             reset-post-delay-ms = <60>;
> > +             #reset-cells = <0>;
> > +     };
> > +
> > +     usb_hub_reset: usb-hub-reset {
> > +             compatible = "gpio-reset";
> > +             reset-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>;
> > +             reset-delay-us = <3000>;
> > +             reset-post-delay-ms = <50>;
> > +             #reset-cells = <0>;
> > +     };
> > +};
> > +
> > +&ecspi2 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> > +     cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> > +     status = "okay";
> > +
> > +     tpm@0 {
> > +             compatible = "infineon,slb9670";
> > +             reg = <0>;
> > +             resets = <&tpm_reset>;
> > +             spi-max-frequency = <43000000>;
> > +     };
> > +};
> > +
> > +&fec1 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_fec1>;
> > +     phy-mode = "rgmii-id";
> > +     phy-handle = <&ethphy0>;
> > +     phy-reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
> > +     fsl,magic-packet;
> > +     status = "okay";
> > +
> > +     mdio {
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             ethphy0: ethernet-phy@0 {
> > +                     compatible = "ethernet-phy-ieee802.3-c22";
> > +                     reg = <0>;
> > +                     ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
> > +                     ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_75_NS>;
> > +                     ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> > +             };
> > +     };
> > +};
> > +
> > +&i2c1 {
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c1>;
> > +     status = "okay";
> > +
> > +     pmic@8 {
> > +             compatible = "fsl,pfuze100";
> > +             fsl,pfuze-support-disable-sw;
> > +             reg = <0x8>;
> > +
> > +             regulators {
> > +                     sw1a_reg: sw1ab {
> > +                             regulator-name = "V_0V9_GPU";
> > +                             regulator-min-microvolt = <825000>;
> > +                             regulator-max-microvolt = <1100000>;
> > +                     };
> > +
> > +                     sw1c_reg: sw1c {
> > +                             regulator-name = "V_0V9_VPU";
> > +                             regulator-min-microvolt = <825000>;
> > +                             regulator-max-microvolt = <1100000>;
> > +                     };
> > +
> > +                     sw2_reg: sw2 {
> > +                             regulator-name = "V_1V1_NVCC_DRAM";
> > +                             regulator-min-microvolt = <1100000>;
> > +                             regulator-max-microvolt = <1100000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     sw3a_reg: sw3ab {
> > +                             regulator-name = "V_1V0_DRAM";
> > +                             regulator-min-microvolt = <825000>;
> > +                             regulator-max-microvolt = <1100000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     sw4_reg: sw4 {
> > +                             regulator-name = "V_1V8_S0";
> > +                             regulator-min-microvolt = <1800000>;
> > +                             regulator-max-microvolt = <1800000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     swbst_reg: swbst {
> > +                             regulator-name = "NC";
> > +                             regulator-min-microvolt = <5000000>;
> > +                             regulator-max-microvolt = <5150000>;
> > +                     };
> > +
> > +                     snvs_reg: vsnvs {
> > +                             regulator-name = "V_0V9_SNVS";
> > +                             regulator-min-microvolt = <1000000>;
> > +                             regulator-max-microvolt = <3000000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vref_reg: vrefddr {
> > +                             regulator-name = "V_0V55_VREF_DDR";
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vgen1_reg: vgen1 {
> > +                             regulator-name = "V_1V5_CSI";
> > +                             regulator-min-microvolt = <800000>;
> > +                             regulator-max-microvolt = <1550000>;
> > +                     };
> > +
> > +                     vgen2_reg: vgen2 {
> > +                             regulator-name = "V_0V9_PHY";
> > +                             regulator-min-microvolt = <850000>;
> > +                             regulator-max-microvolt = <975000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vgen3_reg: vgen3 {
> > +                             regulator-name = "V_1V8_PHY";
> > +                             regulator-min-microvolt = <1675000>;
> > +                             regulator-max-microvolt = <1975000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vgen4_reg: vgen4 {
> > +                             regulator-name = "V_1V8_VDDA";
> > +                             regulator-min-microvolt = <1625000>;
> > +                             regulator-max-microvolt = <1875000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vgen5_reg: vgen5 {
> > +                             regulator-name = "V_3V3_PHY";
> > +                             regulator-min-microvolt = <3075000>;
> > +                             regulator-max-microvolt = <3625000>;
> > +                             regulator-always-on;
> > +                     };
> > +
> > +                     vgen6_reg: vgen6 {
> > +                             regulator-name = "V_2V8_CAM";
> > +                             regulator-min-microvolt = <1800000>;
> > +                             regulator-max-microvolt = <3300000>;
> > +                             regulator-always-on;
> > +                     };
> > +             };
> > +     };
> > +
> > +     fan-controller@1b {
> > +             compatible = "maxim,max6650";
> > +             reg = <0x1b>;
> > +             maxim,fan-microvolt = <5000000>;
> > +     };
> > +
> > +     rtc@32 {
> > +             compatible = "microcrystal,rv8803";
> > +             reg = <0x32>;
> > +     };
> > +
> > +     sensor@4b {
> > +             compatible = "national,lm75b";
> > +             reg = <0x4b>;
> > +     };
> > +
> > +     eeprom@51 {
> > +             compatible = "atmel,24c32";
> > +             reg = <0x51>;
> > +             pagesize = <32>;
> > +     };
> > +};
> > +
> > +&i2c2 {
> > +     clock-frequency = <100000>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c2>;
> > +     status = "okay";
> > +};
> > +
> > +&i2c3 {
> > +     clock-frequency = <100000>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i2c3>;
> > +     status = "okay";
> > +
> > +     /* TODO: configure audio, as of now just put a placeholder */
>
> wouldn't it make more sense to remove this node and introduce it
> together with sound support for this board, which I assume is the
> reason to have the audio codec.
>
> -michael

Ok. that make sense. I will remove this completely and add it then
with full sound support later.

>
> > +     wm8904: audio-codec@1a {
> > +             compatible = "wlf,wm8904";
> > +             reg = <0x1a>;
> > +             clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> > +             clock-names = "mclk";
> > +             clock-frequency = <24000000>;
> > +     };
> > +};
> > +
> > +/* M.2 B-key slot */
> > +&pcie0 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_pcie0>;
> > +     disable-gpio = <&gpio5 29 GPIO_ACTIVE_LOW>;
> > +     reset-gpio = <&gpio1 9 GPIO_ACTIVE_LOW>;
> > +     clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>,
> > +              <&clk IMX8MQ_CLK_PCIE1_AUX>,
> > +              <&clk IMX8MQ_CLK_PCIE1_PHY>,
> > +              <&pcie0_refclk>;
> > +     clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +     ext_osc = <1>;
> > +     status = "okay";
> > +};
> > +
> > +/* Intel Ethernet Controller I210/I211 */
> > +&pcie1 {
> > +     clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>,
> > +              <&clk IMX8MQ_CLK_PCIE2_AUX>,
> > +              <&clk IMX8MQ_CLK_PCIE2_PHY>,
> > +              <&pcie1_refclk>;
> > +     clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +     ext_osc = <1>;
> > +     fsl,max-link-speed = <1>;
> > +     status = "okay";
> > +};
> > +
> > +&pgc_gpu {
> > +     power-supply = <&sw1a_reg>;
> > +};
> > +
> > +&pgc_vpu {
> > +     power-supply = <&sw1c_reg>;
> > +};
> > +
> > +&qspi0 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_qspi>;
> > +     status = "okay";
> > +
> > +     flash@0 {
> > +             compatible = "jedec,spi-nor";
> > +             #address-cells = <1>;
> > +             #size-cells = <1>;
> > +             reg = <0>;
> > +             spi-tx-bus-width = <4>;
> > +             spi-rx-bus-width = <4>;
> > +             m25p,fast-read;
> > +             spi-max-frequency = <50000000>;
> > +     };
> > +};
> > +
> > +&snvs_pwrkey {
> > +     status = "okay";
> > +};
> > +
> > +&uart1 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_uart1>;
> > +     assigned-clocks = <&clk IMX8MQ_CLK_UART1>;
> > +     assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> > +     status = "okay";
> > +};
> > +
> > +&uart2 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_uart2>;
> > +     assigned-clocks = <&clk IMX8MQ_CLK_UART2>;
> > +     assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> > +     status = "okay";
> > +};
> > +
> > +&uart3 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_uart3>;
> > +     fsl,uart-has-rtscts;
> > +     assigned-clocks = <&clk IMX8MQ_CLK_UART3>;
> > +     assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>;
> > +     status = "okay";
> > +};
> > +
> > +&usb3_phy0 {
> > +     status = "okay";
> > +};
> > +
> > +&usb3_phy1 {
> > +     status = "okay";
> > +};
> > +
> > +&usb_dwc3_0 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_usb0>;
> > +     dr_mode = "otg";
> > +     hnp-disable;
> > +     srp-disable;
> > +     adp-disable;
> > +     maximum-speed = "high-speed";
> > +     status = "okay";
> > +};
> > +
> > +&usb_dwc3_1 {
> > +     resets = <&usb_hub_reset>;
> > +     dr_mode = "host";
> > +     status = "okay";
> > +};
> > +
> > +&usdhc1 {
> > +     assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
> > +     assigned-clock-rates = <400000000>;
> > +     pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +     pinctrl-0 = <&pinctrl_usdhc1>;
> > +     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> > +     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> > +     vqmmc-supply = <&sw4_reg>;
> > +     bus-width = <8>;
> > +     non-removable;
> > +     no-sd;
> > +     no-sdio;
> > +     status = "okay";
> > +};
> > +
> > +&usdhc2 {
> > +     assigned-clocks = <&clk IMX8MQ_CLK_USDHC2>;
> > +     assigned-clock-rates = <200000000>;
> > +     pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +     pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> > +     pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> > +     pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> > +     bus-width = <4>;
> > +     cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> > +     wp-gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>;
> > +     vmmc-supply = <&reg_usdhc2_vmmc>;
> > +     status = "okay";
> > +};
> > +
> > +&wdog1 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_wdog>;
> > +     fsl,ext-reset-output;
> > +     status = "okay";
> > +};
> > +
> > +&iomuxc {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_hog>;
> > +
> > +     pinctrl_hog: hoggrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_NAND_CE1_B_GPIO3_IO2               0x19 /* TPM Reset */
> > +                     MX8MQ_IOMUXC_NAND_CE3_B_GPIO3_IO4               0x19 /* USB2 Hub Reset */
> > +             >;
> > +     };
> > +
> > +     pinctrl_gpio: gpiogrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5                 0x19 /* GPIO0 */
> > +                     MX8MQ_IOMUXC_NAND_RE_B_GPIO3_IO15               0x19 /* GPIO1 */
> > +                     MX8MQ_IOMUXC_NAND_WE_B_GPIO3_IO17               0x19 /* GPIO2 */
> > +                     MX8MQ_IOMUXC_NAND_WP_B_GPIO3_IO18               0x19 /* GPIO3 */
> > +                     MX8MQ_IOMUXC_NAND_READY_B_GPIO3_IO16            0x19 /* GPIO4 */
> > +                     MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10             0x19 /* GPIO5 */
> > +                     MX8MQ_IOMUXC_NAND_DATA05_GPIO3_IO11             0x19 /* GPIO6 */
> > +                     MX8MQ_IOMUXC_NAND_DATA06_GPIO3_IO12             0x19 /* GPIO7 */
> > +             >;
> > +     };
> > +
> > +     pinctrl_pcie0: pcie0grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_GPIO1_IO09_GPIO1_IO9               0x16 /* PCIE_PERST */
> > +                     MX8MQ_IOMUXC_UART4_TXD_GPIO5_IO29               0x16 /* W_DISABLE */
> > +             >;
> > +     };
> > +
> > +     pinctrl_reg_usdhc2: regusdhc2gpiogrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19             0x41
> > +             >;
> > +     };
> > +
> > +     pinctrl_fec1: fec1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC                 0x3
> > +                     MX8MQ_IOMUXC_ENET_MDIO_ENET1_MDIO               0x23
> > +                     MX8MQ_IOMUXC_ENET_TD3_ENET1_RGMII_TD3           0x1f
> > +                     MX8MQ_IOMUXC_ENET_TD2_ENET1_RGMII_TD2           0x1f
> > +                     MX8MQ_IOMUXC_ENET_TD1_ENET1_RGMII_TD1           0x1f
> > +                     MX8MQ_IOMUXC_ENET_TD0_ENET1_RGMII_TD0           0x1f
> > +                     MX8MQ_IOMUXC_ENET_RD3_ENET1_RGMII_RD3           0x91
> > +                     MX8MQ_IOMUXC_ENET_RD2_ENET1_RGMII_RD2           0x91
> > +                     MX8MQ_IOMUXC_ENET_RD1_ENET1_RGMII_RD1           0x91
> > +                     MX8MQ_IOMUXC_ENET_RD0_ENET1_RGMII_RD0           0x91
> > +                     MX8MQ_IOMUXC_ENET_TXC_ENET1_RGMII_TXC           0x1f
> > +                     MX8MQ_IOMUXC_ENET_RXC_ENET1_RGMII_RXC           0x91
> > +                     MX8MQ_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL     0x91
> > +                     MX8MQ_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL     0x1f
> > +                     MX8MQ_IOMUXC_GPIO1_IO11_GPIO1_IO11              0x16
> > +                     MX8MQ_IOMUXC_GPIO1_IO15_GPIO1_IO15              0x16
> > +             >;
> > +     };
> > +
> > +     pinctrl_i2c1: i2c1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL                  0x4000007f
> > +                     MX8MQ_IOMUXC_I2C1_SDA_I2C1_SDA                  0x4000007f
> > +             >;
> > +     };
> > +
> > +     pinctrl_i2c2: i2c2grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_I2C2_SCL_I2C2_SCL                  0x4000007f
> > +                     MX8MQ_IOMUXC_I2C2_SDA_I2C2_SDA                  0x4000007f
> > +             >;
> > +     };
> > +
> > +     pinctrl_i2c3: i2c3grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_I2C3_SCL_I2C3_SCL                  0x4000007f
> > +                     MX8MQ_IOMUXC_I2C3_SDA_I2C3_SDA                  0x4000007f
> > +             >;
> > +     };
> > +
> > +     pinctrl_qspi: qspigrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_NAND_ALE_QSPI_A_SCLK               0x82
> > +                     MX8MQ_IOMUXC_NAND_CE0_B_QSPI_A_SS0_B            0x82
> > +                     MX8MQ_IOMUXC_NAND_DATA00_QSPI_A_DATA0           0x82
> > +                     MX8MQ_IOMUXC_NAND_DATA01_QSPI_A_DATA1           0x82
> > +                     MX8MQ_IOMUXC_NAND_DATA02_QSPI_A_DATA2           0x82
> > +                     MX8MQ_IOMUXC_NAND_DATA03_QSPI_A_DATA3           0x82
> > +             >;
> > +     };
> > +
> > +     pinctrl_ecspi2: ecspi2grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI            0x19
> > +                     MX8MQ_IOMUXC_ECSPI2_MISO_ECSPI2_MISO            0x19
> > +                     MX8MQ_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK            0x19
> > +             >;
> > +     };
> > +
> > +     pinctrl_ecspi2_cs: ecspi2csgrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_ECSPI2_SS0_GPIO5_IO13              0x19
> > +             >;
> > +     };
> > +
> > +     pinctrl_uart1: uart1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_UART1_TXD_UART1_DCE_TX             0x49
> > +                     MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX             0x49
> > +             >;
> > +     };
> > +
> > +     pinctrl_uart2: uart2grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_UART2_TXD_UART2_DCE_TX             0x49
> > +                     MX8MQ_IOMUXC_UART2_RXD_UART2_DCE_RX             0x49
> > +             >;
> > +     };
> > +
> > +     pinctrl_uart3: uart3grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_UART3_TXD_UART3_DCE_TX             0x49
> > +                     MX8MQ_IOMUXC_UART3_RXD_UART3_DCE_RX             0x49
> > +                     MX8MQ_IOMUXC_ECSPI1_SS0_UART3_DCE_RTS_B         0x49
> > +                     MX8MQ_IOMUXC_ECSPI1_MISO_UART3_DCE_CTS_B        0x49
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc1: usdhc1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK                 0x83
> > +                     MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD                 0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6             0xc3
> > +                     MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7             0xc3
> > +                     MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE           0x83
> > +                     MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B         0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc1_100mhz: usdhc1-100grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK                 0x8d
> > +                     MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD                 0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6             0xcd
> > +                     MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7             0xcd
> > +                     MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE           0x8d
> > +                     MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B         0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc1_200mhz: usdhc1-200grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK                 0x9f
> > +                     MX8MQ_IOMUXC_SD1_CMD_USDHC1_CMD                 0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA0_USDHC1_DATA0             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA1_USDHC1_DATA1             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA2_USDHC1_DATA2             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA3_USDHC1_DATA3             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA4_USDHC1_DATA4             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA5_USDHC1_DATA5             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA6_USDHC1_DATA6             0xdf
> > +                     MX8MQ_IOMUXC_SD1_DATA7_USDHC1_DATA7             0xdf
> > +                     MX8MQ_IOMUXC_SD1_STROBE_USDHC1_STROBE           0x9f
> > +                     MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B         0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD2_CD_B_GPIO2_IO12                0x41
> > +                     MX8MQ_IOMUXC_SD2_WP_GPIO2_IO20                  0x19
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc2: usdhc2grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK                 0x83
> > +                     MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD                 0xc3
> > +                     MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0             0xc3
> > +                     MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1             0xc3
> > +                     MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2             0xc3
> > +                     MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3             0xc3
> > +                     MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT          0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc2_100mhz: usdhc2-100grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK                 0x8d
> > +                     MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD                 0xcd
> > +                     MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0             0xcd
> > +                     MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1             0xcd
> > +                     MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2             0xcd
> > +                     MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3             0xcd
> > +                     MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT          0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usdhc2_200mhz: usdhc2-200grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK                 0x9f
> > +                     MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD                 0xdf
> > +                     MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0             0xdf
> > +                     MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1             0xdf
> > +                     MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2             0xdf
> > +                     MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3             0xdf
> > +                     MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT          0xc1
> > +             >;
> > +     };
> > +
> > +     pinctrl_usb0: usb0grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_GPIO1_IO12_USB1_OTG_PWR            0x19
> > +                     MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC             0x19
> > +             >;
> > +     };
> > +
> > +     pinctrl_wdog: wdoggrp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B            0xc6
> > +             >;
> > +     };
> > +};

Thank you
Krzysztof Kozlowski Feb. 22, 2021, 6:44 p.m. UTC | #3
On Mon, Feb 22, 2021 at 03:07:56PM +0100, Heiko Thiery wrote:
> The Kontron pitx-imx8m board is based on an i.MX8MQ soc.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
>  - bring root nodes in alphabetical order
>  - remove pinctrl_gpio_keys for pciewake
>  - remove pinctrl_sai2 and pinctrl_spdfif1 since it is not used yet
> 
>  Thanks to Michael Walle:
>  - add pinctrl for regulator-v-3v3-sd
>  - add name for regulator swbst
>  - add comment about currently unused audio codec
>  - put usb_phy entry in correct alphabetical order
> 
>  Thanks to Krzysztof Kozlowski:
>  - use generic names for pcie-refclk, tpm, fan-controller, sensor
>  - remove empty line
>  - fix group name to match schema (ecspi2cs -> ecspi2csgrp)
> 
> 
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../freescale/imx8mq-kontron-pitx-imx8m.dts   | 641 ++++++++++++++++++
>  2 files changed, 642 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> 

Looks fine to me, also with the changes pointed out by Micahel in other
email in this thread:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Fabio Estevam March 2, 2021, 2:43 p.m. UTC | #4
Hi Heiko,

On Mon, Feb 22, 2021 at 11:08 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:

> +       reg_usdhc2_vmmc: regulator-v-3v3-sd {

reg_usdhc2_vmmc: regulator-usdhc2-vmmc {

> +       tpm_reset: tpm-reset {
> +               compatible = "gpio-reset";

I don't see this compatible string documented.

> +               reset-gpios = <&gpio3 2 GPIO_ACTIVE_LOW>;
> +               reset-delay-us = <2>;
> +               reset-post-delay-ms = <60>;
> +               #reset-cells = <0>;
> +       };
> +
> +       usb_hub_reset: usb-hub-reset {
> +               compatible = "gpio-reset";

Same here.

> +&fec1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_fec1>;
> +       phy-mode = "rgmii-id";
> +       phy-handle = <&ethphy0>;
> +       phy-reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;

This property is deprecated. Please consider using reset-gpios inside
ethernet-phy instead.

> +       /* TODO: configure audio, as of now just put a placeholder */
> +       wm8904: audio-codec@1a {
> +               compatible = "wlf,wm8904";
> +               reg = <0x1a>;
> +               clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> +               clock-names = "mclk";
> +               clock-frequency = <24000000>;

Not a valid property.

> +/* M.2 B-key slot */
> +&pcie0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_pcie0>;
> +       disable-gpio = <&gpio5 29 GPIO_ACTIVE_LOW>;

Not a valid property.

> +       reset-gpio = <&gpio1 9 GPIO_ACTIVE_LOW>;
> +       clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>,
> +                <&clk IMX8MQ_CLK_PCIE1_AUX>,
> +                <&clk IMX8MQ_CLK_PCIE1_PHY>,
> +                <&pcie0_refclk>;
> +       clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> +       ext_osc = <1>;

Not a valid property.

> +/* Intel Ethernet Controller I210/I211 */
> +&pcie1 {
> +       clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>,
> +                <&clk IMX8MQ_CLK_PCIE2_AUX>,
> +                <&clk IMX8MQ_CLK_PCIE2_PHY>,
> +                <&pcie1_refclk>;
> +       clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> +       ext_osc = <1>;

Not a valid property.
Heiko Thiery March 3, 2021, 12:54 p.m. UTC | #5
Hi Fabio,


Am Di., 2. März 2021 um 15:43 Uhr schrieb Fabio Estevam <festevam@gmail.com>:
>
> Hi Heiko,
>
> On Mon, Feb 22, 2021 at 11:08 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> > +       reg_usdhc2_vmmc: regulator-v-3v3-sd {
>
> reg_usdhc2_vmmc: regulator-usdhc2-vmmc {

I used the same name as used on imx8mq-evk. Do you think a better name
is the one you proposed?

> > +       tpm_reset: tpm-reset {
> > +               compatible = "gpio-reset";
>
> I don't see this compatible string documented.

This comes from the linux-imx tree [1].  Nethertheless the reset seems
not to be used by the tpm driver for the infineon chip.

[1] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/reset/gpio-reset.c?h=imx_5.4.70_2.3.0

So I think I can remove it here.

>
> > +               reset-gpios = <&gpio3 2 GPIO_ACTIVE_LOW>;
> > +               reset-delay-us = <2>;
> > +               reset-post-delay-ms = <60>;
> > +               #reset-cells = <0>;
> > +       };
> > +
> > +       usb_hub_reset: usb-hub-reset {
> > +               compatible = "gpio-reset";
>
> Same here.

Also the usb-hub-reset can be removed.

>
> > +&fec1 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_fec1>;
> > +       phy-mode = "rgmii-id";
> > +       phy-handle = <&ethphy0>;
> > +       phy-reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
>
> This property is deprecated. Please consider using reset-gpios inside
> ethernet-phy instead.

Done

> > +       /* TODO: configure audio, as of now just put a placeholder */
> > +       wm8904: audio-codec@1a {
> > +               compatible = "wlf,wm8904";
> > +               reg = <0x1a>;
> > +               clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>;
> > +               clock-names = "mclk";
> > +               clock-frequency = <24000000>;
>
> Not a valid property.

The whole node is removed since v3.

> > +/* M.2 B-key slot */
> > +&pcie0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_pcie0>;
> > +       disable-gpio = <&gpio5 29 GPIO_ACTIVE_LOW>;
>
> Not a valid property.

This comes from the linux-imx tree [2]. but in mainline it is not
valid. So I will remove it.

[2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/pci/controller/dwc/pci-imx6.c?h=imx_5.4.70_2.3.0#n2436

> > +       reset-gpio = <&gpio1 9 GPIO_ACTIVE_LOW>;
> > +       clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>,
> > +                <&clk IMX8MQ_CLK_PCIE1_AUX>,
> > +                <&clk IMX8MQ_CLK_PCIE1_PHY>,
> > +                <&pcie0_refclk>;
> > +       clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +       ext_osc = <1>;
>
> Not a valid property.

This comes from the linux-imx tree [3]. but in mainline it is not
valid. So I will remove it.

[3] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/pci/controller/dwc/pci-imx6.c?h=imx_5.4.70_2.3.0#n2422

> > +/* Intel Ethernet Controller I210/I211 */
> > +&pcie1 {
> > +       clocks = <&clk IMX8MQ_CLK_PCIE2_ROOT>,
> > +                <&clk IMX8MQ_CLK_PCIE2_AUX>,
> > +                <&clk IMX8MQ_CLK_PCIE2_PHY>,
> > +                <&pcie1_refclk>;
> > +       clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus";
> > +       ext_osc = <1>;
>
> Not a valid property.

same as commented before.

Thank you for the review. I will prepare v4.


--
Heiko
Fabio Estevam March 3, 2021, 1 p.m. UTC | #6
Hi Heiko,

On Wed, Mar 3, 2021 at 9:54 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:

> > reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
>
> I used the same name as used on imx8mq-evk. Do you think a better name
> is the one you proposed?

Yes, the way I proposed is the preferred one. Thanks