diff mbox series

[1/1] dm: ddr: socfpga: don't assign values that are not used

Message ID 20210220094023.2920-1-xypron.glpk@gmx.de
State Accepted
Commit f0bbcdef1b7fdf3e41e942fef56ceb76f7f820ac
Delegated to: Tom Rini
Headers show
Series [1/1] dm: ddr: socfpga: don't assign values that are not used | expand

Commit Message

Heinrich Schuchardt Feb. 20, 2021, 9:40 a.m. UTC 
The values of left_edge[0] and right_edge[0] are overwritten before they
are used. Remove the superfluous assignments.

Fixes: 285b3cb939a8 ("dm: ddr: socfpga: fix gen5 ddr driver to not use bss")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/ddr/altera/sequencer.c | 7 -------
 1 file changed, 7 deletions(-)

--
2.30.0

Comments

Simon Glass Feb. 20, 2021, 11:54 a.m. UTC | #1 
On Sat, 20 Feb 2021 at 02:40, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The values of left_edge[0] and right_edge[0] are overwritten before they
> are used. Remove the superfluous assignments.
>
> Fixes: 285b3cb939a8 ("dm: ddr: socfpga: fix gen5 ddr driver to not use bss")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/ddr/altera/sequencer.c | 7 -------
>  1 file changed, 7 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Feb. 25, 2021, 1:31 p.m. UTC | #2 
On Sat, Feb 20, 2021 at 10:40:23AM +0100, Heinrich Schuchardt wrote:

> The values of left_edge[0] and right_edge[0] are overwritten before they
> are used. Remove the superfluous assignments.
> 
> Fixes: 285b3cb939a8 ("dm: ddr: socfpga: fix gen5 ddr driver to not use bss")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
index 2dbde49a9c..6b9b2e9094 100644
--- a/drivers/ddr/altera/sequencer.c
+++ b/drivers/ddr/altera/sequencer.c
@@ -3202,13 +3202,6 @@  rw_mgr_mem_calibrate_writes_center(struct socfpga_sdrseq *seq,
 	/* Centre DM */
 	debug_cond(DLEVEL >= 2, "%s:%d write_center: DM\n", __func__, __LINE__);

-	/*
-	 * Set the left and right edge of each bit to an illegal value.
-	 * Use (seq->iocfg->io_out1_delay_max + 1) as an illegal value.
-	 */
-	left_edge[0]  = seq->iocfg->io_out1_delay_max + 1;
-	right_edge[0] = seq->iocfg->io_out1_delay_max + 1;
-
 	/* Search for the/part of the window with DM shift. */
 	search_window(seq, 1, rank_bgn, write_group, &bgn_curr, &end_curr,
 		      &bgn_best, &end_best, &win_best, 0);