Message ID | 2417b7bc-0dad-64ce-c4a9-ed4d9851df44@baylibre.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
Series | [PULL,u-boot] Please pull u-boot-amlogic-20210222 | expand |
On Mon, Feb 22, 2021 at 03:30:36PM +0100, Neil Armstrong wrote: > Hi Tom, > > These changes adds support for reading the ADC key on the Khadas VIM3 & VIM3L, in the same > time it adds plumbing for ADC keys and a test for sandbox. > > The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/6461 > > Thanks, > Neil > > The following changes since commit 496f49464d90b564da5f1a2f4eecb5553e01edf9: > > Merge branch '2021-02-16-assorted-improvements' (2021-02-16 15:14:34 -0500) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20210222 > > for you to fetch changes up to 2d339efb1ff941705a770e93494427912689ce18: > > button: add udevice forward declaration (2021-02-22 11:07:57 +0100) > First up, I've applied this to u-boot/master, as there's some small problems, but I don't want to make you recreate the tag. That said, running ./scripts/checkpatch.pl -q --git on this shows that the ADC changes all add "treshold" fields, etc, and not "threshold" fields. A follow-up to fix this, before the misspelling propagates more would be appreciated. Thanks!
On 22/02/2021 21:03, Tom Rini wrote: > On Mon, Feb 22, 2021 at 03:30:36PM +0100, Neil Armstrong wrote: > >> Hi Tom, >> >> These changes adds support for reading the ADC key on the Khadas VIM3 & VIM3L, in the same >> time it adds plumbing for ADC keys and a test for sandbox. >> >> The CI job is at https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/pipelines/6461 >> >> Thanks, >> Neil >> >> The following changes since commit 496f49464d90b564da5f1a2f4eecb5553e01edf9: >> >> Merge branch '2021-02-16-assorted-improvements' (2021-02-16 15:14:34 -0500) >> >> are available in the Git repository at: >> >> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20210222 >> >> for you to fetch changes up to 2d339efb1ff941705a770e93494427912689ce18: >> >> button: add udevice forward declaration (2021-02-22 11:07:57 +0100) >> > > First up, I've applied this to u-boot/master, as there's some small > problems, but I don't want to make you recreate the tag. That said, > running ./scripts/checkpatch.pl -q --git on this shows that the ADC > changes all add "treshold" fields, etc, and not "threshold" fields. A > follow-up to fix this, before the misspelling propagates more would be > appreciated. Thanks! > Thanks for seeing this, I'll fixup ans resubmit ! Neil