diff mbox series

[1/1] buildman: 'Thread' object has no attribute 'isAlive'

Message ID 20210211110322.65282-1-xypron.glpk@gmx.de
State Accepted
Commit fd434f47d4d008d41f4ee2fe5cb94791f780395c
Delegated to: Simon Glass
Headers show
Series [1/1] buildman: 'Thread' object has no attribute 'isAlive' | expand

Commit Message

Heinrich Schuchardt Feb. 11, 2021, 11:03 a.m. UTC
The isAlive() method was deprecated in Python 3.8 and has been removed in
Python 3.9. See https://bugs.python.org/issue37804. Use is_alive() instead.

Since Python 2.6 is_alive() has been a synonym for isAlive(). So there
should be no problems for users using elder Python 3 versions.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 tools/buildman/builder.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.30.0

Comments

Simon Glass Feb. 13, 2021, 4:17 a.m. UTC | #1
On Thu, 11 Feb 2021 at 04:03, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The isAlive() method was deprecated in Python 3.8 and has been removed in
> Python 3.9. See https://bugs.python.org/issue37804. Use is_alive() instead.
>
> Since Python 2.6 is_alive() has been a synonym for isAlive(). So there
> should be no problems for users using elder Python 3 versions.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  tools/buildman/builder.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index c93946842a..6f6d759329 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -1691,7 +1691,7 @@  class Builder:
         term = threading.Thread(target=self.queue.join)
         term.setDaemon(True)
         term.start()
-        while term.isAlive():
+        while term.is_alive():
             term.join(100)

         # Wait until we have processed all output