| Message ID | cover.1613042245.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| Headers | show |
| Series | Extend regulator notification support | expand |
On Thu, 2021-02-11 at 14:35 +0200, Matti Vaittinen wrote: > Add DT property parsing code and setting callback for regulator > over/under > voltage, over-current and temperature error limits. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > drivers/regulator/core.c | 122 > +++++++++++++++++++++- > drivers/regulator/of_regulator.c | 58 ++++++++++ > drivers/regulator/qcom-labibb-regulator.c | 10 +- > drivers/regulator/stpmic1_regulator.c | 17 ++- > include/linux/regulator/driver.h | 41 +++++++- > include/linux/regulator/machine.h | 26 +++++ > 6 files changed, 267 insertions(+), 7 deletions(-) Just a note. I did somehow miss the qcom_spmi-regulator.c which also uses the .set_over_current_protection. I will include that file in next version if the idea is still seen worthy. Sorry for the incompleteness. Best Regards Matti Vaittinen
On Thu, 2021-02-11 at 14:35 +0200, Matti Vaittinen wrote: > Provide helper function for IC's implementing regulator notifications > when an IRQ fires. The helper also works for IRQs which can not be > acked. > Helper can be set to disable the IRQ at handler and then re-enabling > it > on delayed work later. The helper also adds > regulator_get_error_flags() > errors in cache for the duration of IRQ disabling. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > This patch has gone through only a very limited amount of testing. > All > reviews / suggestions / testing is highly appreciated. > /* SNIP */ > + > +static void dev_delayed_work_drop(struct device *dev, void *res) > +{ > + cancel_delayed_work_sync(*(struct delayed_work **)res); > +} > + > +int dev_delayed_work_autocancel(struct device *dev, struct > delayed_work *w, > + void (*worker)(struct work_struct > *work)) > +{ > + struct delayed_work **ptr; > + > + ptr = devres_alloc(dev_delayed_work_drop, sizeof(*ptr), > GFP_KERNEL); > + if (!ptr) > + return -ENOMEM; > + > + INIT_DELAYED_WORK(w, worker); > + *ptr = w; > + devres_add(dev, ptr); > + > + return 0; > +} > + I got mail from build-bot. Sparse warning. Bot suggested staticizing the dev_delayed_work_autocancel(). I should've been more careful. It how ever made me wonder if this would actually be worth exporting? There seems to be few drivers which need delayed wq and which implement .remove() just to call the cancel_delayed_work_sync(). I think this might help cleaning up those(?) Or am I completely off here? I just did: git grep -A15 remove |grep -B10 -A10 cancel_delayed_work_sync in drivers directory and spotted couple of candidates like watchdog/retu_wdt.c (should also use devm_watchdog_register_device) regulator/qcom_spmi-regulator.c power/supply/sbs-charger.c power/supply/sbs-battery.c power/supply/ltc2941-battery-gauge.c ... And no. I am not offering to go through _all_ drivers, but I guess I could go through at least few of them :) And sorry for noise if this has been suggested and rejected before - I didn't spot something like this from mail lists. (Maybe I am missing something?) Best Regards Matti Vaittinen -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. "non cogito me" dixit Rene Descarte, deinde evanescavit (Thanks for the translation Simon)
On Fri, Feb 12, 2021 at 09:33:44AM +0000, Vaittinen, Matti wrote: > There seems to be few drivers which need delayed wq and which implement > .remove() just to call the cancel_delayed_work_sync(). > I think this might help cleaning up those(?) Or am I completely off > here? I can see it being useful, yes.
On Thu, 2021-02-11 at 14:35 +0200, Matti Vaittinen wrote: > Provide helper function for IC's implementing regulator notifications > when an IRQ fires. The helper also works for IRQs which can not be > acked. > Helper can be set to disable the IRQ at handler and then re-enabling > it > on delayed work later. The helper also adds > regulator_get_error_flags() > errors in cache for the duration of IRQ disabling. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > This patch has gone through only a very limited amount of testing. > All > reviews / suggestions / testing is highly appreciated. > // Snip > + > +static void dev_delayed_work_drop(struct device *dev, void *res) > +{ > + cancel_delayed_work_sync(*(struct delayed_work **)res); > +} > + > +int dev_delayed_work_autocancel(struct device *dev, struct > delayed_work *w, > + void (*worker)(struct work_struct > *work)) > +{ > + struct delayed_work **ptr; > + > + ptr = devres_alloc(dev_delayed_work_drop, sizeof(*ptr), > GFP_KERNEL); > + if (!ptr) > + return -ENOMEM; > + > + INIT_DELAYED_WORK(w, worker); > + *ptr = w; > + devres_add(dev, ptr); > + > + return 0; > +} I sent this dev_delayed_work_autocancel() + few cleanup patches as own series. Discussion that series created made me realize that we don't want to force use of devm by hiding the WQ init here. We should introduce also non devm variant + manual cancellation routine for those who don't use devm to register rdevs. And as I see that Greg was strongly opposing the devm based delayed work cancellation - I guess that if we want to proceed with this one we'd better first implement the 'non devm' variant which uses manual wq cancellation + manual IRQ deregistering and use that cancellation to build a devm one... I'll try to cook v2 still this week. Best Regards Matti Vaittinen
Extend regulator notification support This is an RFC series for getting feedback on extending the regulator notification and error flag support. Initial discussion on the topic can be found here: https://lore.kernel.org/lkml/6046836e22b8252983f08d5621c35ececb97820d.camel@fi.rohmeurope.com/ This series is built on top of the: commit 7aa382cfe714 ("regulator: mt6315: Add support for MT6315 regulator") regulator tree for-5.12 branch + The BD9576MUF support patch series v8 which is not yet in-tree Here: https://lore.kernel.org/lkml/cover.1613031055.git.matti.vaittinen@fi.rohmeurope.com/ In a nutshell - the RFC adds: 1. WARNING level events/error flags. (Patch 2) Current regulator 'ERROR' event notifications for over/under voltage, over current and over temperature are used to indicate condition where monitored entity is so badly "off" that it actually indicates a hardware error which can not be recovered. The most typical hanling for that is believed to be a (graceful) system-shutdown. Here we add set of 'WARNING' level flags to allow sending notifications to consumers before things are 'that badly off' so that consumer drivers can implement recovery-actions. 2. Device-tree properties for specifying limit values. (Patches 1, 4) Add limits for above mentioned 'ERROR' and 'WARNING' levels (which send notifications to consumers) and also for a 'PROTECTION' level (which will be used to immediately shut-down the regulator(s) W/O informing consumer drivers. Typically implemented by hardware). Property parsing is implemented in regulator core which then calls callback operations for limit setting from the IC drivers. A warning is emitted if protection is requested by device tree but the underlying IC does not support configuring requested protection. 3. Helpers which can be registered by IC. (Patch 3) Target is to avoid implementing IRQ handling and IRQ storm protection in each IC driver. (Many of the ICs implementin these IRQs do not allow masking or acking the IRQ but keep the IRQ asserted for the whole duration of problem keeping the processor in IRQ handling loop). The helper was attempted to be done so it could be used to implement roughly same logic as is used in qcom-labibb regulator. This means amongst other things a safety shut-down if IC registers are not readable. Using these shut-down retry counters are optional. The idea is that the helper could be also used by simpler ICs which do not provide status register(s) which can be used to check if error is still active. ICs which do not have such status register can simply omit the 'renable' callback (and retry-counts etc) - and helper assumes the situation is Ok and re-enables IRQ after given time period. If problem persists the handler is ran again and another notification is sent - but at least the delay allows processor to avoid IRQ loop. Patch 6 takes this notification support in use at BD9576MUF. -- Matti Vaittinen (7): dt_bindings: Add protection limit properties regulator: add warning flags regulator: IRQ based event/error notification helpers regulator: add property parsing and callbacks to set protection limits dt-bindings: regulator: bd9576 add FET ON-resistance for OCW regulator: bd9576: Support error reporting regulator: bd9576: Fix the driver name in id table .../bindings/regulator/regulator.yaml | 82 ++ .../regulator/rohm,bd9576-regulator.yaml | 5 + drivers/regulator/Makefile | 2 +- drivers/regulator/bd9576-regulator.c | 1030 ++++++++++++++--- drivers/regulator/core.c | 146 ++- drivers/regulator/irq_helpers.c | 396 +++++++ drivers/regulator/of_regulator.c | 58 + drivers/regulator/qcom-labibb-regulator.c | 10 +- drivers/regulator/stpmic1_regulator.c | 17 +- include/linux/regulator/consumer.h | 14 + include/linux/regulator/driver.h | 170 ++- include/linux/regulator/machine.h | 26 + 12 files changed, 1816 insertions(+), 140 deletions(-) create mode 100644 drivers/regulator/irq_helpers.c