| Message ID | orble37rji.fsf@lxoliva.fsfla.org |
|---|---|
| State | New |
| Headers | show |
| Series | use -mfpu=neon for arm/simd/vmmla_1.c | expand |
On Jan 5, 2021, Alexandre Oliva <oliva@adacore.com> wrote: > So this patch adds -mfpu=auto to the test, overriding any implicit > flags with the fpu implied by the arch. > * gcc.target/arm/simd/vmmla_1.c: Pass -mfpu=auto. Ping? https://gcc.gnu.org/pipermail/gcc-patches/2021-January/562798.html (The subject is outdated; it is -mfpu=auto rather than =neon)
On Jan 13, 2021, Alexandre Oliva <oliva@adacore.com> wrote: > On Jan 5, 2021, Alexandre Oliva <oliva@adacore.com> wrote: >> So this patch adds -mfpu=auto to the test, overriding any implicit >> flags with the fpu implied by the arch. >> * gcc.target/arm/simd/vmmla_1.c: Pass -mfpu=auto. > Ping? > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/562798.html Ping?
> -----Original Message----- > From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of > Alexandre Oliva > Sent: 05 January 2021 07:49 > To: gcc-patches@gcc.gnu.org > Subject: use -mfpu=neon for arm/simd/vmmla_1.c > > > On some of our arm targets, we get various -mfpu flags implicitly or > explicitly passed to the compiler during test runs. The target > options pushed in arm_neon.h that affect vmmlaq_s32 set isa_bit_neon, > but the caller doesn't have that bit set, so arm_can_inline_p rejects > the attempt to inline it, and the test fails. > > An explicit -mfpu=neon would address the compile problem, but cause > the assembler to reject the generated code. > > So this patch adds -mfpu=auto to the test, overriding any implicit > flags with the fpu implied by the arch. > > Regstrapped on x86_64-linux-gnu, also tested on x-arm-wrs-vxworks7r2. > Ok to install? Ok. Aren't there more tests that have this problem? Thanks, Kyrill > > > for gcc/testsuite/ChangeLog > > * gcc.target/arm/simd/vmmla_1.c: Pass -mfpu=auto. > --- > gcc/testsuite/gcc.target/arm/simd/vmmla_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c > b/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c > index aeb4a359e3351..d33ebf361d436 100644 > --- a/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c > +++ b/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c > @@ -1,6 +1,6 @@ > /* { dg-do assemble } */ > /* { dg-require-effective-target arm_v8_2a_i8mm_ok } */ > -/* { dg-options "-save-temps -O2 -march=armv8.2-a+i8mm -mfloat- > abi=hard" } */ > +/* { dg-options "-save-temps -O2 -march=armv8.2-a+i8mm -mfpu=auto - > mfloat-abi=hard" } */ > > #include "arm_neon.h" > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
On Feb 9, 2021, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
> Ok. Aren't there more tests that have this problem?
Thanks. This was the only test that exhibited this problem.
diff --git a/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c b/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c index aeb4a359e3351..d33ebf361d436 100644 --- a/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c +++ b/gcc/testsuite/gcc.target/arm/simd/vmmla_1.c @@ -1,6 +1,6 @@ /* { dg-do assemble } */ /* { dg-require-effective-target arm_v8_2a_i8mm_ok } */ -/* { dg-options "-save-temps -O2 -march=armv8.2-a+i8mm -mfloat-abi=hard" } */ +/* { dg-options "-save-temps -O2 -march=armv8.2-a+i8mm -mfpu=auto -mfloat-abi=hard" } */ #include "arm_neon.h"