diff mbox series

wolfSSL: wolfSSL_use_PrivateKey_* correct return codes

Message ID 20210208083407.6213-1-juliusz@wolfssl.com
State Accepted
Headers show
Series wolfSSL: wolfSSL_use_PrivateKey_* correct return codes | expand

Commit Message

Juliusz Sosinowicz Feb. 8, 2021, 8:34 a.m. UTC 
The wolfSSL_use_PrivateKey_* APIs return 1 on success. 0 is also an error.

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
---
 src/crypto/tls_wolfssl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jouni Malinen Feb. 9, 2021, 8:03 p.m. UTC | #1 
On Mon, Feb 08, 2021 at 09:34:07AM +0100, Juliusz Sosinowicz wrote:
> The wolfSSL_use_PrivateKey_* APIs return 1 on success. 0 is also an error.

Thanks, applied.
diff mbox series

Patch

diff --git a/src/crypto/tls_wolfssl.c b/src/crypto/tls_wolfssl.c
index ea8f7063b..cf482bfc3 100644
--- a/src/crypto/tls_wolfssl.c
+++ b/src/crypto/tls_wolfssl.c
@@ -534,7 +534,7 @@  static int tls_connection_private_key(void *tls_ctx,
 	if (private_key_blob) {
 		if (wolfSSL_use_PrivateKey_buffer(conn->ssl,
 						  private_key_blob, blob_len,
-						  SSL_FILETYPE_ASN1) < 0) {
+						  SSL_FILETYPE_ASN1) <= 0) {
 			wpa_printf(MSG_INFO,
 				   "SSL: use private DER blob failed");
 		} else {
@@ -545,11 +545,11 @@  static int tls_connection_private_key(void *tls_ctx,
 
 	if (!ok && private_key) {
 		if (wolfSSL_use_PrivateKey_file(conn->ssl, private_key,
-						SSL_FILETYPE_PEM) < 0) {
+						SSL_FILETYPE_PEM) <= 0) {
 			wpa_printf(MSG_INFO,
 				   "SSL: use private key PEM file failed");
 			if (wolfSSL_use_PrivateKey_file(conn->ssl, private_key,
-							SSL_FILETYPE_ASN1) < 0)
+							SSL_FILETYPE_ASN1) <= 0)
 			{
 				wpa_printf(MSG_INFO,
 					   "SSL: use private key DER file failed");