| Message ID | 20210202015452.98002-1-sam@mendozajonas.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/busybox: Fix check for IPv6 default route in udhcpc | expand |
>>>>> "Samuel" == Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: > The check for a default route is inverted, causing the script to wait > for the timeout even when a default IPv6 route is available. Fix this up > so that it exits early as expected. > Reported-by: Bhattiprolu RaviKumar <ravikumar.bhattiprolu@gmail.com> > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> Committed, thanks.
>>>>> "Samuel" == Samuel Mendoza-Jonas <sam@mendozajonas.com> writes: > The check for a default route is inverted, causing the script to wait > for the timeout even when a default IPv6 route is available. Fix this up > so that it exits early as expected. > Reported-by: Bhattiprolu RaviKumar <ravikumar.bhattiprolu@gmail.com> > Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> Committed to 2020.02.x and 2020.11.x, thanks.
diff --git a/package/busybox/udhcpc.script b/package/busybox/udhcpc.script index ec4d9f6185..c73ad6c2ef 100755 --- a/package/busybox/udhcpc.script +++ b/package/busybox/udhcpc.script @@ -18,7 +18,7 @@ fi wait_for_ipv6_default_route() { printf "Waiting for IPv6 default route to appear" while [ $IF_WAIT_DELAY -gt 0 ]; do - if [ -z "$(ip -6 route list | grep default)" ]; then + if ip -6 route list | grep -q default; then printf "\n" return fi
The check for a default route is inverted, causing the script to wait for the timeout even when a default IPv6 route is available. Fix this up so that it exits early as expected. Reported-by: Bhattiprolu RaviKumar <ravikumar.bhattiprolu@gmail.com> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com> --- package/busybox/udhcpc.script | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)