diff mbox series

[ovs-dev,v13,4/4] ovn-northd: Add configuration option for parallel lflow build

Message ID 20210129112157.12450-4-anton.ivanov@cambridgegreys.com
State Changes Requested
Headers show
Series [ovs-dev,v13,1/4] ovn-libs: Add support for parallel processing | expand

Commit Message

Anton Ivanov Jan. 29, 2021, 11:21 a.m. UTC 
From: Anton Ivanov <anton.ivanov@cambridgegreys.com>

Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
---
 northd/ovn-northd.c |  3 +++
 ovn-nb.xml          | 13 +++++++++++++
 2 files changed, 16 insertions(+)

Comments

0-day Robot Jan. 29, 2021, 12:15 p.m. UTC | #1 
Bleep bloop.  Greetings Anton Ivanov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
error: sha1 information is lacking or useless (northd/ovn-northd.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 ovn-northd: Add configuration option for parallel lflow build
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 992292562..069240a0b 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -12842,6 +12842,9 @@  ovnnb_db_run(struct northd_context *ctx,
     northd_probe_interval_nb = get_probe_interval(ovnnb_db, nb);
     northd_probe_interval_sb = get_probe_interval(ovnsb_db, nb);
 
+    use_parallel_build = smap_get_bool(&nb->options,
+                                          "use_parallel_build", false) &&
+                          ovn_can_parallelize_hashes();
     use_logical_dp_groups = smap_get_bool(&nb->options,
                                           "use_logical_dp_groups", false);
     controller_event_en = smap_get_bool(&nb->options,
diff --git a/ovn-nb.xml b/ovn-nb.xml
index c2c58d84a..ea9da424f 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -212,6 +212,19 @@ 
           The default value is <code>false</code>.
         </p>
       </column>
+      <column name="options" key="use_parallel_build">
+        <p>
+          If set to <code>true</code>, <code>ovn-northd</code> will attempt
+          to compute logical flows in parallel.
+        </p>
+        <p>
+          Parallel computation is enabled only if the system has 4 or more
+          cores/threads available to be used by ovn-northd.
+        </p>
+        <p>
+          The default value is <code>false</code>.
+        </p>
+      </column>
 
       <column name="options" key="ignore_lsp_down">
         <p>