| Message ID | 20210114180415.404418-4-angelogioacchino.delregno@somainline.org |
|---|---|
| State | Needs Review / ACK |
| Headers | show |
| Series | QCOM QUP I2C - Add noise rejection, convert to YAML | expand |
On Thu, 14 Jan 2021 19:04:15 +0100, AngeloGioacchino Del Regno wrote: > Document the new noise rejection properties "qcom,noise-reject-sda" > and "qcom,noise-reject-scl". > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > .../devicetree/bindings/i2c/qcom,i2c-qup.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
> + qcom,noise-reject-sda: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Noise rejection level for the SDA line. > + minimum: 0 > + maximum: 3 > + default: 0 What does this u32 describe? I wonder if we can introduce a generic property instead of a vendor-specific one.
Il 28/01/21 10:13, Wolfram Sang ha scritto: > >> + qcom,noise-reject-sda: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Noise rejection level for the SDA line. >> + minimum: 0 >> + maximum: 3 >> + default: 0 > > What does this u32 describe? I wonder if we can introduce a generic > property instead of a vendor-specific one. > Describes a "noise rejection level"... zero is disabled, 1-2-3 are min-med-high. That's what the hardware accepts. Also, there's no "real" documentation on this, so it wasn't possible to map it to any real measurement unit as well...
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml index c5c7db3ac2a6..3f14dd65c6b9 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml @@ -58,6 +58,20 @@ properties: '#size-cells': const: 0 + qcom,noise-reject-sda: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Noise rejection level for the SDA line. + minimum: 0 + maximum: 3 + default: 0 + + qcom,noise-reject-scl: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Noise rejection level for the SCL line. + minimum: 0 + maximum: 3 + default: 0 + required: - compatible - clocks
Document the new noise rejection properties "qcom,noise-reject-sda" and "qcom,noise-reject-scl". Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- .../devicetree/bindings/i2c/qcom,i2c-qup.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)