| Message ID | 20210124074127.50692-1-thuth@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | virtio-serial: Remove superfluous serial-* words | expand |
On 24/01/2021 18:41, Thomas Huth wrote: > These likely were a blind copy-n-paste from hvterm.fs, but they > simply do not make any sense in virtio-serial.fs. The hvterm.fs is > always included from OF.fs, so the serial-* words are globally there. > virtio-serial.fs is only used within the virtio-serial device tree > nodes, to adding the serial-* words there is just superfluous. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Hm looks like it. Still works with the patch so thanks, applied. How did you find it? Or in other words why on earth you looked there? :) > --- > board-qemu/slof/virtio-serial.fs | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/board-qemu/slof/virtio-serial.fs b/board-qemu/slof/virtio-serial.fs > index 06bfe76..82868e2 100644 > --- a/board-qemu/slof/virtio-serial.fs > +++ b/board-qemu/slof/virtio-serial.fs > @@ -90,7 +90,3 @@ virtiodev virtio-serial-init drop > ; > setup-alias > > -\ Override serial methods to make term-io.fs happy > -: serial-emit virtio-serial-term-emit ; > -: serial-key? virtio-serial-term-key? ; > -: serial-key virtio-serial-term-key ; >
On 27/01/2021 11.25, Alexey Kardashevskiy wrote: > > > On 24/01/2021 18:41, Thomas Huth wrote: >> These likely were a blind copy-n-paste from hvterm.fs, but they >> simply do not make any sense in virtio-serial.fs. The hvterm.fs is >> always included from OF.fs, so the serial-* words are globally there. >> virtio-serial.fs is only used within the virtio-serial device tree >> nodes, to adding the serial-* words there is just superfluous. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > Hm looks like it. Still works with the patch so thanks, applied. > > How did you find it? Or in other words why on earth you looked there? :) I've noticed it some years ago already, put an item in my todo list to have a closer look later, forgot about it, and now just came across the item in my todo list again. And finally decided to get this item removed from my todo list :-) Thomas
diff --git a/board-qemu/slof/virtio-serial.fs b/board-qemu/slof/virtio-serial.fs index 06bfe76..82868e2 100644 --- a/board-qemu/slof/virtio-serial.fs +++ b/board-qemu/slof/virtio-serial.fs @@ -90,7 +90,3 @@ virtiodev virtio-serial-init drop ; setup-alias -\ Override serial methods to make term-io.fs happy -: serial-emit virtio-serial-term-emit ; -: serial-key? virtio-serial-term-key? ; -: serial-key virtio-serial-term-key ;
These likely were a blind copy-n-paste from hvterm.fs, but they simply do not make any sense in virtio-serial.fs. The hvterm.fs is always included from OF.fs, so the serial-* words are globally there. virtio-serial.fs is only used within the virtio-serial device tree nodes, to adding the serial-* words there is just superfluous. Signed-off-by: Thomas Huth <thuth@redhat.com> --- board-qemu/slof/virtio-serial.fs | 4 ---- 1 file changed, 4 deletions(-)