| Message ID | 20210120203756.58175-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 12218c1ff41befedd78ed8cfa902f2cc25d05c88 |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [1/1] cmd: CMD_ACPI depends on ACPIGEN | expand |
On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote: > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and > CONFIG_ACPIGEN=n fails with > > ld.bfd: cmd/built-in.o: in function `do_acpi_items': > cmd/acpi.c:162: undefined reference to `acpi_dump_items' > > Add the missing configuration dependency. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > cmd/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 0625ee4050..928a2a0a2d 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -84,7 +84,8 @@ menu "Info commands" > > config CMD_ACPI > bool "acpi" > - default y if ACPIGEN > + depends on ACPIGEN > + default y Shouldn't be rather default ACPIGEN ? > help > List and dump ACPI tables. ACPI (Advanced Configuration and Power > Interface) is used mostly on x86 for providing information to the > -- > 2.29.2 >
On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote: > > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and > > CONFIG_ACPIGEN=n fails with > > > > ld.bfd: cmd/built-in.o: in function `do_acpi_items': > > cmd/acpi.c:162: undefined reference to `acpi_dump_items' > > > > Add the missing configuration dependency. ... > > config CMD_ACPI > > bool "acpi" > > - default y if ACPIGEN > > + depends on ACPIGEN > > + default y > > Shouldn't be rather > > default ACPIGEN > > ? Actually it makes no difference...
Am 20. Januar 2021 21:47:45 MEZ schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: >On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote: >> > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and >> > CONFIG_ACPIGEN=n fails with >> > >> > ld.bfd: cmd/built-in.o: in function `do_acpi_items': >> > cmd/acpi.c:162: undefined reference to `acpi_dump_items' >> > >> > Add the missing configuration dependency. > >... > >> > config CMD_ACPI >> > bool "acpi" >> > - default y if ACPIGEN >> > + depends on ACPIGEN >> > + default y >> >> Shouldn't be rather >> >> default ACPIGEN >> >> ? Thanks for reviewing. You cannot drop the depends line. If you only want to change the last line only, 'default y' is easier to read and matches the style of the rest of our code. Best regards Heinrich > >Actually it makes no difference...
On Thu, Jan 21, 2021 at 4:38 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and > CONFIG_ACPIGEN=n fails with > > ld.bfd: cmd/built-in.o: in function `do_acpi_items': > cmd/acpi.c:162: undefined reference to `acpi_dump_items' > > Add the missing configuration dependency. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > cmd/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Jan 21, 2021 at 11:13 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Thu, Jan 21, 2021 at 4:38 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and > > CONFIG_ACPIGEN=n fails with > > > > ld.bfd: cmd/built-in.o: in function `do_acpi_items': > > cmd/acpi.c:162: undefined reference to `acpi_dump_items' > > > > Add the missing configuration dependency. > > > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > --- > > cmd/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index 0625ee4050..928a2a0a2d 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -84,7 +84,8 @@ menu "Info commands" config CMD_ACPI bool "acpi" - default y if ACPIGEN + depends on ACPIGEN + default y help List and dump ACPI tables. ACPI (Advanced Configuration and Power Interface) is used mostly on x86 for providing information to the
Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and CONFIG_ACPIGEN=n fails with ld.bfd: cmd/built-in.o: in function `do_acpi_items': cmd/acpi.c:162: undefined reference to `acpi_dump_items' Add the missing configuration dependency. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- cmd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.29.2