diff mbox series

cmd: disk: Remove fit_print_contents API

Message ID 1610128558-30159-1-git-send-email-rahasij@linux.microsoft.com
State Accepted
Commit ad80a8d0877922db95fd0410314504c840d9d850
Delegated to: Tom Rini
Headers show
Series cmd: disk: Remove fit_print_contents API | expand

Commit Message

Ravik Hasija Jan. 8, 2021, 5:55 p.m. UTC 
fit_print_contents prints similar fit information as printed in bootm stages.
Removing this API reduces redundancy & provides improvement in boottime.

Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
---

 cmd/disk.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass Jan. 13, 2021, 4:10 p.m. UTC | #1 
On Fri, 8 Jan 2021 at 10:56, Ravik Hasija <rahasij@linux.microsoft.com> wrote:
>
> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
>
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> ---
>
>  cmd/disk.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 18, 2021, 1:03 p.m. UTC | #2 
On Fri, Jan 08, 2021 at 09:55:58AM -0800, Ravik Hasija wrote:

> fit_print_contents prints similar fit information as printed in bootm stages.
> Removing this API reduces redundancy & provides improvement in boottime.
> 
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/disk.c b/cmd/disk.c
index 8060e753eb..0bc3808dfe 100644
--- a/cmd/disk.c
+++ b/cmd/disk.c
@@ -120,7 +120,6 @@  int common_diskboot(struct cmd_tbl *cmdtp, const char *intf, int argc,
 			return 1;
 		}
 		bootstage_mark(BOOTSTAGE_ID_IDE_FIT_READ_OK);
-		fit_print_contents(fit_hdr);
 	}
 #endif