| Message ID | 20201228165627.246425-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 3e50deece014bc6e3dc57e85dc2b903630f7f69a |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/1] lib: aes: build failure with DEBUG=1 | expand |
On Mon, 28 Dec 2020 at 09:56, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Building fails with DEBUG=1: > > lib/aes.c: In function ‘debug_print_vector’: > lib/aes.c:622:45: error: > cast from pointer to integer of different size > [-Werror=pointer-to-int-cast] > 622 | printf("%s [%d] @0x%08x", name, num_bytes, (u32)data); > > Pointers can only be cast to (uintptr_t). But anyway we have > %p for printing pointers. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > lib/aes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, Dec 28, 2020 at 05:56:27PM +0100, Heinrich Schuchardt wrote: > Building fails with DEBUG=1: > > lib/aes.c: In function ‘debug_print_vector’: > lib/aes.c:622:45: error: > cast from pointer to integer of different size > [-Werror=pointer-to-int-cast] > 622 | printf("%s [%d] @0x%08x", name, num_bytes, (u32)data); > > Pointers can only be cast to (uintptr_t). But anyway we have > %p for printing pointers. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/lib/aes.c b/lib/aes.c index c998aecb3c..05ec235702 100644 --- a/lib/aes.c +++ b/lib/aes.c @@ -619,7 +619,7 @@ void aes_decrypt(u32 key_len, u8 *in, u8 *expkey, u8 *out) static void debug_print_vector(char *name, u32 num_bytes, u8 *data) { #ifdef DEBUG - printf("%s [%d] @0x%08x", name, num_bytes, (u32)data); + printf("%s [%d] @0x%p", name, num_bytes, data); print_buffer(0, data, 1, num_bytes, 16); #endif }
Building fails with DEBUG=1: lib/aes.c: In function ‘debug_print_vector’: lib/aes.c:622:45: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 622 | printf("%s [%d] @0x%08x", name, num_bytes, (u32)data); Pointers can only be cast to (uintptr_t). But anyway we have %p for printing pointers. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- lib/aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2