diff mbox series

iperf3: move over to packages.git

Message ID 20210115200337.1500054-1-mail@aparcar.org
State Accepted
Delegated to: Paul Spooren
Headers show
Series iperf3: move over to packages.git | expand

Commit Message

Paul Spooren Jan. 15, 2021, 8:03 p.m. UTC 
That package is not required for building OpenWrt so the maintenance
should happen over at packages.git.

CC: Felix Fietkau <nbd@nbd.name>

Signed-off-by: Paul Spooren <mail@aparcar.org>
---
 package/network/utils/iperf3/Makefile | 83 ---------------------------
 1 file changed, 83 deletions(-)
 delete mode 100644 package/network/utils/iperf3/Makefile

Comments

Rosen Penev Jan. 18, 2021, 1:53 a.m. UTC | #1 
On Fri, Jan 15, 2021 at 12:08 PM Paul Spooren <mail@aparcar.org> wrote:
>
> That package is not required for building OpenWrt so the maintenance
> should happen over at packages.git.
Sounds about right. I think most people prefer to use iperf anyway...
>
> CC: Felix Fietkau <nbd@nbd.name>
>
> Signed-off-by: Paul Spooren <mail@aparcar.org>
Reviewed-by: Rosen Penev <rosenp@gmail.com
> ---
>  package/network/utils/iperf3/Makefile | 83 ---------------------------
>  1 file changed, 83 deletions(-)
>  delete mode 100644 package/network/utils/iperf3/Makefile
>
> diff --git a/package/network/utils/iperf3/Makefile b/package/network/utils/iperf3/Makefile
> deleted file mode 100644
> index 6f90bc9221..0000000000
> --- a/package/network/utils/iperf3/Makefile
> +++ /dev/null
> @@ -1,83 +0,0 @@
> -#
> -# Copyright (C) 2007-2010 OpenWrt.org
> -#
> -# This is free software, licensed under the GNU General Public License v2.
> -# See /LICENSE for more information.
> -#
> -
> -include $(TOPDIR)/rules.mk
> -
> -PKG_NAME:=iperf
> -PKG_VERSION:=3.9
> -PKG_RELEASE:=1
> -
> -PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> -PKG_SOURCE_URL:=https://downloads.es.net/pub/iperf
> -PKG_HASH:=24b63a26382325f759f11d421779a937b63ca1bc17c44587d2fcfedab60ac038
> -
> -PKG_MAINTAINER:=Felix Fietkau <nbd@nbd.name>
> -PKG_LICENSE:=BSD-3-Clause
> -
> -PKG_BUILD_PARALLEL:=1
> -PKG_INSTALL:=1
> -
> -PKG_FIXUP:=autoreconf
> -
> -include $(INCLUDE_DIR)/package.mk
> -
> -DISABLE_NLS:=
> -
> -define Package/iperf3/default
> -  SECTION:=net
> -  CATEGORY:=Network
> -  TITLE:=Internet Protocol bandwidth measuring tool
> -  URL:=https://github.com/esnet/iperf
> -endef
> -
> -define Package/iperf3
> -$(call Package/iperf3/default)
> -  VARIANT:=nossl
> -endef
> -
> -define Package/iperf3-ssl
> -$(call Package/iperf3/default)
> -  TITLE+= with iperf_auth support
> -  VARIANT:=ssl
> -  DEPENDS:= +libopenssl
> -endef
> -
> -TARGET_CFLAGS += -D_GNU_SOURCE
> -CONFIGURE_ARGS += --disable-shared
> -
> -ifeq ($(BUILD_VARIANT),ssl)
> -       CONFIGURE_ARGS += --with-openssl="$(STAGING_DIR)/usr"
> -else
> -       CONFIGURE_ARGS += --without-openssl
> -endif
> -
> -MAKE_FLAGS += noinst_PROGRAMS=
> -
> -define Package/iperf3/description
> - Iperf is a modern alternative for measuring TCP and UDP bandwidth
> - performance, allowing the tuning of various parameters and
> - characteristics.
> -endef
> -
> -# autoreconf fails if the README file isn't present
> -define Build/Prepare
> -       $(call Build/Prepare/Default)
> -       touch $(PKG_BUILD_DIR)/README
> -endef
> -
> -define Package/iperf3/install
> -       $(INSTALL_DIR) $(1)/usr/bin
> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
> -endef
> -
> -define Package/iperf3-ssl/install
> -       $(INSTALL_DIR) $(1)/usr/bin
> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
> -endef
> -
> -$(eval $(call BuildPackage,iperf3))
> -$(eval $(call BuildPackage,iperf3-ssl))
> --
> 2.29.2
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Florian Eckert Jan. 18, 2021, 7:05 a.m. UTC | #2 
>> That package is not required for building OpenWrt so the maintenance
>> should happen over at packages.git.
> Sounds about right. I think most people prefer to use iperf anyway...

But then I would also move the iperf package to the package feed.

>> 
>> CC: Felix Fietkau <nbd@nbd.name>
>> 
>> Signed-off-by: Paul Spooren <mail@aparcar.org>
> Reviewed-by: Rosen Penev <rosenp@gmail.com
Reviewed-by: Florian Eckert <fe@dev.tdt.de

>> ---
>>  package/network/utils/iperf3/Makefile | 83 
>> ---------------------------
>>  1 file changed, 83 deletions(-)
>>  delete mode 100644 package/network/utils/iperf3/Makefile
>> 
>> diff --git a/package/network/utils/iperf3/Makefile 
>> b/package/network/utils/iperf3/Makefile
>> deleted file mode 100644
>> index 6f90bc9221..0000000000
>> --- a/package/network/utils/iperf3/Makefile
>> +++ /dev/null
>> @@ -1,83 +0,0 @@
>> -#
>> -# Copyright (C) 2007-2010 OpenWrt.org
>> -#
>> -# This is free software, licensed under the GNU General Public 
>> License v2.
>> -# See /LICENSE for more information.
>> -#
>> -
>> -include $(TOPDIR)/rules.mk
>> -
>> -PKG_NAME:=iperf
>> -PKG_VERSION:=3.9
>> -PKG_RELEASE:=1
>> -
>> -PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>> -PKG_SOURCE_URL:=https://downloads.es.net/pub/iperf
>> -PKG_HASH:=24b63a26382325f759f11d421779a937b63ca1bc17c44587d2fcfedab60ac038
>> -
>> -PKG_MAINTAINER:=Felix Fietkau <nbd@nbd.name>
>> -PKG_LICENSE:=BSD-3-Clause
>> -
>> -PKG_BUILD_PARALLEL:=1
>> -PKG_INSTALL:=1
>> -
>> -PKG_FIXUP:=autoreconf
>> -
>> -include $(INCLUDE_DIR)/package.mk
>> -
>> -DISABLE_NLS:=
>> -
>> -define Package/iperf3/default
>> -  SECTION:=net
>> -  CATEGORY:=Network
>> -  TITLE:=Internet Protocol bandwidth measuring tool
>> -  URL:=https://github.com/esnet/iperf
>> -endef
>> -
>> -define Package/iperf3
>> -$(call Package/iperf3/default)
>> -  VARIANT:=nossl
>> -endef
>> -
>> -define Package/iperf3-ssl
>> -$(call Package/iperf3/default)
>> -  TITLE+= with iperf_auth support
>> -  VARIANT:=ssl
>> -  DEPENDS:= +libopenssl
>> -endef
>> -
>> -TARGET_CFLAGS += -D_GNU_SOURCE
>> -CONFIGURE_ARGS += --disable-shared
>> -
>> -ifeq ($(BUILD_VARIANT),ssl)
>> -       CONFIGURE_ARGS += --with-openssl="$(STAGING_DIR)/usr"
>> -else
>> -       CONFIGURE_ARGS += --without-openssl
>> -endif
>> -
>> -MAKE_FLAGS += noinst_PROGRAMS=
>> -
>> -define Package/iperf3/description
>> - Iperf is a modern alternative for measuring TCP and UDP bandwidth
>> - performance, allowing the tuning of various parameters and
>> - characteristics.
>> -endef
>> -
>> -# autoreconf fails if the README file isn't present
>> -define Build/Prepare
>> -       $(call Build/Prepare/Default)
>> -       touch $(PKG_BUILD_DIR)/README
>> -endef
>> -
>> -define Package/iperf3/install
>> -       $(INSTALL_DIR) $(1)/usr/bin
>> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
>> -endef
>> -
>> -define Package/iperf3-ssl/install
>> -       $(INSTALL_DIR) $(1)/usr/bin
>> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
>> -endef
>> -
>> -$(eval $(call BuildPackage,iperf3))
>> -$(eval $(call BuildPackage,iperf3-ssl))
>> --
>> 2.29.2
>> 
>> 
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Paul Spooren Jan. 18, 2021, 8:16 a.m. UTC | #3 
On Mo, Jan 18, 2021 at 08:05, Florian Eckert <fe@dev.tdt.de> wrote:
> 
> 
>>> That package is not required for building OpenWrt so the maintenance
>>> should happen over at packages.git.
>> Sounds about right. I think most people prefer to use iperf anyway...
> 
> But then I would also move the iperf package to the package feed.

Agree, patch sent.

> 
>>> 
>>> CC: Felix Fietkau <nbd@nbd.name>
>>> 
>>> Signed-off-by: Paul Spooren <mail@aparcar.org>
>> Reviewed-by: Rosen Penev <rosenp@gmail.com
> Reviewed-by: Florian Eckert <fe@dev.tdt.de
> 
>>> ---
>>>  package/network/utils/iperf3/Makefile | 83 
>>> ---------------------------
>>>  1 file changed, 83 deletions(-)
>>>  delete mode 100644 package/network/utils/iperf3/Makefile
>>> 
>>> diff --git a/package/network/utils/iperf3/Makefile 
>>> b/package/network/utils/iperf3/Makefile
>>> deleted file mode 100644
>>> index 6f90bc9221..0000000000
>>> --- a/package/network/utils/iperf3/Makefile
>>> +++ /dev/null
>>> @@ -1,83 +0,0 @@
>>> -#
>>> -# Copyright (C) 2007-2010 OpenWrt.org
>>> -#
>>> -# This is free software, licensed under the GNU General Public 
>>> License v2.
>>> -# See /LICENSE for more information.
>>> -#
>>> -
>>> -include $(TOPDIR)/rules.mk
>>> -
>>> -PKG_NAME:=iperf
>>> -PKG_VERSION:=3.9
>>> -PKG_RELEASE:=1
>>> -
>>> -PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>>> -PKG_SOURCE_URL:=https://downloads.es.net/pub/iperf
>>> -PKG_HASH:=24b63a26382325f759f11d421779a937b63ca1bc17c44587d2fcfedab60ac038
>>> -
>>> -PKG_MAINTAINER:=Felix Fietkau <nbd@nbd.name>
>>> -PKG_LICENSE:=BSD-3-Clause
>>> -
>>> -PKG_BUILD_PARALLEL:=1
>>> -PKG_INSTALL:=1
>>> -
>>> -PKG_FIXUP:=autoreconf
>>> -
>>> -include $(INCLUDE_DIR)/package.mk
>>> -
>>> -DISABLE_NLS:=
>>> -
>>> -define Package/iperf3/default
>>> -  SECTION:=net
>>> -  CATEGORY:=Network
>>> -  TITLE:=Internet Protocol bandwidth measuring tool
>>> -  URL:=https://github.com/esnet/iperf
>>> -endef
>>> -
>>> -define Package/iperf3
>>> -$(call Package/iperf3/default)
>>> -  VARIANT:=nossl
>>> -endef
>>> -
>>> -define Package/iperf3-ssl
>>> -$(call Package/iperf3/default)
>>> -  TITLE+= with iperf_auth support
>>> -  VARIANT:=ssl
>>> -  DEPENDS:= +libopenssl
>>> -endef
>>> -
>>> -TARGET_CFLAGS += -D_GNU_SOURCE
>>> -CONFIGURE_ARGS += --disable-shared
>>> -
>>> -ifeq ($(BUILD_VARIANT),ssl)
>>> -       CONFIGURE_ARGS += --with-openssl="$(STAGING_DIR)/usr"
>>> -else
>>> -       CONFIGURE_ARGS += --without-openssl
>>> -endif
>>> -
>>> -MAKE_FLAGS += noinst_PROGRAMS=
>>> -
>>> -define Package/iperf3/description
>>> - Iperf is a modern alternative for measuring TCP and UDP bandwidth
>>> - performance, allowing the tuning of various parameters and
>>> - characteristics.
>>> -endef
>>> -
>>> -# autoreconf fails if the README file isn't present
>>> -define Build/Prepare
>>> -       $(call Build/Prepare/Default)
>>> -       touch $(PKG_BUILD_DIR)/README
>>> -endef
>>> -
>>> -define Package/iperf3/install
>>> -       $(INSTALL_DIR) $(1)/usr/bin
>>> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 
>>> $(1)/usr/bin/
>>> -endef
>>> -
>>> -define Package/iperf3-ssl/install
>>> -       $(INSTALL_DIR) $(1)/usr/bin
>>> -       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 
>>> $(1)/usr/bin/
>>> -endef
>>> -
>>> -$(eval $(call BuildPackage,iperf3))
>>> -$(eval $(call BuildPackage,iperf3-ssl))
>>> --
>>> 2.29.2
>>> 
>>> 
>>> _______________________________________________
>>> openwrt-devel mailing list
>>> openwrt-devel@lists.openwrt.org
>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>> 
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/package/network/utils/iperf3/Makefile b/package/network/utils/iperf3/Makefile
deleted file mode 100644
index 6f90bc9221..0000000000
--- a/package/network/utils/iperf3/Makefile
+++ /dev/null
@@ -1,83 +0,0 @@ 
-#
-# Copyright (C) 2007-2010 OpenWrt.org
-#
-# This is free software, licensed under the GNU General Public License v2.
-# See /LICENSE for more information.
-#
-
-include $(TOPDIR)/rules.mk
-
-PKG_NAME:=iperf
-PKG_VERSION:=3.9
-PKG_RELEASE:=1
-
-PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
-PKG_SOURCE_URL:=https://downloads.es.net/pub/iperf
-PKG_HASH:=24b63a26382325f759f11d421779a937b63ca1bc17c44587d2fcfedab60ac038
-
-PKG_MAINTAINER:=Felix Fietkau <nbd@nbd.name>
-PKG_LICENSE:=BSD-3-Clause
-
-PKG_BUILD_PARALLEL:=1
-PKG_INSTALL:=1
-
-PKG_FIXUP:=autoreconf
-
-include $(INCLUDE_DIR)/package.mk
-
-DISABLE_NLS:=
-
-define Package/iperf3/default
-  SECTION:=net
-  CATEGORY:=Network
-  TITLE:=Internet Protocol bandwidth measuring tool
-  URL:=https://github.com/esnet/iperf
-endef
-
-define Package/iperf3
-$(call Package/iperf3/default)
-  VARIANT:=nossl
-endef
-
-define Package/iperf3-ssl
-$(call Package/iperf3/default)
-  TITLE+= with iperf_auth support
-  VARIANT:=ssl
-  DEPENDS:= +libopenssl
-endef
-
-TARGET_CFLAGS += -D_GNU_SOURCE
-CONFIGURE_ARGS += --disable-shared
-
-ifeq ($(BUILD_VARIANT),ssl)
-	CONFIGURE_ARGS += --with-openssl="$(STAGING_DIR)/usr"
-else
-	CONFIGURE_ARGS += --without-openssl
-endif
-
-MAKE_FLAGS += noinst_PROGRAMS=
-
-define Package/iperf3/description
- Iperf is a modern alternative for measuring TCP and UDP bandwidth
- performance, allowing the tuning of various parameters and
- characteristics.
-endef
-
-# autoreconf fails if the README file isn't present
-define Build/Prepare
-	$(call Build/Prepare/Default)
-	touch $(PKG_BUILD_DIR)/README
-endef
-
-define Package/iperf3/install
-	$(INSTALL_DIR) $(1)/usr/bin
-	$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
-endef
-
-define Package/iperf3-ssl/install
-	$(INSTALL_DIR) $(1)/usr/bin
-	$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
-endef
-
-$(eval $(call BuildPackage,iperf3))
-$(eval $(call BuildPackage,iperf3-ssl))