| Message ID | 20210111091353.6978-1-judge.packham@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/coremark-pro: fix build without threads | expand |
On Mon, 11 Jan 2021 22:13:53 +1300 Chris Packham <judge.packham@gmail.com> wrote: > Coremark-pro requires threads so add a depends on > BR2_TOOLCHAIN_HAS_THREADS. > > Fixes: > - http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/ > > Signed-off-by: Chris Packham <judge.packham@gmail.com> > --- > package/coremark-pro/Config.in | 5 +++++ > 1 file changed, 5 insertions(+) I've adjusted the commit title, but this commit doesn't really "fix build without threads", it rather adds a dependency on threads :-) Applied with this minor change. Thanks! Thomas
On Tue, Jan 12, 2021, 10:22 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > On Mon, 11 Jan 2021 22:13:53 +1300 > Chris Packham <judge.packham@gmail.com> wrote: > > > Coremark-pro requires threads so add a depends on > > BR2_TOOLCHAIN_HAS_THREADS. > > > > Fixes: > > - > http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/ > > > > Signed-off-by: Chris Packham <judge.packham@gmail.com> > > --- > > package/coremark-pro/Config.in | 5 +++++ > > 1 file changed, 5 insertions(+) > > I've adjusted the commit title, but this commit doesn't really "fix > build without threads", it rather adds a dependency on threads :-) > Thanks. I did struggle to come up with a sensible commit message so ended up copying the last commit that did something similar. > Applied with this minor change. Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
diff --git a/package/coremark-pro/Config.in b/package/coremark-pro/Config.in index dd6821056c..362826f47b 100644 --- a/package/coremark-pro/Config.in +++ b/package/coremark-pro/Config.in @@ -1,8 +1,13 @@ config BR2_PACKAGE_COREMARK_PRO bool "coremark-pro" depends on BR2_USE_MMU # perl uses fork() + depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_PERL help CoreMark-PRO is a comprehensive, advanced processor benchmark. https://www.eembc.org/coremark-pro/ + +comment "coremark-pro needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_MMU
Coremark-pro requires threads so add a depends on BR2_TOOLCHAIN_HAS_THREADS. Fixes: - http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/ Signed-off-by: Chris Packham <judge.packham@gmail.com> --- package/coremark-pro/Config.in | 5 +++++ 1 file changed, 5 insertions(+)