Message ID | 20201229135901.30090-1-narmstrong@baylibre.com |
---|---|
Headers | show |
Series | phy: add support for Amlogic Meson AXG MIPI-DSI PHY function | expand |
Hi Simon, Tom, Could you review patches 1 & 2 of this serie ? Thanks, Neil On 29/12/2020 14:58, Neil Armstrong wrote: > The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI > panels, this adds the bindings. > > This D-PHY depends on a separate analog PHY. > > The Amlogic AXG MIPI + PCIe Analog PHY provides function for both PCIe and > MIPI DSI at the same time. > > In order to configure the DSI PHY timings, a new "configure" PHY op is added to > permit dynamic (re)configuration of the PHY function. > > Finally, the Linux MIPI D-PHY configuration helpers are imported to provide a standard > set of default D-PHY timings, timings struct and correct calculations. > > Neil Armstrong (4): > phy: dphy: Add configuration helpers > generic-phy: add configure op > phy: Add Amlogic AXG MIPI D-PHY driver > phy: Add Amlogic AXG MIPI PCIe Analog PHY driver > > drivers/phy/Kconfig | 23 ++ > drivers/phy/Makefile | 3 + > drivers/phy/meson-axg-mipi-dphy.c | 393 +++++++++++++++++++++++ > drivers/phy/meson-axg-mipi-pcie-analog.c | 233 ++++++++++++++ > drivers/phy/phy-core-mipi-dphy.c | 161 ++++++++++ > drivers/phy/phy-uclass.c | 11 + > include/generic-phy.h | 23 ++ > include/phy-mipi-dphy.h | 284 ++++++++++++++++ > 8 files changed, 1131 insertions(+) > create mode 100644 drivers/phy/meson-axg-mipi-dphy.c > create mode 100644 drivers/phy/meson-axg-mipi-pcie-analog.c > create mode 100644 drivers/phy/phy-core-mipi-dphy.c > create mode 100644 include/phy-mipi-dphy.h >
On Mon, Jan 11, 2021 at 09:47:29AM +0100, Neil Armstrong wrote: > Hi Simon, Tom, > > Could you review patches 1 & 2 of this serie ? Patches 1 and 2 look fine to me, FWIW.
On 29/12/2020 14:58, Neil Armstrong wrote: > The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI > panels, this adds the bindings. > > This D-PHY depends on a separate analog PHY. > > The Amlogic AXG MIPI + PCIe Analog PHY provides function for both PCIe and > MIPI DSI at the same time. > > In order to configure the DSI PHY timings, a new "configure" PHY op is added to > permit dynamic (re)configuration of the PHY function. > > Finally, the Linux MIPI D-PHY configuration helpers are imported to provide a standard > set of default D-PHY timings, timings struct and correct calculations. > > Neil Armstrong (4): > phy: dphy: Add configuration helpers > generic-phy: add configure op > phy: Add Amlogic AXG MIPI D-PHY driver > phy: Add Amlogic AXG MIPI PCIe Analog PHY driver > > drivers/phy/Kconfig | 23 ++ > drivers/phy/Makefile | 3 + > drivers/phy/meson-axg-mipi-dphy.c | 393 +++++++++++++++++++++++ > drivers/phy/meson-axg-mipi-pcie-analog.c | 233 ++++++++++++++ > drivers/phy/phy-core-mipi-dphy.c | 161 ++++++++++ > drivers/phy/phy-uclass.c | 11 + > include/generic-phy.h | 23 ++ > include/phy-mipi-dphy.h | 284 ++++++++++++++++ > 8 files changed, 1131 insertions(+) > create mode 100644 drivers/phy/meson-axg-mipi-dphy.c > create mode 100644 drivers/phy/meson-axg-mipi-pcie-analog.c > create mode 100644 drivers/phy/phy-core-mipi-dphy.c > create mode 100644 include/phy-mipi-dphy.h > Applied to u-boot-amlogic Neil