Message ID | 1604764178-8087-1-git-send-email-kaixuxia@tencent.com |
---|---|
State | Accepted |
Headers | show |
Series | KVM: PPC: fix comparison to bool warning | expand |
On Sat, Nov 07, 2020 at 11:49:38PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia <kaixuxia@tencent.com> > > Fix the following coccicheck warning: > > ./arch/powerpc/kvm/booke.c:503:6-16: WARNING: Comparison to bool > ./arch/powerpc/kvm/booke.c:505:6-17: WARNING: Comparison to bool > ./arch/powerpc/kvm/booke.c:507:6-16: WARNING: Comparison to bool > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> Acked-by: Paul Mackerras <paulus@ozlabs.org>
On Sat, 7 Nov 2020 23:49:38 +0800, xiakaixu1987@gmail.com wrote: > Fix the following coccicheck warning: > > ./arch/powerpc/kvm/booke.c:503:6-16: WARNING: Comparison to bool > ./arch/powerpc/kvm/booke.c:505:6-17: WARNING: Comparison to bool > ./arch/powerpc/kvm/booke.c:507:6-16: WARNING: Comparison to bool Applied to powerpc/next. [1/1] KVM: PPC: fix comparison to bool warning https://git.kernel.org/powerpc/c/a300bf8c5f24bdeaa84925d1e0ec6221cbdc7597 cheers
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index b1abcb816439..288a9820ec01 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -500,11 +500,11 @@ static int kvmppc_booke_irqprio_deliver(struct kvm_vcpu *vcpu, vcpu->arch.regs.nip = vcpu->arch.ivpr | vcpu->arch.ivor[priority]; - if (update_esr == true) + if (update_esr) kvmppc_set_esr(vcpu, vcpu->arch.queued_esr); - if (update_dear == true) + if (update_dear) kvmppc_set_dar(vcpu, vcpu->arch.queued_dear); - if (update_epr == true) { + if (update_epr) { if (vcpu->arch.epr_flags & KVMPPC_EPR_USER) kvm_make_request(KVM_REQ_EPR_EXIT, vcpu); else if (vcpu->arch.epr_flags & KVMPPC_EPR_KERNEL) {