| Message ID | 20201210084232.1913871-1-icenowy@aosc.io |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | PineTab with new panel DT | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | fail | build log |
On Thu, 10 Dec 2020 16:42:32 +0800, Icenowy Zheng wrote: > Early adopters' PineTabs (and all further releases) will have a new LCD > panel different with the one that is used when in development (because > the old panel's supply discontinued). > > Add a new DT compatible for it. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote: > Early adopters' PineTabs (and all further releases) will have a new LCD > panel different with the one that is used when in development (because > the old panel's supply discontinued). > > Add a new DT compatible for it. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index 6db32fbf813f..73a6c8421172 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -700,6 +700,11 @@ properties: > - const: pine64,pinetab > - const: allwinner,sun50i-a64 > > + - description: Pine64 PineTab with new LCD panel > + items: > + - const: pine64,pinetab-new-panel > + - const: allwinner,sun50i-a64 > + We're on the right track, but new panel seems a bit too vague. What is going to happen when they will change the panel again? pinetab-early-adopter seems more robust there Maxime
于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech> 写到: >On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote: >> Early adopters' PineTabs (and all further releases) will have a new >LCD >> panel different with the one that is used when in development >(because >> the old panel's supply discontinued). >> >> Add a new DT compatible for it. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml >b/Documentation/devicetree/bindings/arm/sunxi.yaml >> index 6db32fbf813f..73a6c8421172 100644 >> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml >> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml >> @@ -700,6 +700,11 @@ properties: >> - const: pine64,pinetab >> - const: allwinner,sun50i-a64 >> >> + - description: Pine64 PineTab with new LCD panel >> + items: >> + - const: pine64,pinetab-new-panel >> + - const: allwinner,sun50i-a64 >> + > >We're on the right track, but new panel seems a bit too vague. What is >going to happen when they will change the panel again? > >pinetab-early-adopter seems more robust there This name will only match a batch. > >Maxime
On Tue, Dec 15, 2020 at 06:59:33AM +0800, Icenowy Zheng wrote: > 于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech> 写到: > >On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote: > >> Early adopters' PineTabs (and all further releases) will have a new > >LCD > >> panel different with the one that is used when in development > >(because > >> the old panel's supply discontinued). > >> > >> Add a new DT compatible for it. > >> > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > >> --- > >> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml > >b/Documentation/devicetree/bindings/arm/sunxi.yaml > >> index 6db32fbf813f..73a6c8421172 100644 > >> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > >> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > >> @@ -700,6 +700,11 @@ properties: > >> - const: pine64,pinetab > >> - const: allwinner,sun50i-a64 > >> > >> + - description: Pine64 PineTab with new LCD panel > >> + items: > >> + - const: pine64,pinetab-new-panel > >> + - const: allwinner,sun50i-a64 > >> + > > > >We're on the right track, but new panel seems a bit too vague. What is > >going to happen when they will change the panel again? > > > >pinetab-early-adopter seems more robust there > > This name will only match a batch. Look, I know the situation sucks. Can we actually move forward? Maxime
在 2020-12-16星期三的 14:00 +0100，Maxime Ripard写道： > On Tue, Dec 15, 2020 at 06:59:33AM +0800, Icenowy Zheng wrote: > > 于 2020年12月14日 GMT+08:00 下午6:37:04, Maxime Ripard <maxime@cerno.tech > > > 写到: > > > On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote: > > > > Early adopters' PineTabs (and all further releases) will have a > > > > new > > > LCD > > > > panel different with the one that is used when in development > > > (because > > > > the old panel's supply discontinued). > > > > > > > > Add a new DT compatible for it. > > > > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > > > --- > > > > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml > > > b/Documentation/devicetree/bindings/arm/sunxi.yaml > > > > index 6db32fbf813f..73a6c8421172 100644 > > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > > > @@ -700,6 +700,11 @@ properties: > > > > - const: pine64,pinetab > > > > - const: allwinner,sun50i-a64 > > > > > > > > + - description: Pine64 PineTab with new LCD panel > > > > + items: > > > > + - const: pine64,pinetab-new-panel > > > > + - const: allwinner,sun50i-a64 > > > > + > > > > > > We're on the right track, but new panel seems a bit too vague. > > > What is > > > going to happen when they will change the panel again? > > > > > > pinetab-early-adopter seems more robust there > > > > This name will only match a batch. > > Look, I know the situation sucks. Can we actually move forward? Descriptive name will match more things. I think we should still have something descriptive, even if "new panel" is too generic. > > Maxime
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index 6db32fbf813f..73a6c8421172 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -700,6 +700,11 @@ properties: - const: pine64,pinetab - const: allwinner,sun50i-a64 + - description: Pine64 PineTab with new LCD panel + items: + - const: pine64,pinetab-new-panel + - const: allwinner,sun50i-a64 + - description: Pine64 SoPine Baseboard items: - const: pine64,sopine-baseboard
Early adopters' PineTabs (and all further releases) will have a new LCD panel different with the one that is used when in development (because the old panel's supply discontinued). Add a new DT compatible for it. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ 1 file changed, 5 insertions(+)