diff mbox series

PR fortran/98284 - ICE in get_array_index

Message ID trinity-bac7d7a0-1bfc-4daa-b2ba-fd1535232bc5-1608065921455@3c-app-gmx-bap04
State New
Headers show
Series PR fortran/98284 - ICE in get_array_index | expand

Commit Message

Harald Anlauf Dec. 15, 2020, 8:58 p.m. UTC 
Dear all,

ICE-on-invalid: testcase by Arseny, draft patch by Steve,
slightly polished and regtested by me on x86_64-pc-linux-gnu.

OK for master?

Thanks,
Harald


PR fortran/98284 - ICE in get_array_index

Reject DATA elements with the ALLOCATABLE attribute also when they are
components of a derived type.

gcc/fortran/ChangeLog:

	PR fortran/98284
	* resolve.c (check_data_variable): Reject DATA elements with the
	ALLOCATABLE attribute.

gcc/testsuite/ChangeLog:

	PR fortran/98284
	* gfortran.dg/pr98284.f90: New test.

Comments

Thomas Koenig Dec. 16, 2020, 12:22 p.m. UTC | #1 
Hi Harald,

> ICE-on-invalid: testcase by Arseny, draft patch by Steve,
> slightly polished and regtested by me on x86_64-pc-linux-gnu.

OK for master.

Thanks for the patch!

Best regards

	Thomas
diff mbox series

Patch

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 327dffbebf2..05a5e43c90b 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -16169,6 +16169,13 @@  check_data_variable (gfc_data_variable *var, locus *where)
 	      return false;
 	    }
 	}
+
+      if (ref->type == REF_COMPONENT && ref->u.c.component->attr.allocatable)
+	{
+	  gfc_error ("DATA element %qs at %L cannot have the ALLOCATABLE "
+		     "attribute", ref->u.c.component->name, &e->where);
+	  return false;
+	}
     }

   if (e->rank == 0 || has_pointer)
diff --git a/gcc/testsuite/gfortran.dg/pr98284.f90 b/gcc/testsuite/gfortran.dg/pr98284.f90
new file mode 100644
index 00000000000..aa4b95c667c
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr98284.f90
@@ -0,0 +1,12 @@ 
+! { dg-do compile }
+! PR fortran/98284 - ICE in get_array_index
+
+program p
+  implicit none
+  type t
+     integer, allocatable :: h(:)
+  end type t
+  type(t) :: u
+  integer :: i
+  data (u% h(i),i=1,8) /8*1/ ! { dg-error "cannot have the ALLOCATABLE attribute" }
+end