Message ID | alpine.DEB.2.22.394.2012072206350.382403@digraph.polyomino.org.uk |
---|---|
State | New |
Headers | show |
Series | Use GMP 6.2.1 in build-many-glibcs.py | expand |
Ping. This patch <https://sourceware.org/pipermail/libc-alpha/2020-December/120524.html> is pending review.
Dear Joseph, I'd like to review this patch, but I don't know what the file scripts/build-many-glibcs.py is used for. Please can you tell me what I should do to review it, apart from checking that GMP 6.2.1 has been released (which is the case)? Paul > Date: Mon, 14 Dec 2020 17:52:47 +0000 > From: Joseph Myers <joseph@codesourcery.com> > > Ping. This patch > <https://sourceware.org/pipermail/libc-alpha/2020-December/120524.html> > is pending review. > > -- > Joseph S. Myers > joseph@codesourcery.com
Hi Paul, The build-many-glibcs.py is used among many things to bootstrap toolchains targeting glibc. It is also an standalone script, so it could be used independently of glibc itself. To bootstrap the toolchain, the script downloads pre-defined versions or repository versions of a set of tools. It is defined by the 'default_versions' at line 768. For entries values that starts with 'vcs' a branch from pre-defined repositories will be used (check for checkout_vcs) while for other entries the release tarball will be used instead (check for checkout_tar). Our current policy is to use either released branches or packages for the tools. It means that a version bump is usually done once the project new version is officially released. On 14/12/2020 15:08, Paul Zimmermann wrote: > Dear Joseph, > > I'd like to review this patch, but I don't know what the file > scripts/build-many-glibcs.py is used for. Please can you tell me > what I should do to review it, apart from checking that GMP 6.2.1 > has been released (which is the case)? > > Paul > >> Date: Mon, 14 Dec 2020 17:52:47 +0000 >> From: Joseph Myers <joseph@codesourcery.com> >> >> Ping. This patch >> <https://sourceware.org/pipermail/libc-alpha/2020-December/120524.html> >> is pending review. >> >> -- >> Joseph S. Myers >> joseph@codesourcery.com
On Mon, 14 Dec 2020, Paul Zimmermann wrote: > Dear Joseph, > > I'd like to review this patch, but I don't know what the file > scripts/build-many-glibcs.py is used for. Please can you tell me > what I should do to review it, apart from checking that GMP 6.2.1 > has been released (which is the case)? It's up to a reviewer to judge what they think needs review for a given patch. I'd expect review for this kind of build-many-glibcs.py patch to be minimal and essentially independent of which component is being updated; considerations would be along the lines of "does the patch have any extraneous diff hunks that don't belong there?", "are there any mistakes in the commit message?", "is the new version indeed the latest stable version of the relevant component?", "are there any well-known incompatibilities with the versions being used of other components that would indicate delaying the udpate?".
thank you Joseph. This patch looks good to me, GMP 6.2.1 is indeed the latest release. Paul > Date: Tue, 15 Dec 2020 01:16:42 +0000 > From: Joseph Myers <joseph@codesourcery.com> > > On Mon, 14 Dec 2020, Paul Zimmermann wrote: > > > Dear Joseph, > > > > I'd like to review this patch, but I don't know what the file > > scripts/build-many-glibcs.py is used for. Please can you tell me > > what I should do to review it, apart from checking that GMP 6.2.1 > > has been released (which is the case)? > > It's up to a reviewer to judge what they think needs review for a given > patch. I'd expect review for this kind of build-many-glibcs.py patch to > be minimal and essentially independent of which component is being > updated; considerations would be along the lines of "does the patch have > any extraneous diff hunks that don't belong there?", "are there any > mistakes in the commit message?", "is the new version indeed the latest > stable version of the relevant component?", "are there any well-known > incompatibilities with the versions being used of other components that > would indicate delaying the udpate?". > > -- > Joseph S. Myers > joseph@codesourcery.com >
diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py index afcbbcfb28..277e81dfc0 100755 --- a/scripts/build-many-glibcs.py +++ b/scripts/build-many-glibcs.py @@ -768,7 +768,7 @@ class Context(object): default_versions = {'binutils': 'vcs-2.35', 'gcc': 'vcs-10', 'glibc': 'vcs-mainline', - 'gmp': '6.2.0', + 'gmp': '6.2.1', 'linux': '5.9', 'mpc': '1.2.1', 'mpfr': '4.1.0',