diff mbox series

[v3,1/5] dt-bindings: irq: sun7i-nmi: Add binding documentation for the V3s NMI

Message ID 20201206165131.1041983-2-contact@paulk.fr
State Not Applicable, archived
Headers show
Series Allwinner V3 SL631 Action Camera Support and Related Fixes | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Paul Kocialkowski Dec. 6, 2020, 4:51 p.m. UTC
The V3s NMI controller seems register-compatible with the A80 (sun9i).
Add new items for the compatible string, with an entry specific to the V3s
and the A80 entry.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml       | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Dec. 7, 2020, 6:23 p.m. UTC | #1
On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> The V3s NMI controller seems register-compatible with the A80 (sun9i).
> Add new items for the compatible string, with an entry specific to the V3s
> and the A80 entry.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Paul Kocialkowski Dec. 9, 2020, 2:10 p.m. UTC | #2
Hi,

On Mon 07 Dec 20, 12:23, Rob Herring wrote:
> On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> > The V3s NMI controller seems register-compatible with the A80 (sun9i).
> > Add new items for the compatible string, with an entry specific to the V3s
> > and the A80 entry.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml       | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.

Ah sorry, it was indeed intentional as there was a change since this version
uses sun9i-a80 as a base and I also renamed the compatible.

I put that in the cover letter's changelog but maybe it wasn't very explicit.

Cheers,

Paul
Rob Herring Dec. 10, 2020, 10:28 p.m. UTC | #3
On Wed, Dec 9, 2020 at 8:11 AM Paul Kocialkowski <contact@paulk.fr> wrote:
>
> Hi,
>
> On Mon 07 Dec 20, 12:23, Rob Herring wrote:
> > On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> > > The V3s NMI controller seems register-compatible with the A80 (sun9i).
> > > Add new items for the compatible string, with an entry specific to the V3s
> > > and the A80 entry.
> > >
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > >  .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml       | 3 +++
> > >  1 file changed, 3 insertions(+)
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Ah sorry, it was indeed intentional as there was a change since this version
> uses sun9i-a80 as a base and I also renamed the compatible.
>
> I put that in the cover letter's changelog but maybe it wasn't very explicit.

Okay.

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
index 8acca0ae3129..4fd1e2780026 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
@@ -29,6 +29,9 @@  properties:
       - items:
           - const: allwinner,sun8i-a83t-r-intc
           - const: allwinner,sun6i-a31-r-intc
+      - items:
+          - const: allwinner,sun8i-v3s-nmi
+          - const: allwinner,sun9i-a80-nmi
       - const: allwinner,sun9i-a80-nmi
       - items:
           - const: allwinner,sun50i-a64-r-intc