Message ID | 20201028095816.23906-2-igor.opaniuk@gmail.com |
---|---|
State | Accepted |
Commit | 5d89afe27f3872a526db7e6e5614ba3b9093e46b |
Delegated to: | Stefano Babic |
Headers | show |
Series | [v1,1/9] toradex: tdx-cfg-clock: add new i.mx 8m mini/plus skus | expand |
On 10/28/20 6:58 PM, Igor Opaniuk wrote: > From: Max Krummenacher <max.krummenacher@toradex.com> > > The I2C address is 0x25, not 0x35. This according to the datasheet and > tests with a PCA9450A. > > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > > drivers/power/pmic/pca9450.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c > index 0c9d9a366e..c7f8b80954 100644 > --- a/drivers/power/pmic/pca9450.c > +++ b/drivers/power/pmic/pca9450.c > @@ -80,7 +80,7 @@ static struct dm_pmic_ops pca9450_ops = { > }; > > static const struct udevice_id pca9450_ids[] = { > - { .compatible = "nxp,pca9450a", .data = 0x35, }, > + { .compatible = "nxp,pca9450a", .data = 0x25, }, > { .compatible = "nxp,pca9450b", .data = 0x25, }, > { } > }; >
> From: Max Krummenacher <max.krummenacher@toradex.com> > The I2C address is 0x25, not 0x35. This according to the datasheet and > tests with a PCA9450A. > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c index 0c9d9a366e..c7f8b80954 100644 --- a/drivers/power/pmic/pca9450.c +++ b/drivers/power/pmic/pca9450.c @@ -80,7 +80,7 @@ static struct dm_pmic_ops pca9450_ops = { }; static const struct udevice_id pca9450_ids[] = { - { .compatible = "nxp,pca9450a", .data = 0x35, }, + { .compatible = "nxp,pca9450a", .data = 0x25, }, { .compatible = "nxp,pca9450b", .data = 0x25, }, { } };