diff mbox series

mptcp: print new line in mptcp_seq_show() if mptcp isn't in use

Message ID c1d61ab4-7626-7c97-7363-73dbc5fa3629@163.com
State Superseded
Headers show
Series mptcp: print new line in mptcp_seq_show() if mptcp isn't in use | expand

Commit Message

Jianguo Wu Dec. 4, 2020, 8:36 a.m. UTC 
From: Jianguo Wu <wujianguo@chinatelecom.cn>
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
---
 net/mptcp/mib.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Florian Westphal Dec. 4, 2020, 3:21 p.m. UTC | #1 
Jianguo Wu <wujianguo106@163.com> wrote:
> From: Jianguo Wu <wujianguo@chinatelecom.cn>

A brief explanation would have helped.
This is for net tree.

> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>

Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
Acked-by: Florian Westphal <fw@strlen.de>
Jakub Kicinski Dec. 4, 2020, 4:59 p.m. UTC | #2 
On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote:
> Jianguo Wu <wujianguo106@163.com> wrote:
> > From: Jianguo Wu <wujianguo@chinatelecom.cn>  
> 
> A brief explanation would have helped.

Yes, please post a v2 with a sentence describing the problem and output
before and after the change.

> This is for net tree.

By which we mean please tag v2 as [PATCH net v2] in the subject.

> > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>  
> 
> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
> Acked-by: Florian Westphal <fw@strlen.de>

And please make sure to add these to your patch before posting so
Florian doesn't have to resend them.
Jianguo Wu Dec. 5, 2020, 7:40 a.m. UTC | #3 
OK,I will post v2 soon, thanks!

在 2020/12/5 0:59, Jakub Kicinski 写道:
> On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote:
>> Jianguo Wu <wujianguo106@163.com> wrote:
>>> From: Jianguo Wu <wujianguo@chinatelecom.cn>  
>>
>> A brief explanation would have helped.
> 
> Yes, please post a v2 with a sentence describing the problem and output
> before and after the change.
> 
>> This is for net tree.
> 
> By which we mean please tag v2 as [PATCH net v2] in the subject.
> 
>>> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>  
>>
>> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
>> Acked-by: Florian Westphal <fw@strlen.de>
> 
> And please make sure to add these to your patch before posting so
> Florian doesn't have to resend them.
>
diff mbox series

Patch

diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
index 84d1194..b921cbd 100644
--- a/net/mptcp/mib.c
+++ b/net/mptcp/mib.c
@@ -67,6 +67,7 @@  void mptcp_seq_show(struct seq_file *seq)
 		for (i = 0; mptcp_snmp_list[i].name; i++)
 			seq_puts(seq, " 0");

+		seq_putc(seq, '\n');
 		return;
 	}