diff mbox series

[04/11] lib: sbi: Auto start domain only if boot HART within limits

Message ID 20201121094756.4154728-5-anup.patel@wdc.com
State Superseded
Headers show
Series OpenSBI domain configuration using device tree | expand

Commit Message

Anup Patel Nov. 21, 2020, 9:47 a.m. UTC 
The sbi_domain_finalize() should auto start a domain only if the
boot HART is withing limits (i.e. less than SBI_HARTMASK_MAX_BITS).

Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
 lib/sbi/sbi_domain.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Alistair Francis Dec. 1, 2020, 2 a.m. UTC | #1 
On Sat, 2020-11-21 at 15:17 +0530, Anup Patel wrote:
> The sbi_domain_finalize() should auto start a domain only if the
> boot HART is withing limits (i.e. less than SBI_HARTMASK_MAX_BITS).
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  lib/sbi/sbi_domain.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index ac920b8..ecb098c 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -403,6 +403,10 @@ int sbi_domain_finalize(struct sbi_scratch
> *scratch, u32 cold_hartid)
>                 /* Domain boot HART */
>                 dhart = dom->boot_hartid;
>  
> +               /* Ignore of boot HART is off limits */
> +               if (SBI_HARTMASK_MAX_BITS <= dhart)
> +                       continue;
> +
>                 /* Ignore if boot HART not possible for this domain
> */
>                 if (!sbi_hartmask_test_hart(dhart, dom-
> >possible_harts))
>                         continue;
Atish Patra Dec. 3, 2020, 11:57 p.m. UTC | #2 
On Sat, Nov 21, 2020 at 2:52 PM Anup Patel <anup.patel@wdc.com> wrote:
>
> The sbi_domain_finalize() should auto start a domain only if the
> boot HART is withing limits (i.e. less than SBI_HARTMASK_MAX_BITS).
>
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> ---
>  lib/sbi/sbi_domain.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index ac920b8..ecb098c 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -403,6 +403,10 @@ int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid)
>                 /* Domain boot HART */
>                 dhart = dom->boot_hartid;
>
> +               /* Ignore of boot HART is off limits */
> +               if (SBI_HARTMASK_MAX_BITS <= dhart)
> +                       continue;
> +
>                 /* Ignore if boot HART not possible for this domain */
>                 if (!sbi_hartmask_test_hart(dhart, dom->possible_harts))
>                         continue;
> --
> 2.25.1
>
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi


Reviewed-by: Atish Patra <atish.patra@wdc.com>
diff mbox series

Patch

diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
index ac920b8..ecb098c 100644
--- a/lib/sbi/sbi_domain.c
+++ b/lib/sbi/sbi_domain.c
@@ -403,6 +403,10 @@  int sbi_domain_finalize(struct sbi_scratch *scratch, u32 cold_hartid)
 		/* Domain boot HART */
 		dhart = dom->boot_hartid;
 
+		/* Ignore of boot HART is off limits */
+		if (SBI_HARTMASK_MAX_BITS <= dhart)
+			continue;
+
 		/* Ignore if boot HART not possible for this domain */
 		if (!sbi_hartmask_test_hart(dhart, dom->possible_harts))
 			continue;