Message ID | 1313462834-4008-3-git-send-email-agnel.joel@gmail.com |
---|---|
State | Rejected |
Delegated to: | Sandeep Paulraj |
Headers | show |
Dear Joel A Fernandes, In message <1313462834-4008-3-git-send-email-agnel.joel@gmail.com> you wrote: > Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> > Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com> > --- > include/configs/omap3_beagle.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h > index 6e66100..78d0aa2 100644 > --- a/include/configs/omap3_beagle.h > +++ b/include/configs/omap3_beagle.h > @@ -200,6 +200,7 @@ > #define CONFIG_EXTRA_ENV_SETTINGS \ > "loadaddr=0x82000000\0" \ > "usbtty=cdc_acm\0" \ > + "usbethaddr=de:ad:be:ef\0" \ NAK. We don;'t allow any static network configurations in the board config files, and especially not if they contain bogus data. Best regards, Wolfgang Denk
Dear Sandeep & Albert, In message <20110822220245.E99A911F9E74@gemini.denx.de> I wrote: > Dear Joel A Fernandes, > > In message <1313462834-4008-3-git-send-email-agnel.joel@gmail.com> you wrote: > > Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> > > Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com> > > --- > > include/configs/omap3_beagle.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h > > index 6e66100..78d0aa2 100644 > > --- a/include/configs/omap3_beagle.h > > +++ b/include/configs/omap3_beagle.h > > @@ -200,6 +200,7 @@ > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > "loadaddr=0x82000000\0" \ > > "usbtty=cdc_acm\0" \ > > + "usbethaddr=de:ad:be:ef\0" \ > > NAK. > > We don;'t allow any static network configurations in the board config > files, and especially not if they contain bogus data. I see this patch is already maked as "Awaiting Upstream" in Patchwork. Please make sure NOT to include it in any pull requests. Thanks. Best regards, Wolfgang Denk
+u-boot@lists.denx.de On Mon, Aug 22, 2011 at 5:08 PM, Wolfgang Denk <wd@denx.de> wrote: > Dear Sandeep & Albert, > > In message <20110822220245.E99A911F9E74@gemini.denx.de> I wrote: >> Dear Joel A Fernandes, >> >> In message <1313462834-4008-3-git-send-email-agnel.joel@gmail.com> you wrote: >> > Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> >> > Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com> >> > --- >> > include/configs/omap3_beagle.h | 1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h >> > index 6e66100..78d0aa2 100644 >> > --- a/include/configs/omap3_beagle.h >> > +++ b/include/configs/omap3_beagle.h >> > @@ -200,6 +200,7 @@ >> > #define CONFIG_EXTRA_ENV_SETTINGS \ >> > "loadaddr=0x82000000\0" \ >> > "usbtty=cdc_acm\0" \ >> > + "usbethaddr=de:ad:be:ef\0" \ >> >> NAK. >> >> We don;'t allow any static network configurations in the board config >> files, and especially not if they contain bogus data. > > I see this patch is already maked as "Awaiting Upstream" in Patchwork. > Please make sure NOT to include it in any pull requests. Hi Wolfgang, I will mark this patch as NAK in patchwork. thanks, Joel
> I see this patch is already maked as "Awaiting Upstream" in Patchwork. > Please make sure NOT to include it in any pull requests. Wolfgang, I am sure i didn't change the state of this patch to "Awaiting Upstream". Regards, Sandeep
(Adding my U-Boot address) Le 23/08/2011 04:05, Paulraj, Sandeep a écrit : > > >> I see this patch is already maked as "Awaiting Upstream" in Patchwork. >> Please make sure NOT to include it in any pull requests. > > Wolfgang, > > I am sure i didn't change the state of this patch to "Awaiting Upstream". I am quite sure I didn't either -- actually, I've been using "Accepted" for patches that I accept in u-boot-arm, instead of "Awaiting upstream" -- should I use the latter? Anyway, this one is not in my repo at all, and not in Sandeep's as I have it as a remote and up-to-date. > Regards, > Sandeep Amicalement,
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 6e66100..78d0aa2 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -200,6 +200,7 @@ #define CONFIG_EXTRA_ENV_SETTINGS \ "loadaddr=0x82000000\0" \ "usbtty=cdc_acm\0" \ + "usbethaddr=de:ad:be:ef\0" \ "console=ttyO2,115200n8\0" \ "mpurate=auto\0" \ "buddy=none "\